1. 26 Apr, 2018 22 commits
  2. 25 Apr, 2018 18 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #63159 from ii/kubeadm--config+verbose · 029c1d8b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61601, 62881, 63159). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      support simultaneous kubeadm --v and --config
      
      **What this PR does / why we need it**:
      
      Providing -v and --config parameters to increase verbosity while providing a kubeadm.config results in an error rather than providing the requested verbosity.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      
      Fixes https://github.com/kubernetes/kubeadm/issues/765
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      029c1d8b
    • Kubernetes Submit Queue's avatar
      Merge pull request #62881 from juanvallejo/jvallejo/wire-print-flags-get-cmd · 08d358e3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61601, 62881, 63159). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      wire print flags through get.go
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      Adds the PrintFlags pattern to `get.go`.
      Prerequisite to ongoing server-side printing work.
      
      cc @soltysh @deads2k
      08d358e3
    • Kubernetes Submit Queue's avatar
      Merge pull request #61601 from neolit123/test-join · 30101be0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61601, 62881, 63159). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      kubeadm: add test coverage to join.go
      
      **What this PR does / why we need it**:
      Add test coverage to `join.go`.
      
      A separate commit exports the function `ValidateJoinCommandLine()` from `join.go` so that testing this file is more flexible.
      
      Test coverage is at 76%. One untested part is successfully running `Join.Run()` without errors, but that requires a valid HTTPS API server running and a valid config. i got this partially working but gave up because i faced some cert / config blockers. suggestions on how to get that to work easily are welcome.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      
      NONE
      
      **Special notes for your reviewer**:
      
      NONE
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      30101be0
    • juanvallejo's avatar
      report outputFormat in PrintFlags err · ac6ca38d
      juanvallejo authored
      ac6ca38d
    • Alexander Brand's avatar
      8ea5be8d
    • juanvallejo's avatar
      wire printflags through additional cmds · 27bd4ded
      juanvallejo authored
      27bd4ded
    • Kubernetes Submit Queue's avatar
      Merge pull request #63040 from misterikkit/ecache-race · 62514022
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62432, 62868, 63040). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      scheduler: fix race condition in equivalence cache
      
      **What this PR does / why we need it**:
      This adds an equivalence cache test to exercise the race condition observed in https://github.com/kubernetes/kubernetes/issues/62921 and then fixes the race.
      
      The `Cache` interface needed a new method to check whether a `NodeInfo` is stale, and `genericScheduler` needed some plumbing to make the `Cache` object available to `podFitsOnNode()`.
      
      The solution is, right before writing to the eCache, check the scheduler cache to see if the current `NodeInfo` object is out of date. If the node is out of date, then don't write to the eCache. If the `NodeInfo` is stale, it is because of a cache update that should also invalidate the eCache entry. That invalidation either happens before `podFitsOnNode()` acquires the eCache lock (original bug, so we don't do the write) or blocks until we release that lock (removing the potentially bad entry).
      
      Fixes #62921 
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      equivalence cache is still alpha, so no release note.
      ```release-note
      NONE
      ```
      /sig scheduling
      /assign bsalalamat
      /assign resouer
      62514022
    • Kubernetes Submit Queue's avatar
      Merge pull request #62868 from lavalamp/refactor-patch · b942c535
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62432, 62868, 63040). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Refactor patch
      
      **What this PR does / why we need it**:
      
      Continue making patch handler readable.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      b942c535
    • Kubernetes Submit Queue's avatar
      Merge pull request #62432 from ixdy/pkg-generated-bindata · e63cf9a4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62432, 62868, 63040). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      bazel: generate pkg/generated/bindata.go at build time and remove from repo
      
      **What this PR does / why we need it**: `pkg/generated/bindata.go` is a generated file, and it's one that's easy for us to handle in bazel (we already handle `test/e2e/generated/bindata.go`, for example).
      
      The translations also have an additional generation step (`hack/update-translations.sh`) which I'm not handling here, but this enables us to remove the `bindata.go` files from the tree (when combined with #62151).
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      /assign @rmmh @cblecker @thockin @fejta
      e63cf9a4
    • juanvallejo's avatar
      wire PrintFlags through get cmd · 191a48f4
      juanvallejo authored
      191a48f4
    • juanvallejo's avatar
      move "get" cmd pieces to cmd/get · df6a7ea6
      juanvallejo authored
      df6a7ea6
    • Kubernetes Submit Queue's avatar
      Merge pull request #63141 from deads2k/cli-36-io-2 · 29630b51
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62982, 63075, 63067, 62877, 63141). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      update all set and get  commands for iostreams
      
      Sweeping more commands for the iostream pattern.   Trying to keep things about 300 lines each.  Delete is going to be big
      
      
      /assign @juanvallejo 
      
      ```release-note
      NONE
      ```
      29630b51
    • Kubernetes Submit Queue's avatar
      Merge pull request #62877 from deads2k/cli-34-describer · df489968
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62982, 63075, 63067, 62877, 63141). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      make describers more generic from the CLI
      
      I've made this change very small so the intent and explanation make sense to people.
      
      Clients are not generic.  Client**Configs** are generic.  We faced this distinction in the apiserver and it took us a little to hurdle it.  When you try to provide a generic example or function, you need to provide Client**Config**, not a kube clientset.  The reason is that the code you're calling may have generated their own clientset, may want to use a dynamic one, or may want to a simple restclient.  As we seek to make `kubectl` primitives more generally applicable, this is an example we'll want to follow.  I suspect we'll be making more changes along these veins as we tease out the generic pieces of `kubectl ` to make a friendly CLI library.
      
      
      @kubernetes/sig-cli-maintainers 
      
      /hold
      
      Holding for a few days to make sure that people have time to read and digest.
      
      ```release-note
      NONE
      ```
      df489968
    • Kubernetes Submit Queue's avatar
      Merge pull request #63067 from k82cn/k8s_63027 · e270b8aa
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62982, 63075, 63067, 62877, 63141). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Removed e2e test on empty NodeAffinity.
      Signed-off-by: 's avatarDa K. Ma <klaus1982.cn@gmail.com>
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #63027 
      
      **Special notes for your reviewer**:
      In #62448, we removed the validation on empty `nodeAffinity` which is already handled in scheduler: select no objects.
      
      **Release note**:
      ```release-note
      None
      ```
      e270b8aa
    • Kubernetes Submit Queue's avatar
      Merge pull request #63075 from deads2k/api-05-eliminate-indirection · 97287177
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62982, 63075, 63067, 62877, 63141). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      eliminate indirection from type registration
      
      Some years back there was a partial attempt to revamp api type registration, but the effort was never completed and this was before we started splitting schemes. With separate schemes, the idea of partial registration no longer makes sense.  This pull starts removing cruft from the registration process and pulls out a layer of indirection that isn't needed.
      
      @kubernetes/sig-api-machinery-pr-reviews 
      @lavalamp @cheftako @sttts @smarterclayton 
      
      Rebase cost is fairly high, so I'd like to avoid this lingering.
      
      /assign @sttts 
      /assign @cheftako 
      
      ```release-note
      NONE
      ```
      97287177
    • Kubernetes Submit Queue's avatar
      Merge pull request #62982 from dixudx/warning_kubelet_remote_sandbox · af5f9bc9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 62982, 63075, 63067, 62877, 63141). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      add warnings on using pod-infra-container-image for remote container runtime
      
      **What this PR does / why we need it**:
      We should warn on using `--pod-infra-container-image` to avoid confusions, when users are using remote container runtime.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #55676,#62388,#62732
      
      **Special notes for your reviewer**:
      /cc @kubernetes/sig-node-pr-reviews 
      
      **Release note**:
      
      ```release-note
      add warnings on using pod-infra-container-image for remote container runtime
      ```
      af5f9bc9
    • Chris McClimans's avatar
      b8128bda
    • Kubernetes Submit Queue's avatar
      Merge pull request #61926 from filbranden/cgroupdriver10 · 667dd711
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Update libcontainer to include PRs with fixes to systemd cgroup driver
      
      **What this PR does / why we need it**:
      
      PR opencontainers/runc#1754 works around an issue in manager.Apply(-1) that makes Kubelet startup hang when using systemd cgroup driver (by adding a timeout) and further PR opencontainers/runc#1772 fixes that bug by checking the proper error status before waiting on the channel.
          
      PR opencontainers/runc#1776 checks whether Delegate works in slices, which keeps libcontainer systemd cgroup driver working on systemd v237+.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #61474
      
      **Special notes for your reviewer**:
      /assign @derekwaynecarr
      cc @vikaschoudhary16 @sjenning @adelton @mrunalp 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      667dd711