1. 18 Jan, 2018 9 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #56960 from islinwb/remove_unused_code_ut_pkg · 44d0ba29
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 53631, 56960). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Remove unused code in UT files in pkg/
      
      **What this PR does / why we need it**:
      Remove unused code in UT files in pkg/ .
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      44d0ba29
    • Kubernetes Submit Queue's avatar
      Merge pull request #53631 from dixudx/enforce_cobra_required_flags · 048757b8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      update vendor spf13/cobra to enforce required flags
      
      **What this PR does / why we need it**:
      
      spf13/cobra#502 has enforced checking flags that marked as required, an error will be raised if unset.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*:fixes #54855
      xref #48400
      fixes kubernetes/kubectl#121 
      
      **Special notes for your reviewer**:
      /assign @liggitt @eparis 
      
      **Release note**:
      
      ```release-note
      kubectl now enforces required flags at a more fundamental level
      ```
      048757b8
    • Kubernetes Submit Queue's avatar
      Merge pull request #58428 from dixudx/kubeadm_remove_initializers · ace0e7a6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      kubeadm: remove Initializers (still in alpha) from admission control
      
      **What this PR does / why we need it**:
      Currently `Initializers` is still in alpha version, which should not be enabled by default, until promoted to beta.
      
      For kubeadm users, who still want to use `Initializers`, they can use `apiServerExtraArgs` through kubeadm config file to enable it when booting up the cluster.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes kubernetes/kubeadm#629
      
      **Special notes for your reviewer**:
      /assign @luxas 
      /area kubeadm
      /cc @kubernetes/sig-cluster-lifecycle-pr-reviews
      /cc @liggitt @jamiehannaford @timothysc 
      
      **Release note**:
      
      ```release-note
      Remove alpha Initializers from kubadm admission control
      ```
      ace0e7a6
    • Di Xu's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #48859 from victorgp/master · b7100f1e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Support for custom tls cipher suites in api server and kubelet
      
      **What this PR does / why we need it**:
      This pull request aims to solve the problem of users not able to set custom cipher suites in the api server.
      Several users have requested this given that some default ciphers are vulnerable.
      There is a discussion in #41038 of how to implement this. The options are:
      - Setting a fixed list of ciphers, but users will have different requirements so a fixed list would be problematic.
      - Letting the user set them by parameter, this requires adding a new parameter that could be pretty long with the list of all the ciphers.
      
      I implemented the second option, if the ciphers are not passed by parameter, the Go default ones will be used (same behavior as now).
      
      **Which issue this PR fixes** 
      fixes #41038 
      
      **Special notes for your reviewer**:
      The ciphers in Go tls config are constants and the ones passed by parameters are a comma-separated list. I needed to create the `type CipherSuitesFlag` to support that conversion/mapping, because i couldn't find any way to do this type of reflection in Go.
      If you think there is another way to implement this, let me know.
      
      If you want to test it out, this is a ciphers combination i tested without the weak ones:
      
      ```
      TLS_RSA_WITH_AES_128_CBC_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256,TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305,TLS_RSA_WITH_AES_128_CBC_SHA,TLS_RSA_WITH_AES_256_CBC_SHA,TLS_RSA_WITH_AES_128_GCM_SHA256,TLS_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA
      ```
      
      If this is merged i will implement the same for the Kubelet.
      
      **Release note**:
      ```release-note
      kube-apiserver and kubelet now support customizing TLS ciphers via a `--tls-cipher-suites` flag
      ```
      b7100f1e
    • Kubernetes Submit Queue's avatar
      Merge pull request #58255 from dixudx/kubeadm_add_newWebhooks · df27ac09
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Enable ValidatingAdmissionWebhook and MutatingAdmissionWebhook in kubeadm from v1.9
      
      **What this PR does / why we need it**:
      Since 1.9, `ValidatingAdmissionWebhook` and `MutatingAdmissionWebhook` are beta. Kubeadm should enable them by default. 
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes kubernetes/kubeadm#642
      
      **Special notes for your reviewer**:
      /assign @luxas 
      /cc @kubernetes/sig-cluster-lifecycle-pr-reviews 
      
      **Release note**:
      
      ```release-note
      Enable ValidatingAdmissionWebhook and MutatingAdmissionWebhook in kubeadm from v1.9
      ```
      df27ac09
    • Kubernetes Submit Queue's avatar
      Merge pull request #52863 from brahmaroutu/conformance_doc · 8db63e20
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 58411, 58407, 52863). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Create Conformance document to display all tests that belong to Confo…
      
      …rmance suite
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      8db63e20
    • Kubernetes Submit Queue's avatar
      Merge pull request #58407 from deads2k/cmd-01-sweep-for-simple · f9a58c52
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 58411, 58407, 52863). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      low hanging fruit for using cobra commands
      
      This makes the simple updates to use cobra commands instead of individual ones
      
      /assign liggitt
      /assign ncdc
      /assign sttts
      f9a58c52
    • Kubernetes Submit Queue's avatar
      Merge pull request #58411 from sttts/sttts-compile-fix-bootstrap-token-api · 12b5bf9e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 58411, 58407, 52863). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      client-go: fix bootstrap token imports
      
      Fixes the publishing-bot https://github.com/kubernetes/kubernetes/issues/56876#issuecomment-358429408.
      
      Introduced by https://github.com/kubernetes/kubernetes/pull/55595
      12b5bf9e
  2. 17 Jan, 2018 31 commits