• Kubernetes Submit Queue's avatar
    Merge pull request #40932 from peay/cronjob-max-finished-jobs · 80e6492f
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 40932, 41896, 41815, 41309, 41628)
    
    Modify CronJob API to add job history limits, cleanup jobs in controller
    
    **What this PR does / why we need it**:
    As discussed in #34710: this adds two limits to `CronJobSpec`, to limit the number of finished jobs created by a CronJob to keep.
    
    **Which issue this PR fixes**: fixes #34710
    
    **Special notes for your reviewer**:
    
    cc @soltysh, please have a look and let me know what you think -- I'll then add end to end testing and update the doc in a separate commit. What is the timeline to get this into 1.6?
    
    The plan:
    
    - [x] API changes
      - [x] Changing versioned APIs
        - [x] `types.go`
        - [x] `defaults.go` (nothing to do)
        - [x] `conversion.go` (nothing to do?)
        - [x] `conversion_test.go` (nothing to do?)
      - [x] Changing the internal structure
        - [x] `types.go`
        - [x] `validation.go`
        - [x] `validation_test.go`
      - [x] Edit version conversions
        - [x] Edit (nothing to do?)
        - [x] Run `hack/update-codegen.sh`
      - [x] Generate protobuf objects
        - [x] Run `hack/update-generated-protobuf.sh`
      - [x] Generate json (un)marshaling code
        - [x] Run `hack/update-codecgen.sh`
      - [x] Update fuzzer
    - [x] Actual logic
    - [x] Unit tests
    - [x] End to end tests
    - [x] Documentation changes and API specs update in separate commit
    
    
    **Release note**:
    
    ```release-note
    Add configurable limits to CronJob resource to specify how many successful and failed jobs are preserved.
    ```
    80e6492f
Name
Last commit
Last update
..
bootstrap Loading commit data...
certificates Loading commit data...
cloud Loading commit data...
cronjob Loading commit data...
daemon Loading commit data...
deployment Loading commit data...
disruption Loading commit data...
endpoint Loading commit data...
garbagecollector Loading commit data...
informers Loading commit data...
job Loading commit data...
namespace Loading commit data...
node Loading commit data...
podautoscaler Loading commit data...
podgc Loading commit data...
replicaset Loading commit data...
replication Loading commit data...
resourcequota Loading commit data...
route Loading commit data...
service Loading commit data...
serviceaccount Loading commit data...
statefulset Loading commit data...
ttl Loading commit data...
volume Loading commit data...
.import-restrictions Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
client_builder.go Loading commit data...
controller_ref_manager.go Loading commit data...
controller_utils.go Loading commit data...
controller_utils_test.go Loading commit data...
doc.go Loading commit data...
lookup_cache.go Loading commit data...