• Kubernetes Submit Queue's avatar
    Merge pull request #40932 from peay/cronjob-max-finished-jobs · 80e6492f
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 40932, 41896, 41815, 41309, 41628)
    
    Modify CronJob API to add job history limits, cleanup jobs in controller
    
    **What this PR does / why we need it**:
    As discussed in #34710: this adds two limits to `CronJobSpec`, to limit the number of finished jobs created by a CronJob to keep.
    
    **Which issue this PR fixes**: fixes #34710
    
    **Special notes for your reviewer**:
    
    cc @soltysh, please have a look and let me know what you think -- I'll then add end to end testing and update the doc in a separate commit. What is the timeline to get this into 1.6?
    
    The plan:
    
    - [x] API changes
      - [x] Changing versioned APIs
        - [x] `types.go`
        - [x] `defaults.go` (nothing to do)
        - [x] `conversion.go` (nothing to do?)
        - [x] `conversion_test.go` (nothing to do?)
      - [x] Changing the internal structure
        - [x] `types.go`
        - [x] `validation.go`
        - [x] `validation_test.go`
      - [x] Edit version conversions
        - [x] Edit (nothing to do?)
        - [x] Run `hack/update-codegen.sh`
      - [x] Generate protobuf objects
        - [x] Run `hack/update-generated-protobuf.sh`
      - [x] Generate json (un)marshaling code
        - [x] Run `hack/update-codecgen.sh`
      - [x] Update fuzzer
    - [x] Actual logic
    - [x] Unit tests
    - [x] End to end tests
    - [x] Documentation changes and API specs update in separate commit
    
    
    **Release note**:
    
    ```release-note
    Add configurable limits to CronJob resource to specify how many successful and failed jobs are preserved.
    ```
    80e6492f
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
hooks Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
translations Loading commit data...
vendor Loading commit data...
.bazelrc Loading commit data...
.gazelcfg.json Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
BUILD.bazel Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
Vagrantfile Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...