• Kubernetes Submit Queue's avatar
    Merge pull request #36964 from ixdy/gobin-build · 7ec3be4c
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    Build vendored copy of go-bindata and use that in go generate step
    
    **What this PR does / why we need it**: as the title says, uses the vendored version of `go-bindata` rather than expecting developers to `go get` it (when building outside docker).
    
    **Which issue this PR fixes**: fixes #34067, partially addresses #36655
    
    **Special notes for your reviewer**: we still call `go generate` far too many times:
    ```console
    ~/.../src/k8s.io/kubernetes $ which go-bindata
    ~/.../src/k8s.io/kubernetes $ make
    +++ [1116 17:35:28] Building the toolchain targets:
        k8s.io/kubernetes/hack/cmd/teststale
        k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
    +++ [1116 17:35:29] Generating bindata:
        test/e2e/framework/gobindata_util.go
    +++ [1116 17:35:30] Building go targets for linux/amd64:
        cmd/libs/go2idl/deepcopy-gen
    +++ [1116 17:35:35] Building the toolchain targets:
        k8s.io/kubernetes/hack/cmd/teststale
        k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
    +++ [1116 17:35:35] Generating bindata:
        test/e2e/framework/gobindata_util.go
    +++ [1116 17:35:36] Building go targets for linux/amd64:
        cmd/libs/go2idl/defaulter-gen
    +++ [1116 17:35:41] Building the toolchain targets:
        k8s.io/kubernetes/hack/cmd/teststale
        k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
    +++ [1116 17:35:41] Generating bindata:
        test/e2e/framework/gobindata_util.go
    +++ [1116 17:35:42] Building go targets for linux/amd64:
        cmd/libs/go2idl/conversion-gen
    +++ [1116 17:35:47] Building the toolchain targets:
        k8s.io/kubernetes/hack/cmd/teststale
        k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
    +++ [1116 17:35:47] Generating bindata:
        test/e2e/framework/gobindata_util.go
    +++ [1116 17:35:48] Building go targets for linux/amd64:
        cmd/libs/go2idl/openapi-gen
    +++ [1116 17:35:56] Building the toolchain targets:
        k8s.io/kubernetes/hack/cmd/teststale
        k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
    +++ [1116 17:35:56] Generating bindata:
        test/e2e/framework/gobindata_util.go
    ```
    Fixing that is a separate effort, though.
    
    cc @sebgoa @ZhangBanger
    7ec3be4c
Name
Last commit
Last update
..
etcd.sh Loading commit data...
golang.sh Loading commit data...
init.sh Loading commit data...
swagger.sh Loading commit data...
test.sh Loading commit data...
util.sh Loading commit data...
version.sh Loading commit data...