• Kubernetes Submit Queue's avatar
    Merge pull request #36964 from ixdy/gobin-build · 7ec3be4c
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    Build vendored copy of go-bindata and use that in go generate step
    
    **What this PR does / why we need it**: as the title says, uses the vendored version of `go-bindata` rather than expecting developers to `go get` it (when building outside docker).
    
    **Which issue this PR fixes**: fixes #34067, partially addresses #36655
    
    **Special notes for your reviewer**: we still call `go generate` far too many times:
    ```console
    ~/.../src/k8s.io/kubernetes $ which go-bindata
    ~/.../src/k8s.io/kubernetes $ make
    +++ [1116 17:35:28] Building the toolchain targets:
        k8s.io/kubernetes/hack/cmd/teststale
        k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
    +++ [1116 17:35:29] Generating bindata:
        test/e2e/framework/gobindata_util.go
    +++ [1116 17:35:30] Building go targets for linux/amd64:
        cmd/libs/go2idl/deepcopy-gen
    +++ [1116 17:35:35] Building the toolchain targets:
        k8s.io/kubernetes/hack/cmd/teststale
        k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
    +++ [1116 17:35:35] Generating bindata:
        test/e2e/framework/gobindata_util.go
    +++ [1116 17:35:36] Building go targets for linux/amd64:
        cmd/libs/go2idl/defaulter-gen
    +++ [1116 17:35:41] Building the toolchain targets:
        k8s.io/kubernetes/hack/cmd/teststale
        k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
    +++ [1116 17:35:41] Generating bindata:
        test/e2e/framework/gobindata_util.go
    +++ [1116 17:35:42] Building go targets for linux/amd64:
        cmd/libs/go2idl/conversion-gen
    +++ [1116 17:35:47] Building the toolchain targets:
        k8s.io/kubernetes/hack/cmd/teststale
        k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
    +++ [1116 17:35:47] Generating bindata:
        test/e2e/framework/gobindata_util.go
    +++ [1116 17:35:48] Building go targets for linux/amd64:
        cmd/libs/go2idl/openapi-gen
    +++ [1116 17:35:56] Building the toolchain targets:
        k8s.io/kubernetes/hack/cmd/teststale
        k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
    +++ [1116 17:35:56] Generating bindata:
        test/e2e/framework/gobindata_util.go
    ```
    Fixing that is a separate effort, though.
    
    cc @sebgoa @ZhangBanger
    7ec3be4c
Name
Last commit
Last update
..
boilerplate Loading commit data...
cmd/teststale Loading commit data...
e2e-internal Loading commit data...
gen-swagger-doc Loading commit data...
jenkins Loading commit data...
lib Loading commit data...
make-rules Loading commit data...
testdata Loading commit data...
verify-flags Loading commit data...
.linted_packages Loading commit data...
OWNERS Loading commit data...
autogenerated_placeholder.txt Loading commit data...
benchmark-go.sh Loading commit data...
benchmark-integration.sh Loading commit data...
build-cross.sh Loading commit data...
build-go.sh Loading commit data...
build-ui.sh Loading commit data...
cherry_pick_pull.sh Loading commit data...
dev-build-and-push.sh Loading commit data...
dev-build-and-up.sh Loading commit data...
dev-push-hyperkube.sh Loading commit data...
e2e-node-test.sh Loading commit data...
e2e.go Loading commit data...
federated-ginkgo-e2e.sh Loading commit data...
generate-bindata.sh Loading commit data...
generate-docs.sh Loading commit data...
get-build.sh Loading commit data...
ginkgo-e2e.sh Loading commit data...
godep-save.sh Loading commit data...
grab-profiles.sh Loading commit data...
install-etcd.sh Loading commit data...
list-feature-tests.sh Loading commit data...
local-up-cluster.sh Loading commit data...
lookup_pull.py Loading commit data...
run-in-gopath.sh Loading commit data...
test-cmd.sh Loading commit data...
test-go.sh Loading commit data...
test-integration.sh Loading commit data...
test-update-storage-objects.sh Loading commit data...
update-all.sh Loading commit data...
update-api-reference-docs.sh Loading commit data...
update-bazel.sh Loading commit data...
update-codecgen.sh Loading commit data...
update-codegen.sh Loading commit data...
update-federation-api-reference-docs.sh Loading commit data...
update-federation-generated-swagger-docs.sh Loading commit data...
update-federation-openapi-spec.sh Loading commit data...
update-federation-swagger-spec.sh Loading commit data...
update-generated-docs.sh Loading commit data...
update-generated-protobuf-dockerized.sh Loading commit data...
update-generated-protobuf.sh Loading commit data...
update-generated-runtime-dockerized.sh Loading commit data...
update-generated-runtime.sh Loading commit data...
update-generated-swagger-docs.sh Loading commit data...
update-godep-licenses.sh Loading commit data...
update-gofmt.sh Loading commit data...
update-munge-docs.sh Loading commit data...
update-openapi-spec.sh Loading commit data...
update-staging-client-go.sh Loading commit data...
update-swagger-spec.sh Loading commit data...
update_owners.py Loading commit data...
verify-all.sh Loading commit data...
verify-api-groups.sh Loading commit data...
verify-api-reference-docs.sh Loading commit data...
verify-bazel.sh Loading commit data...
verify-boilerplate.sh Loading commit data...
verify-cli-conventions.sh Loading commit data...
verify-codecgen.sh Loading commit data...
verify-codegen.sh Loading commit data...
verify-description.sh Loading commit data...
verify-federation-openapi-spec.sh Loading commit data...
verify-flags-underscore.py Loading commit data...
verify-generated-docs.sh Loading commit data...
verify-generated-protobuf.sh Loading commit data...
verify-generated-runtime.sh Loading commit data...
verify-generated-swagger-docs.sh Loading commit data...
verify-godep-licenses.sh Loading commit data...
verify-godeps.sh Loading commit data...
verify-gofmt.sh Loading commit data...
verify-golint.sh Loading commit data...
verify-govet.sh Loading commit data...
verify-import-boss.sh Loading commit data...
verify-linkcheck.sh Loading commit data...
verify-munge-docs.sh Loading commit data...
verify-openapi-spec.sh Loading commit data...
verify-pkg-names.sh Loading commit data...
verify-staging-client-go.sh Loading commit data...
verify-swagger-spec.sh Loading commit data...
verify-symbols.sh Loading commit data...
verify-test-images.sh Loading commit data...
verify-test-owners.sh Loading commit data...