• Kubernetes Submit Queue's avatar
    Merge pull request #58193 from Random-Liu/fix-resource-collector-panic · 3107fb4f
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 58216, 58193, 53033, 58219, 55921). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Use GinkgoRecover to avoid panic.
    
    See this in the test:
    ```
    I0111 14:28:31.010] panic: 
    I0111 14:28:31.010] Your test failed.
    I0111 14:28:31.010] Ginkgo panics to prevent subsequent assertions from running.
    I0111 14:28:31.011] Normally Ginkgo rescues this panic so you shouldn't see it.
    I0111 14:28:31.011] 
    I0111 14:28:31.011] But, if you make an assertion in a goroutine, Ginkgo can't capture the panic.
    I0111 14:28:31.011] To circumvent this, you should call
    I0111 14:28:31.011] 
    I0111 14:28:31.012] 	defer GinkgoRecover()
    I0111 14:28:31.012] 
    I0111 14:28:31.012] at the top of the goroutine that caused this panic.
    I0111 14:28:31.012] 
    I0111 14:28:31.012] 
    I0111 14:28:31.012] goroutine 1028 [running]:
    I0111 14:28:31.013] k8s.io/kubernetes/vendor/github.com/onsi/ginkgo.Fail(0xc421098000, 0xb0, 0xc420da24c8, 0x1, 0x1)
    I0111 14:28:31.013] 	/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/ginkgo_dsl.go:255 +0xda
    I0111 14:28:31.014] k8s.io/kubernetes/vendor/github.com/onsi/gomega/internal/assertion.(*Assertion).match(0xc4220bd700, 0x9e897e0, 0xa123640, 0x0, 0x0, 0x0, 0x0, 0xa123640)
    I0111 14:28:31.014] 	/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/onsi/gomega/internal/assertion/assertion.go:69 +0x1ef
    I0111 14:28:31.014] k8s.io/kubernetes/vendor/github.com/onsi/gomega/internal/assertion.(*Assertion).NotTo(0xc4220bd700, 0x9e897e0, 0xa123640, 0x0, 0x0, 0x0, 0xc4220bd700)
    I0111 14:28:31.015] 	/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/onsi/gomega/internal/assertion/assertion.go:43 +0xae
    I0111 14:28:31.015] k8s.io/kubernetes/test/e2e_node.deletePodsSync.func1(0xc421485220, 0xc421321680, 0xc421517180)
    I0111 14:28:31.015] 	/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e_node/resource_collector.go:382 +0x320
    I0111 14:28:31.015] created by k8s.io/kubernetes/test/e2e_node.deletePodsSync
    I0111 14:28:31.016] 	/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e_node/resource_collector.go:375 +0x9e
    ```
    
    e.g.: https://storage.googleapis.com/kubernetes-jenkins/logs/ci-cri-containerd-node-e2e-serial/17/build-log.txt
    
    **Release note**:
    
    ```release-note
    none
    ```
    3107fb4f
Name
Last commit
Last update
..
builder Loading commit data...
conformance Loading commit data...
environment Loading commit data...
jenkins Loading commit data...
perftype Loading commit data...
remote Loading commit data...
runner Loading commit data...
services Loading commit data...
system Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
README.md Loading commit data...
apparmor_test.go Loading commit data...
benchmark_util.go Loading commit data...
container.go Loading commit data...
container_manager_test.go Loading commit data...
cpu_manager_test.go Loading commit data...
critical_pod_test.go Loading commit data...
density_test.go Loading commit data...
device_plugin.go Loading commit data...
doc.go Loading commit data...
docker_test.go Loading commit data...
docker_util.go Loading commit data...
dockershim_checkpoint_test.go Loading commit data...
dynamic_kubelet_config_test.go Loading commit data...
e2e_node_suite_test.go Loading commit data...
eviction_test.go Loading commit data...
framework.go Loading commit data...
garbage_collector_test.go Loading commit data...
gke_environment_test.go Loading commit data...
gpu_device_plugin.go Loading commit data...
gpus.go Loading commit data...
gubernator.sh Loading commit data...
image_id_test.go Loading commit data...
image_list.go Loading commit data...
kubelet_test.go Loading commit data...
lifecycle_hook_test.go Loading commit data...
log_path_test.go Loading commit data...
memory_eviction_test.go Loading commit data...
mirror_pod_test.go Loading commit data...
node_container_manager_test.go Loading commit data...
node_problem_detector_linux.go Loading commit data...
pods_container_manager_test.go Loading commit data...
resource_collector.go Loading commit data...
resource_usage_test.go Loading commit data...
restart_test.go Loading commit data...
runtime_conformance_test.go Loading commit data...
security_context_test.go Loading commit data...
simple_mount.go Loading commit data...
summary_test.go Loading commit data...
util.go Loading commit data...
volume_manager_test.go Loading commit data...