1. 13 Jan, 2018 21 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #58205 from stewart-yu/test_release · 66043059
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix error when run release.sh not in {KUBE_ROOT}
      
      **What this PR does / why we need it**:
      add `${KUBE_ROOT}/` in directory, otherwise run 
      ```shell
      cd kubernetes/build  
      ./release.sh
      ```
      will exit:
      ```shell
      +++ [0112 18:18:48] Verifying Prerequisites....
      cp: cannot stat ‘build/build-image/Dockerfile’: No such file or directory
      !!! [0112 18:18:48] Call tree:
      !!! [0112 18:18:48]  1: ./release.sh:35 kube::build::build_image(...)
      !!! Error in ./../build/common.sh:454
        Error in ./../build/common.sh:454. '((i<3-1))' exited with status 1
      Call stack:
        1: ./../build/common.sh:454 kube::build::build_image(...)
        2: ./release.sh:35 main(...)
      Exiting with status 1
      ```
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      66043059
    • Kubernetes Submit Queue's avatar
      Merge pull request #55921 from ScorpioCPH/fix-endpoint-ut · 9007df35
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 58216, 58193, 53033, 58219, 55921). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix device plugin endpoint UT
      
      **What this PR does / why we need it**:
      Fix some issues in device plugin endpoint UT.
      
      **Which issue(s) this PR fixes**:
      Fixes #55920
      
      **Special notes for your reviewer**:
      
      @jiayingz @RenaudWasTaken @lichuqiang PTAL.
      
      /sig node
      
      **Release note**:
      
      ```release-note
      None
      ```
      9007df35
    • Kubernetes Submit Queue's avatar
      Merge pull request #58219 from ixdy/bazel-skylib-check-version · 4e493efa
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 58216, 58193, 53033, 58219, 55921). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Use the bazel version check function from bazel-skylib
      
      **What this PR does / why we need it**: fixes a bug in parsing the bazel version when a component has more than one digit, e.g. "0.10.0".
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      x-ref https://github.com/bazelbuild/bazel/issues/4425
      
      **Special notes for your reviewer**: we also need to update rules_go, but that's a more invasive change, so I've saved that for another PR.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      /assign @BenTheElder @mikedanese
      4e493efa
    • Kubernetes Submit Queue's avatar
      Merge pull request #53033 from oomichi/golint · f42dd346
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 58216, 58193, 53033, 58219, 55921). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix golint errors on test/e2e/e2e.go
      
      **What this PR does / why we need it**:
      
      When running golint on test/e2e/e2e.go, the following erros
      were faced:
      
       $ golint e2e.go
       e2e.go:329:2: var metricsJson should be metricsJSON
       e2e.go:342:1: comment on exported function RunE2ETests should be of the form "RunE2ETests ..."
      
      This PR fixes them.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      `NONE`
      
      **Special notes for your reviewer**:
      
      `NONE`
      
      **Release note**:
      
      `NONE`
      f42dd346
    • Kubernetes Submit Queue's avatar
      Merge pull request #58193 from Random-Liu/fix-resource-collector-panic · 3107fb4f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 58216, 58193, 53033, 58219, 55921). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Use GinkgoRecover to avoid panic.
      
      See this in the test:
      ```
      I0111 14:28:31.010] panic: 
      I0111 14:28:31.010] Your test failed.
      I0111 14:28:31.010] Ginkgo panics to prevent subsequent assertions from running.
      I0111 14:28:31.011] Normally Ginkgo rescues this panic so you shouldn't see it.
      I0111 14:28:31.011] 
      I0111 14:28:31.011] But, if you make an assertion in a goroutine, Ginkgo can't capture the panic.
      I0111 14:28:31.011] To circumvent this, you should call
      I0111 14:28:31.011] 
      I0111 14:28:31.012] 	defer GinkgoRecover()
      I0111 14:28:31.012] 
      I0111 14:28:31.012] at the top of the goroutine that caused this panic.
      I0111 14:28:31.012] 
      I0111 14:28:31.012] 
      I0111 14:28:31.012] goroutine 1028 [running]:
      I0111 14:28:31.013] k8s.io/kubernetes/vendor/github.com/onsi/ginkgo.Fail(0xc421098000, 0xb0, 0xc420da24c8, 0x1, 0x1)
      I0111 14:28:31.013] 	/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/ginkgo_dsl.go:255 +0xda
      I0111 14:28:31.014] k8s.io/kubernetes/vendor/github.com/onsi/gomega/internal/assertion.(*Assertion).match(0xc4220bd700, 0x9e897e0, 0xa123640, 0x0, 0x0, 0x0, 0x0, 0xa123640)
      I0111 14:28:31.014] 	/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/onsi/gomega/internal/assertion/assertion.go:69 +0x1ef
      I0111 14:28:31.014] k8s.io/kubernetes/vendor/github.com/onsi/gomega/internal/assertion.(*Assertion).NotTo(0xc4220bd700, 0x9e897e0, 0xa123640, 0x0, 0x0, 0x0, 0xc4220bd700)
      I0111 14:28:31.015] 	/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/github.com/onsi/gomega/internal/assertion/assertion.go:43 +0xae
      I0111 14:28:31.015] k8s.io/kubernetes/test/e2e_node.deletePodsSync.func1(0xc421485220, 0xc421321680, 0xc421517180)
      I0111 14:28:31.015] 	/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e_node/resource_collector.go:382 +0x320
      I0111 14:28:31.015] created by k8s.io/kubernetes/test/e2e_node.deletePodsSync
      I0111 14:28:31.016] 	/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e_node/resource_collector.go:375 +0x9e
      ```
      
      e.g.: https://storage.googleapis.com/kubernetes-jenkins/logs/ci-cri-containerd-node-e2e-serial/17/build-log.txt
      
      **Release note**:
      
      ```release-note
      none
      ```
      3107fb4f
    • Kubernetes Submit Queue's avatar
      Merge pull request #58216 from php-coder/suppress_pushd_popd_output · 6ca3d0ea
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      generate-bindata.sh: make output cleanly by suppressing pushd/popd output
      
      **What this PR does / why we need it**:
      `generate-bindata.sh` script produce extra output that is caused by `pushd`/`popd` usage. To make script output clean and to simplify debugging process, I suggest to suppress pushd/popd output.
      
      Before this PR:
      ```console
      $ make generated_files 
      +++ [0112 15:46:26] Building the toolchain targets:
      	k8s.io/kubernetes/hack/cmd/teststale
      	k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
      +++ [0112 15:46:27] Generating bindata:
      	test/e2e/generated/gobindata_util.go
      ~/git/src/home/kubernetes ~/git/src/home/kubernetes/test/e2e/generated
      ~/git/src/home/kubernetes/test/e2e/generated
      +++ [0112 15:46:27] Building go targets for linux/amd64:
      	./vendor/k8s.io/code-generator/cmd/deepcopy-gen
      +++ [0112 15:46:34] Building the toolchain targets:
      	k8s.io/kubernetes/hack/cmd/teststale
      	k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
      +++ [0112 15:46:34] Generating bindata:
      	test/e2e/generated/gobindata_util.go
      ~/git/src/home/kubernetes ~/git/src/home/kubernetes/test/e2e/generated
      ~/git/src/home/kubernetes/test/e2e/generated
      +++ [0112 15:46:34] Building go targets for linux/amd64:
      	./vendor/k8s.io/code-generator/cmd/defaulter-gen
      +++ [0112 15:46:38] Building the toolchain targets:
      	k8s.io/kubernetes/hack/cmd/teststale
      	k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
      +++ [0112 15:46:38] Generating bindata:
      	test/e2e/generated/gobindata_util.go
      ~/git/src/home/kubernetes ~/git/src/home/kubernetes/test/e2e/generated
      ~/git/src/home/kubernetes/test/e2e/generated
      +++ [0112 15:46:39] Building go targets for linux/amd64:
      	./vendor/k8s.io/code-generator/cmd/conversion-gen
      ```
      
      After this PR:
      ```console
      $ make generated_files 
      +++ [0112 16:28:31] Building the toolchain targets:
          k8s.io/kubernetes/hack/cmd/teststale
          k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
      +++ [0112 16:28:32] Generating bindata:
          test/e2e/generated/gobindata_util.go
      +++ [0112 16:28:32] Building go targets for linux/amd64:
          ./vendor/k8s.io/code-generator/cmd/deepcopy-gen
      +++ [0112 16:28:39] Building the toolchain targets:
          k8s.io/kubernetes/hack/cmd/teststale
          k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
      +++ [0112 16:28:39] Generating bindata:
          test/e2e/generated/gobindata_util.go
      +++ [0112 16:28:39] Building go targets for linux/amd64:
          ./vendor/k8s.io/code-generator/cmd/defaulter-gen
      +++ [0112 16:28:43] Building the toolchain targets:
          k8s.io/kubernetes/hack/cmd/teststale
          k8s.io/kubernetes/vendor/github.com/jteeuwen/go-bindata/go-bindata
      +++ [0112 16:28:43] Generating bindata:
          test/e2e/generated/gobindata_util.go
      +++ [0112 16:28:44] Building go targets for linux/amd64:
          ./vendor/k8s.io/code-generator/cmd/conversion-gen
      
      ```
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      CC @simo5
      6ca3d0ea
    • Kubernetes Submit Queue's avatar
      Merge pull request #57843 from p0lyn0mial/wire_generic_scaler · 52a2256b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      wires the generic scaler to kubectl
      
      **What this PR does / why we need it**:
      the changes introduced in this commit plumbs in the generic scaler to kubectl.
      note that we don't change the behaviour of kubectl.
      For example it won't scale new resources. That's the end goal.
      The first step is to retrofit existing code to use the generic scaler.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      52a2256b
    • Kubernetes Submit Queue's avatar
      Merge pull request #58208 from FengyunPan/fix-autoprobe-subnet · 2b764d7b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      The lbaas.opts.SubnetId should be set by subnet id.
      
      Fix #58145
      The getSubnetIDForLB() should return subnet id rather than net id.
      
      **Release note**:
      ```release-note
      NONE
      ```
      2b764d7b
    • Kubernetes Submit Queue's avatar
      Merge pull request #58061 from ravisantoshgudimetla/fix-57152 · 50e04f59
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Improved readability for messages being logged
      
      **What this PR does / why we need it**:
      This improves the readability for messages seen by end-user. /cc @jwforres @bsalamat - For UX
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #57152
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      50e04f59
    • Kubernetes Submit Queue's avatar
      Merge pull request #56713 from juanvallejo/jvallejo/handle-ds-pod-drain-local-storage · 4bc93609
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Allow kubectl drain to continue w ds-managed pods with local storage
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      Prevents oadm drain from failing if it encounters DaemonSet-managed pods
      that have local storage, when the option to ignore DaemonSet-managed
      pods has been specified.
      
      Will add a test
      
      cc @kubernetes/sig-cli-misc @deads2k @fabianofranz @dustymabe
      4bc93609
    • Kubernetes Submit Queue's avatar
      Merge pull request #58155 from zouyee/patch-12 · 782add0c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      remove providers which have been deleted
      
      **What this PR does / why we need it**:
      
      xref #49213
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```NONE
      
      ```
      782add0c
    • Kubernetes Submit Queue's avatar
      Merge pull request #57883 from hzxuzhonghu/crd-handler · 9b6ac17f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      refactor customeresource handler
      
      **What this PR does / why we need it**:
      
      - fix data race bug
      - fix lock usage bug.
      - remove some redundant code
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #57882
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      9b6ac17f
    • Kubernetes Submit Queue's avatar
      Merge pull request #56509 from lpabon/csi-e2e · 7dbb7094
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 57266, 58187, 58186, 46245, 56509). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      e2e: CSI Tests
      
      **What this PR does / why we need it**:
      This e2e test tests the CSI external attacher with a mock CSI plugin driver.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: https://github.com/kubernetes/features/issues/178
      
      **Special notes for your reviewer**:
      * Tests features in https://github.com/kubernetes/features/issues/178
      * Tests implementation of https://github.com/kubernetes/community/pull/1258
      * Tests VolumeAttachment Object: https://github.com/kubernetes/kubernetes/pull/54463
      
      **Release note**:
      ```release-note
      NONE
      ```
      7dbb7094
    • Kubernetes Submit Queue's avatar
      Merge pull request #46245 from ravisantoshgudimetla/metrics_additions · 98f81e36
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 57266, 58187, 58186, 46245, 56509). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Added metrics for predicate and priority evaluation 
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #45972
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      98f81e36
    • Kubernetes Submit Queue's avatar
      Merge pull request #58186 from negz/master · 15ef3a8b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 57266, 58187, 58186, 46245, 56509). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Avoid panic in Cloud CIDR Allocator
      
      **What this PR does / why we need it**:
      I suspect a race exists where we attempt to look up the CIDR for a terminating node. By the time `updateCIDRAllocation` is called the node has disappeared. We determine it does not have a cloud CIDR (i.e. Alias IP Range) and attempt to record a `CIDRNotAvailable` node status. Unfortunately we reference `node.Name` while `node` is still nil.
      
      By getting the node before looking up the cloud CIDR we avoid the nil pointer dereference, and potentially fail fast in the case the node has disappeared.
      
      **Which issue(s) this PR fixes**:
      Fixes #58181
      
      **Release note**:
      
      ```release-note
      Avoid panic when failing to allocate a Cloud CIDR (aka GCE Alias IP Range). 
      ```
      15ef3a8b
    • Kubernetes Submit Queue's avatar
      Merge pull request #58187 from caesarxuchao/fix-typo · 99abe92a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 57266, 58187, 58186, 46245, 56509). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      [minor] Fix a typo
      
      Fix https://github.com/kubernetes/kubernetes/pull/58025#discussion_r161052726
      99abe92a
    • ravisantoshgudimetla's avatar
      16ff0c2d
    • Kubernetes Submit Queue's avatar
      Merge pull request #57266 from vikaschoudhary16/unhealthy_device · f2e46a21
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Handle Unhealthy devices
      
      Update node capacity with sum of both healthy and unhealthy devices.
      Node allocatable reflect only healthy devices.
      
      
      
      **What this PR does / why we need it**:
      Currently node capacity only reflects healthy devices. Unhealthy devices are ignored totally while updating node status. This PR handles unhealthy devices while updating node status. 
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #57241
      
      **Special notes for your reviewer**:
      
      **Release note**:
      <!--  Write your release note:
      Handle Unhealthy devices
      
      ```release-note
      Handle Unhealthy devices
      ```
      /cc @tengqm @ConnorDoyle @jiayingz @vishh @jeremyeder @sjenning @resouer @ScorpioCPH @lichuqiang @RenaudWasTaken @balajismaniam 
      
      /sig node
      f2e46a21
    • Kubernetes Submit Queue's avatar
      Merge pull request #58113 from bowei/cloud · 75e50a37
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add `cloud` for the generated GCE interfaces, support structs
      
      Note: this does not wire the generated code.
      
      ```release-note
      NONE
      ```
      75e50a37
    • Kubernetes Submit Queue's avatar
      Merge pull request #56994 from zouyee/patch-14 · 416a38e5
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Comment typo fix in StatefulSet controller
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```
      NONE
      ```
      416a38e5
    • Kubernetes Submit Queue's avatar
      Merge pull request #58089 from mtanino/issue/58085 · b5eb9149
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      [FC Plugin] Create proper volumeSpec during ConstructVolumeSpec
      
      **What this PR does / why we need it**:
      
      Currently, FC plugin returns volume name and empty FCVolumeSource during ConstrutVolumeSpec of filesystem volume's reconstruction.
      
      In this fix, ConstructVolumeSpec retrieves global mount path, and analyzes volume parameters such as
      WWN, LUN, WWID from the path.
      
      **Which issue(s) this PR fixes** :
      Fixes #58085
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      cc @rootfs @jsafrane 
      /sig storage
      b5eb9149
  2. 12 Jan, 2018 19 commits