• Kubernetes Submit Queue's avatar
    Merge pull request #35348 from Random-Liu/kuberuntime-container-logs · 479ff417
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    CRI: Add kuberuntime container logs
    
    Based on https://github.com/kubernetes/kubernetes/pull/34858.
    
    The first 2 commits are from #34858. And the last 2 commits are new.
    
    This PR added kuberuntime container logs support and add unit test for it.
    
    I've tested all the functions manually, and I'll send another PR to write a node e2e test for container log.
    
    **_Notice: current implementation doesn't support log rotation**_, which means that:
    - It will not retrieve logs in rotated log file.
    - If log rotation happens when following the log:
      - If the rotation is using create mode, we'll still follow the old file.
      - If the rotation is using copytruncate, we'll be reading at the original position and get nothing.
    
    To solve these issues, kubelet needs to rotate the log itself, or at least kubelet should be able to control the the behavior of log rotator. These are doable but out of the scope of 1.5 and will be addressed in future release.
    
    @yujuhong @feiskyer @yifan-gu 
    /cc @kubernetes/sig-node
    479ff417
Name
Last commit
Last update
..
admission Loading commit data...
api Loading commit data...
apimachinery Loading commit data...
apis Loading commit data...
apiserver Loading commit data...
auth Loading commit data...
capabilities Loading commit data...
client Loading commit data...
cloudprovider Loading commit data...
controller Loading commit data...
conversion Loading commit data...
credentialprovider Loading commit data...
dns Loading commit data...
fieldpath Loading commit data...
fields Loading commit data...
generated Loading commit data...
genericapiserver Loading commit data...
healthz Loading commit data...
httplog Loading commit data...
hyperkube Loading commit data...
kubectl Loading commit data...
kubelet Loading commit data...
kubemark Loading commit data...
labels Loading commit data...
master Loading commit data...
metrics Loading commit data...
probe Loading commit data...
proxy Loading commit data...
quota Loading commit data...
registry Loading commit data...
routes Loading commit data...
runtime Loading commit data...
security Loading commit data...
securitycontext Loading commit data...
selection Loading commit data...
serviceaccount Loading commit data...
ssh Loading commit data...
storage Loading commit data...
types Loading commit data...
util Loading commit data...
version Loading commit data...
volume Loading commit data...
watch Loading commit data...
OWNERS Loading commit data...