• Kubernetes Submit Queue's avatar
    Merge pull request #35348 from Random-Liu/kuberuntime-container-logs · 479ff417
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    CRI: Add kuberuntime container logs
    
    Based on https://github.com/kubernetes/kubernetes/pull/34858.
    
    The first 2 commits are from #34858. And the last 2 commits are new.
    
    This PR added kuberuntime container logs support and add unit test for it.
    
    I've tested all the functions manually, and I'll send another PR to write a node e2e test for container log.
    
    **_Notice: current implementation doesn't support log rotation**_, which means that:
    - It will not retrieve logs in rotated log file.
    - If log rotation happens when following the log:
      - If the rotation is using create mode, we'll still follow the old file.
      - If the rotation is using copytruncate, we'll be reading at the original position and get nothing.
    
    To solve these issues, kubelet needs to rotate the log itself, or at least kubelet should be able to control the the behavior of log rotator. These are doable but out of the scope of 1.5 and will be addressed in future release.
    
    @yujuhong @feiskyer @yifan-gu 
    /cc @kubernetes/sig-node
    479ff417
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build-tools Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
contrib Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
hooks Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
vendor Loading commit data...
www Loading commit data...
.generated_docs Loading commit data...
.gitignore Loading commit data...
BUILD Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIB.md Loading commit data...
CONTRIBUTING.md Loading commit data...
DESIGN.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
README.md Loading commit data...
Vagrantfile Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...