- 19 Jul, 2017 5 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232) Move GPU e2e tests under owning SIG. Supercedes #48723 **Release note**: ```release-note NONE ``` /sig scheduling /assign @vishh @fejta @grodrigues3
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232) Rackspace for cloud-controller-manager This implements the NodeAddressesByProviderID and InstanceTypeByProviderID methods used by the cloud-controller-manager to the RackSpace provider. The instance type returned is the flavor name, for consistency InstanceType has been implemented too returning the same value. This is part of #47257 cc @wlan0 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add approvers to owners file for hpa Currently none of hpa developers or people in sig-autoscaling has the right to approve PRs to hpa, meaning it needs to be approved at pkg/controller level by people not working on autoscaling.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48481, 48256) Refactor: pkg/util into sub-pkgs **What this PR does / why we need it**: - move code in pkg/util into sub-pkgs - delete some unused funcs **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #15634 **Special notes for your reviewer**: This is the final work of #15634. It will close that issue. /cc @thockin **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48481, 48256) Protect against nil panic in apply **What this PR does / why we need it**: `kubectl apply` has a potential panic (actually verified in OpenShift in https://github.com/openshift/origin/issues/15017) where a `patcher` calls the `runDelete` function with a nil `resource.RESTClient`, but under some conditions the client is required by that function. **Release note**: ```release-note NONE ``` @pwittrock @kubernetes/sig-cli-bugs
-
- 18 Jul, 2017 35 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46094, 48544, 48807, 49102, 44174) Allow user to pass various gluster volume options when glusterfs volumes are dynamically provisioned. This patch add new storage class parameter called `volumeoptions` which can be used to set various volume options. for eg# if you want to enable encryption on volumes, the values like `client.ssl on`, `server.ssl on`..etc can be passed to `volumeoptions` parameter in storageclass. Issue # https://github.com/kubernetes/kubernetes/issues/28454Signed-off-by:Humble Chirammal <hchiramm@redhat.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46094, 48544, 48807, 49102, 44174) add InstanceID to fake cadvisor (used in Kubemark) This change is for setting Node.Spec.ProviderID field in Kubemark hollow nodes. It shouldn't affect other tests using cadvisor.Fake as field is nil by default. cc @gmarek
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46094, 48544, 48807, 49102, 44174) Implement kubectl describe <fibre-channel PV> kubectl did not show any details about Fibre Channel volumes, someone just forgot to implement it. Tested with: ```shell $ kubectl create -f - <<EOF apiVersion: v1 kind: PersistentVolume metadata: name: myfc spec: capacity: storage: 100Gi accessModes: - ReadWriteOnce persistentVolumeReclaimPolicy: Delete fc: targetWWNs: ['500a0982991b8dc5', '500a0982891b8dc5'] lun: 2 fsType: ext4 readOnly: true EOF $ kubectl describe pv myfc Name: myfc Labels: <none> Annotations: <none> StorageClass: Status: Available Claim: Reclaim Policy: Delete Access Modes: RWO Capacity: 100Gi Message: Source: Type: FC (a Fibre Channel disk) TargetWWNs: 500a0982991b8dc5, 500a0982891b8dc5 LUN: 2 FSType: ext4 ReadOnly: true Events: <none> ``` ```release-note NONE ``` @kubernetes/sig-cli-pr-reviews -
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46094, 48544, 48807, 49102, 44174) Static deepcopy – phase 1 This PR is the follow-up of https://github.com/kubernetes/kubernetes/pull/36412, replacing the dynamic reflection based deepcopy with static DeepCopy+DeepCopyInto methods on API types. This PR **does not yet** include the code dropping the cloner from the scheme and all the porting of the calls to scheme.Copy. This will be part of a follow-up "Phase 2" PR. A couple of the commits will go in first: - [x] audit: fix deepcopy registration https://github.com/kubernetes/kubernetes/pull/48599 - [x] apimachinery+apiserver: separate test types in their own packages #48601 - [x] client-go: remove TPR example #48604 - [x] apimachinery: remove unneeded GetObjectKind() impls #48608 - [x] sanity check against origin, that OpenShift's types are fine for static deepcopy https://github.com/deads2k/origin/pull/34 TODO **after** review here: - [x] merge https://github.com/kubernetes/gengo/pull/32 and update vendoring commit
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46094, 48544, 48807, 49102, 44174) Shared Informer Run blocks until all goroutines finish **What this PR does / why we need it**: Makes Shared Informer Run method block until all goroutines it spawned finish. See #45454. **Which issue this PR fixes** Fixes #45454 **Release note**: ```release-note NONE ```
-
Rohit Agarwal authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue amend the comment **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```NONE
-
Fabiano Franz authored
-
Humble Chirammal authored
`volumeoptions` which can be used to set various volume options. for eg# if you want to enable encryption on volumes, the values like `client.ssl on`, `server.ssl on`..etc can be passed to `volumeoptions` parameter in storageclass. Issue # https://github.com/kubernetes/kubernetes/issues/28454Signed-off-by:
Humble Chirammal <hchiramm@redhat.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48333, 48806, 49046) kubeadm: Split out markmaster to its own phase **What this PR does / why we need it**: Splits out related and atomic code into its own phase that can be invokable easily from the CLI. Makes the code much easier to read by not using recursion and `wait.InfinitePoll` _inside_ of a recursing function, etc. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Fixes: https://github.com/kubernetes/kubeadm/issues/53 Part of this more long-term goal: https://github.com/kubernetes/kubeadm/issues/148 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` @kubernetes/sig-cluster-lifecycle-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48333, 48806, 49046) kubeadm: Generate kube-proxy image name in its own pkg **What this PR does / why we need it**: code cleanup. Control kube-proxy image parameter in DaemonSet template. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: Minor cleanup. Attn @luxas **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48333, 48806, 49046) use v1.ResourcePods instead of hard coding "pods" Signed-off-by:sakeven <jc5930@sina.cn> **What this PR does / why we need it**: use v1.ResourcePods instead of hard coding 'pods' **Special notes for your reviewer**: **Release note**: ``` NONE ```
-
Maciej Pytel authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update autoscaling tests OWNERS Add current members of autoscaling team to autoscaling tests OWNERS
-
Aleksandra Malinowska authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48983, 49013) Reduce SD Logging soak test duration & fix problem with multiple nodes Fixes https://github.com/kubernetes/kubernetes/issues/49012 /cc @piosz
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48983, 49013) Added comments on not set node network/inode condition to unknown. **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48982 **Release note**: ```release-note None ```
-
Alexander Kanevskiy authored
Maintain kube-proxy DaemonSet definition in one place
-
Lucas Käldström authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48576, 49010) adding validations on kube-apiserver audit log options **What this PR does / why we need it**: The kube-apiserver does not check the validity of the following audit log options `--audit-log-maxage`, `--audit-log-maxage`, `--audit-log-maxage`. If these options are set to negative numbers, the kube-apiserver will not detect these invalid settings. This PR adds validations on these audit log options. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: `NONE`
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48576, 49010) make externalAdmissionHookConfigurationManager distinguish API disabled error The externalAdmissionHookConfigurationManager does not return "DisabledErr" even if the API is disabled, so the GenericWebhook admission controller will not fail open. The GenericWebhook admission controller is default to off, so the bug is hidden in most cases. To be safe, we should cherrypick it to 1.7. ```release-note Fix a bug where the GenericWebhook admission plugin does not fail open when the admissionregistration API is disabled ```
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
- port direct calls to deepcopy funcs - apimachinery: fix types in unstructured converter test - federation: fix deepcopy registration
-
Dr. Stefan Schimanski authored
- add DeepCopyObject() to runtime.Object interface - add DeepCopyObject() via deepcopy-gen - add DeepCopyObject() manually - add DeepCopySelector() to selector interfaces - add custom DeepCopy func for TableRow.Cells
-
xiangpengzhao authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue [Scheduler] Remove error since err is always nil Signed-off-by:sakeven <jc5930@sina.cn> **What this PR does / why we need it**: No need to log error since err is always nil. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ``` NONE ```
-
Dr. Stefan Schimanski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49043, 49001, 49057, 49066, 48102) Make doc generation on cherry-picks optional Follow up of https://github.com/kubernetes/kubernetes/pull/46993, xref #44533 Most cherry-picks don't require doc changes, and doing it unconditionally actually breaks picking to the release-1.6 branch
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49043, 49001, 49057, 49066, 48102) Always use gcr.io/google_containers for side-loaded Docker images **What this PR does / why we need it**: #45391 changed the behavior for what registry we use in the sideloaded docker images tarfiles shipped with releases. As a result of that change, if `KUBE_DOCKER_REGISTRY` is set to anything other than `gcr.io/google_containers`, clusters will fail to start on GCE (and other places where the side-loaded images are used). This PR reverts that change in behavior, which I believe was unintentional; we'll always use `gcr.io/google_containers` for the docker image tarfiles, but will tag the images with `$KUBE_DOCKER_REGISTRY` if different. Also, I'm fixing a small bug in variable names that I introduced in #47939. Note that with recent changes here and in the release repo, we don't even need to tag with `KUBE_DOCKER_REGISTRY` and `KUBE_DOCKER_IMAGE_TAG`, but that's a more extensive change, and this smaller fix is more suitable for cherry-picking to 1.7. **Release note**: ```release-note NONE ``` /release-note-none /sig release /assign @david-mcmahon
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49043, 49001, 49057, 49066, 48102) bootstrap token auth: don't accept deleted tokens Closes #48345 Same fix as #48343 ```release-note Previously a deleted bootstrapping token secret would be considered valid until it was reaped. Now it is invalid as soon as the deletionTimestamp is set. ``` cc @luxas @kubernetes/sig-auth-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49043, 49001, 49057, 49066, 48102) Explicitly set --cluster-ip-range --clean-start --minStartupPods ref https://github.com/kubernetes/test-infra/pull/3535 https://github.com/kubernetes/test-infra/pull/3375 Also remove unused `GINKGO_PARALLELISM` /assign @krzyzacy @ixdy
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49043, 49001, 49057, 49066, 48102) cluster/gke: If NODE_INSTANCE_GROUP is set, don't execute any bash Transitional part of kubernetes/test-infra#3307, should be eliminated by kubernetes/test-infra#3330: Allow NODE_INSTANCE_GROUP to be set externally from `hack/ginkgo-e2e.sh`, which eliminates any cluster/gke use if KUBERNETES_CONFORMANCE_PROVIDER is set to `gke`. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49019, 48919, 49040, 49018, 48874) Set default snap channel on charms to 1.7 stable **What this PR does / why we need it**: This PR sets the default snap channel on charms to 1.7/stable. This addresses problems where the the user might want to deploy the charm and get the same kubernetes version found on the bundles. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/305 **Special notes for your reviewer**: **Release note**: ```Set default snap channel on charms to 1.7/stable ```
-