1. 30 Jun, 2017 1 commit
  2. 29 Jun, 2017 10 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #47729 from paultyng/pt/useragent · 343d751b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47286, 47729)
      
      Set default User-Agent on http probe
      
      **Set a default User-Agent on `httpGet` probes**:
      
      Currently the default Go HTTP client sets a `User-Agent` specific to the language and version, but every Go client has the same one.  In Kubernetes, users can override the User-Agent by setting a header in their probe definition, but its tedious to do this everywhere.
      
      This PR changes the default User-Agent only if not set (or removed) in the probe definition.
      
      **Which issue this PR fixes** 
      fixes #29025
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Change default `httpGet` probe `User-Agent` to `kube-probe/<version major.minor>` if none specified, overriding the default Go `User-Agent`.
      ```
      343d751b
    • Kubernetes Submit Queue's avatar
      Merge pull request #47286 from cosmincojocar/client_cert_azure_cloud_provider · db46e4f8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47286, 47729)
      
      Add client certificate authentication to Azure cloud provider
      
      This adds support for client cert authentication in Azure cloud provider. The certificate can be provided in PKCS #12 format with password protection. Not that this authentication will be active only when no client secret is configured.
      
      cc @brendandburns @colemickens
      db46e4f8
    • Kubernetes Submit Queue's avatar
      Merge pull request #48172 from gyliu513/const · 06fcfe23
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48137, 48172)
      
      Used const variable in scheduler test.
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      none
      ```
      06fcfe23
    • Kubernetes Submit Queue's avatar
      Merge pull request #48137 from danwinship/utiltests · 3b356964
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fixes to two pkg/util unit tests
      
      Spun out from #46537. Trivial unit test fixes:
      - `pkg/util/ebtables/ebtables_test.go`'s tests are incorrectly named and so weren't getting run by "go test". (And one of them had a typo in it so it failed after the name was fixed)
      - In `pkg/util/iptables/iptables_test.go`, the deletion tests were apparently written by copying+pasting+editing the creation tests, but they forgot to change the names of the tests to match the behavior that was being tested in the new version
      3b356964
    • Guangya Liu's avatar
      Used const variable in scheduler test. · e0d02f14
      Guangya Liu authored
      e0d02f14
    • Dawn Chen's avatar
      Merge pull request #48235 from xiangpengzhao/fix-get-capacity · 8bece8ec
      Dawn Chen authored
      Implement GetCapacity in container_manager_unsupported
      8bece8ec
    • xiangpengzhao's avatar
      53c536b5
    • Kubernetes Submit Queue's avatar
      Merge pull request #47827 from yiqinguo/yiqinguo_repeat_type_coversions · b6972221
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Remove repeat type conversions
      
      Here is the type of conversion for the variable is repeated.
      
      **Release note**:
      ```release-note
      NONE
      ```
      b6972221
    • Kubernetes Submit Queue's avatar
      Merge pull request #48154 from krousey/upgrades · b353792f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48214, 48154)
      
      Adding a retry and traceroute to the master version checking
      
      This is hitting a lot of connection refused errors in the e2e upgrade tests. We should make this more robust in case this is intermittent network errors. In the event of an error, attempt to log a traceroute to the master.
      
      cc @kubernetes/sig-cluster-lifecycle-bugs @dchen1107 
      
      #47379
      b353792f
    • Kubernetes Submit Queue's avatar
      Merge pull request #48214 from shyamjvs/heapster-node-in-gce · bcb44655
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48214, 48154)
      
      Allow creating special node for running heapster in GCE
      
      This should enable scheduling heapster pod(s) in our large cluster tests, where the minions are very small (n1-standard-1) and heapster can't schedule on them due to high memory requests.
      We need this for running heapster dependent correctness tests in 5k-node cluster.
      
      cc @kubernetes/sig-scalability-misc @kubernetes/heapster-maintainers @gmarek
      bcb44655
  3. 28 Jun, 2017 29 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #47014 from boingram/deletePod-handler-shouldnt-set-owner-refs · 37c9367a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      deletePod handler in the deployment controller shouldn't set owner refs
      
      **What this PR does / why we need it**:
      This PR stops the deletePod handler in the deployment controller from adopting replica sets when determining if a deployment needs to be requeued. It leaves this logic to the replication loop, removing the replica set adoption side effect.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #46933 
      
      **Special notes for your reviewer**:
      @kargakis PR for delete pod handler setting owner refs issue
      
      **Release note**:
      
      ```release-note
      ```
      37c9367a
    • Kubernetes Submit Queue's avatar
      Merge pull request #48065 from ironcladlou/unstructured-field-fix · d0735b90
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48183, 45611, 48065)
      
      Fix Unstructured field accessor
      
      Fix the Unstructured GetDeletionGracePeriodSeconds accessor which was
      always returning nil regardless of the underlying stored value. The
      field value always appearing nil prevents Custom Resource instances
      from being deleted when garbage collection is enabled for CRs and
      when DeletePropagationOrphan is used. More generally, this fix means that
      delete-on-update now works for CR instances.
      
      Add some test coverage for Unstructured metadata deserialization.
      
      The Unstructured DeletionGracePeriodSeconds field marshals as a value
      type from JSON and as a pointer type via SetDeletionGracePeriodSeconds.
      The GetDeletionGracePeriodSeconds method now supports handling both
      int64 and *int64 values so that either underlying value can be returned.
      
      Add a reflection-based unit test which attempts to exercise all the
      Object Get/Set methods for nil handling.
      
      ```release-note
      Registries backed by the generic Store's `Update` implementation support delete-on-update, which allows resources to be automatically deleted during an update provided:
      
      * Garbage collection is enabled for the Store
      * The resource being updated has no finalizers
      * The resource being updated has a non-nil DeletionGracePeriodSeconds equal to 0
      
      With this fix, Custom Resource instances now also support delete-on-update behavior under the same circumstances.
      ```
      d0735b90
    • Kubernetes Submit Queue's avatar
      Merge pull request #45611 from atombender/issue-45608 · 7c656ab4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48183, 45611, 48065)
      
      kubectl: 'apply view-last-applied' must not use printf() semantics
      
      **What this PR does / why we need it**:
      This fixes `kubectl apply view-last-applied` to not use `fmt.Fprintf()`, as this will cause format codes in the YAML/JSON to be interpreted. For example, if a resource manifest contains `%r`, this would cause `view-last-applied` so print `%!r(MISSING)`.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #45608.
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Fixes an edge case where "kubectl apply view-last-applied" would emit garbage if the data contained Go format codes.
      ```
      7c656ab4
    • Kubernetes Submit Queue's avatar
      Merge pull request #48183 from xiangpengzhao/fix-proxy-panic · 40f7b595
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix kube-proxy panic when running with "--cleanup-iptables=true"
      
      **What this PR does / why we need it**:
      Save the `--cleanup-iptables` config for new ProxyServer when it's true.
      Also check if Broadcaster and EventClient are nil to avoid other potential panic.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48177
      
      **Special notes for your reviewer**:
      /cc @ncdc @irake99
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      40f7b595
    • Shyam Jeedigunta's avatar
      cc8bb857
    • Kris's avatar
      Add traceroute logging on connection failure · faf7dff7
      Kris authored
      faf7dff7
    • Kubernetes Submit Queue's avatar
      Merge pull request #48199 from MaciekPytel/fix_autoscaler_e2e_on_gke · 40f33a4b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48168, 48199)
      
      Fix some flakes in autoscaler e2e on gke
      
      This PR should fix some of the flakes we found in e2e runs, while testing for 1.7 release:
       - if one of the nodes is unschedulable in set up (causing set up to fail) we used to wait for wrong number of nodes in clean-up, adding unnecessary 20 minute wait to failing test
       - we did not check for errors when creating RC in test, leading to tests failing later in hard to debug way (added retry loop and explicit test failure)
      40f33a4b
    • Kubernetes Submit Queue's avatar
      Merge pull request #48168 from abgworrall/abw-image-version-metadata · 4c1667e3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48168, 48199)
      
      Log the OS images used during GCP cluster creation
      
      /assign @fejta
      4c1667e3
    • Dan Mace's avatar
      Fix Unstructured field accessor · 547d8205
      Dan Mace authored
      Fix the Unstructured GetDeletionGracePeriodSeconds accessor which was
      always returning nil regardless of the underlying stored value. The
      field value always appearing nil prevents Custom Resource instances
      from being deleted when garbage collection is enabled for CRs and
      when DeletePropagationOrphan is used. More generally, this fix means that
      delete-on-update now works for CR instances.
      
      Add some test coverage for Unstructured metadata deserialization.
      
      The Unstructured DeletionGracePeriodSeconds field marshals as a value
      type from JSON and as a pointer type via SetDeletionGracePeriodSeconds.
      The GetDeletionGracePeriodSeconds method now supports handling both
      int64 and *int64 values so that either underlying value can be returned.
      
      Add a reflection-based unit test which attempts to exercise all the
      Object Get/Set methods for nil handling.
      547d8205
    • Kubernetes Submit Queue's avatar
      Merge pull request #48207 from gmarek/density_clients · 5731e0d6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48004, 48205, 48130, 48207)
      
      Use multiple clients in the density test
      
      Fix #47954
      5731e0d6
    • Kubernetes Submit Queue's avatar
      Merge pull request #48130 from aleksandra-malinowska/autoscaling-volumes-scale-up-test · 39fa1cb2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48004, 48205, 48130, 48207)
      
      Add e2e tests for CA scale up when pending pod requests volume
      
      Test verifying pending pods with PVC don't interfere with scale up, issue: kubernetes/autoscaler#22
      39fa1cb2
    • Kubernetes Submit Queue's avatar
      Merge pull request #48205 from piosz/heapster-1.4 · a17f15a8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48004, 48205, 48130, 48207)
      
      Bumped Heapster to v1.4.0
      
      ``` release-note
      Bumped Heapster to v1.4.0.
      More details about the release https://github.com/kubernetes/heapster/releases/tag/v1.4.0
      ```
      
      follow up #47961
      The release candidate `v1.4.0-beta.0` turned out to be stable.
      a17f15a8
    • Kubernetes Submit Queue's avatar
      Merge pull request #48004 from dnardo/gke · 63d4af44
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48004, 48205, 48130, 48207)
      
      Do not set CNI in cases where there is a private master and network policy provider is set.
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      In GCE and in a "private master" setup, do not set the network-plugin provider to CNI by default if a network policy provider is given.
      ```
      63d4af44
    • Adam Worrall's avatar
      439cb3e7
    • Kubernetes Submit Queue's avatar
      Merge pull request #48182 from gmarek/fluentd · ec729ad6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48192, 48182)
      
      Add generic NoSchedule toleration to fluentd in gcp config as a quick…
      
      …-fix for #44445
      ec729ad6
    • Maciej Pytel's avatar
      Add retry to RC creation in autoscaler e2e · 37c2cfe9
      Maciej Pytel authored
      37c2cfe9
    • gmarek's avatar
      Use multiple clients in the density test · b18fd60b
      gmarek authored
      b18fd60b
    • MaciekPytel's avatar
      Merge pull request #48192 from gmarek/fix_subnet · 2d6e674a
      MaciekPytel authored
      Fix bug cluster-subnet logic
      2d6e674a
    • Piotr Szczesniak's avatar
      Bumped Heapster to v1.4.0 · 43280e27
      Piotr Szczesniak authored
      43280e27
    • Kubernetes Submit Queue's avatar
      Merge pull request #47346 from luxas/kubeadm_fix_tolerations · 38fa6205
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      kubeadm: Start using Tolerations in yaml code again and unit-test
      
      **What this PR does / why we need it**:
      
      - Earlier there was a problem with decoding Tolerations from yaml. Seems to be fixed now.
      - Added an unit test to catch such a failure if that regression ever happens again
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      Targets v1.8
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      @kubernetes/sig-cluster-lifecycle-pr-reviews @timothysc
      38fa6205
    • gmarek's avatar
      Fix bug cluster-subnet logic · 10ce8e2c
      gmarek authored
      10ce8e2c
    • Lucas Käldström's avatar
      7baff10b
    • Kubernetes Submit Queue's avatar
      Merge pull request #48050 from luxas/fix_rbac_configmaps · 60895578
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      kubeadm: Expose only the cluster-info ConfigMap in the kube-public ns
      
      **What this PR does / why we need it**:
      
      Noticed a bug; we should only expose the `cluster-info` ConfigMap.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      Fixes: https://github.com/kubernetes/kubeadm/issues/320
      
      **Special notes for your reviewer**:
      
      Cherrypick-candidate for v1.8 cc @dchen1107 
      Not blocking the release though...
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      @jbeda @pipejakob @timothysc @kubernetes/sig-cluster-lifecycle-pr-reviews
      60895578
    • Maciej Pytel's avatar
      Fix minor bug in autoscaler e2e cleanup · e2633865
      Maciej Pytel authored
      e2633865
    • Kubernetes Submit Queue's avatar
      Merge pull request #48079 from alexandercampbell/kubectl-many-small-refactors · 18e8bedb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48123, 48079)
      
      kubectl/cmd: many small refactors
      
      #### Improve Code Quality in `pkg/kubectl/cmd`
      
      ___
      
       * [x] Rename variables and functions to match Go convention. For example, UsageError --> UsageErrorf.
       * [x] Remove redundant or unreachable code.
       * [x] Simplify some utility functions (no functionality changes).
       * [x] Fix hanging 'if { return } else { return }' constructs.
       * [x] Fix several incorrect printf verbs.
      
      These changes were extracted from the refactoring and flag parity work I'm doing in kubectl.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      18e8bedb
    • Kubernetes Submit Queue's avatar
      Merge pull request #48123 from msau42/fix-allocatable-race · 13a7fdc8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48123, 48079)
      
      [Kubelet] Fix race condition in container manager
      
      **What this PR does / why we need it**:
      
      This fixes a race condition where the container manager capacity map was being updated without synchronization.  It moves the storage capacity detection to kubelet initialization, which happens serially in one thread.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48045
      
      **Release note**:
      
      ```release-note
      Fixes kubelet race condition in container manager.
      ```
      13a7fdc8
    • Aleksandra Malinowska's avatar
      add volumes test · ea1bf386
      Aleksandra Malinowska authored
      ea1bf386
    • xiangpengzhao's avatar
    • gmarek's avatar