Merge pull request #45611 from atombender/issue-45608

Automatic merge from submit-queue (batch tested with PRs 48183, 45611, 48065) kubectl: 'apply view-last-applied' must not use printf() semantics **What this PR does / why we need it**: This fixes `kubectl apply view-last-applied` to not use `fmt.Fprintf()`, as this will cause format codes in the YAML/JSON to be interpreted. For example, if a resource manifest contains `%r`, this would cause `view-last-applied` so print `%!r(MISSING)`. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #45608. **Special notes for your reviewer**: **Release note**: ```release-note Fixes an edge case where "kubectl apply view-last-applied" would emit garbage if the data contained Go format codes. ```

Merge pull request #45611 from atombender/issue-45608
7c656ab4 · Kubernetes Submit Queue · GitHub · 40f7b595 · 4f8cbc15 · 7c656ab4
Commit 7c656ab4 authored Jun 28, 2017 by Kubernetes Submit Queue Committed by GitHub Jun 28, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

apply_view_last_applied.go pkg/kubectl/cmd/apply_view_last_applied.go +2 -2

No files found.
--- a/pkg/kubectl/cmd/apply_view_last_applied.go
+++ b/pkg/kubectl/cmd/apply_view_last_applied.go
@@ -142,13 +142,13 @@ func (o *ViewLastAppliedOptions) RunApplyViewLastApplied() error {
 			if err != nil {
 				return err
 			}
-			fmt.Fprintf(o.Out, string(jsonBuffer.Bytes()))
+			fmt.Fprint(o.Out, string(jsonBuffer.Bytes()))
 		case "yaml":
 			yamlOutput, err := yaml.JSONToYAML([]byte(str))
 			if err != nil {
 				return err
 			}
-			fmt.Fprintf(o.Out, string(yamlOutput))
+			fmt.Fprint(o.Out, string(yamlOutput))
 		}
 	}