- 30 Jan, 2018 3 commits
-
-
zhangxiaoyu-zidif authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58899, 58980). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix setting qps in density test. Current QPS setting code doesn't work. All the density tests with higher QPS are failing. https://k8s-testgrid.appspot.com/sig-node-kubelet#kubelet-benchmark-gce-e2e We should use existing helper function `tempSetCurrentKubeletConfig` to set QPS. @kubernetes/sig-node-bugs @mtaufen **Release note**: ```release-note none ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58899, 58980). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. CRI: Add a call to reopen log file for a container This allows a daemon external to the container runtime to rotate the log file, and then ask the runtime to reopen the files. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #58823 **Release note**: ```release-note CRI: Add a call to reopen log file for a container. ```
-
- 29 Jan, 2018 35 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58777, 58978, 58977, 58775). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix url parsing for staging/dev endpoint ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58777, 58978, 58977, 58775). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix pod sandbox privilege. Fixes https://github.com/kubernetes/kubernetes/issues/58979. In cri-containerd, we start enforcing that a privileged container can't be created in privileged sandbox in https://github.com/containerd/cri-containerd/pull/577. However, after that the e2e-gci-device-plugin-gpu test starts failing. https://k8s-testgrid.appspot.com/sig-node-containerd#e2e-gci-device-plugin-gpu ``` I0128 06:49:09.117] Jan 28 06:49:09.086: INFO: At 2018-01-28 06:41:10 +0000 UTC - event for nvidia-driver-installer-5kkrz: {kubelet bootstrap-e2e-minion-group-7s2v} Failed: (combined from similar events): Error: failed to generate container "cfb9f4f01fc2685db6469d3f6348077b94d4aa577e2e6345bf890f8871ec80dd" spec: no privileged container allowed in sandbox ``` The reason is that kubelet doesn't check init container when setting sandbox privilege. Signed-off-by:
Lantao Liu <lantaol@google.com> **Release note**: ```release-note none. ``` @kubernetes/sig-node-bugs @yujuhong @feiskyer @mrunalp
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58777, 58978, 58977, 58775). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Removal of KubeletConfigFile feature gate: Step 3 (final) This PR completes the work started in https://github.com/kubernetes/kubernetes/pull/58760 by completely removing the KubeletConfigFile feature gate. We stopped setting the gate in test-infra in https://github.com/kubernetes/test-infra/pull/6490. ```release-note The alpha KubeletConfigFile feature gate has been removed, because it was redundant with the Kubelet's --config flag. It is no longer necessary to set this gate to use the flag. The --config flag is still considered alpha. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58777, 58978, 58977, 58775). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Skip NoNewPrivileges test when SELinux is enabled **What this PR does / why we need it**: A bug in the SELinux policy prevented NoNewPrivileges from working on Docker with SELinux support enabled. The problem has been fixed upstream (see projectatomic/container-selinux#45) But hasn't been backported yet (a fix might come in RHEL 7.5) For now, let's skip the NoNewPrivileges test when SELinux support is enabled in Docker. Tested: - Before this commit, the test fails: ``` $ make test-e2e-node REMOTE=true FOCUS="allow privilege escalation" (on a host with SELinux enabled) • [SLOW TEST:22.798 seconds] (passed) [k8s.io] Security Context when creating containers with AllowPrivilegeEscalation should allow privilege escalation when true • Failure [16.539 seconds] [k8s.io] Security Context when creating containers with AllowPrivilegeEscalation should not allow privilege escalation when false [It] wait for pod "alpine-nnp-false-aef03e47-0090-11e8-886f-42010af00009" to success Expected success, but got an error: <*errors.errorString | 0xc4204e26d0>: { s: "pod \"alpine-nnp-false-aef03e47-0090-11e8-886f-42010af00009\" failed with reason: \"\", message: \"\"", } pod "alpine-nnp-false-aef03e47-0090-11e8-886f-42010af00009" failed with reason: "", message: "" • [SLOW TEST:26.572 seconds] (passed) [k8s.io] Security Context when creating containers with AllowPrivilegeEscalation should allow privilege escalation when not explicitly set and uid != 0 Ran 3 of 257 Specs in 45.364 seconds FAIL! -- 2 Passed | 1 Failed | 0 Pending | 254 Skipped Ginkgo ran 1 suite in 49.389123442s Test Suite Failed ``` - After this commit, the test is skipped: ``` $ make test-e2e-node REMOTE=true FOCUS="allow privilege escalation" (on a host with SELinux enabled) S [SKIPPING] in Spec Setup (BeforeEach) [12.452 seconds] S [SKIPPING] in Spec Setup (BeforeEach) [16.298 seconds] S [SKIPPING] in Spec Setup (BeforeEach) [18.183 seconds] Ran 0 of 257 Specs in 39.174 seconds SUCCESS! -- 0 Passed | 0 Failed | 0 Pending | 257 Skipped Ginkgo ran 1 suite in 43.570630357s Test Suite Passed ``` - No changes when SELinux is disabled: ``` $ make test-e2e-node REMOTE=true FOCUS="allow privilege escalation" (on a host with SELinux disabled) • [SLOW TEST:15.013 seconds] [k8s.io] Security Context when creating containers with AllowPrivilegeEscalation should not allow privilege escalation when false • [SLOW TEST:19.155 seconds] [k8s.io] Security Context when creating containers with AllowPrivilegeEscalation should allow privilege escalation when true • [SLOW TEST:21.087 seconds] [k8s.io] Security Context when creating containers with AllowPrivilegeEscalation should allow privilege escalation when not explicitly set and uid != 0 Ran 3 of 259 Specs in 38.560 seconds SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 256 Skipped Ginkgo ran 1 suite in 41.937918928s Test Suite Passed ``` **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: N/A **Special notes for your reviewer**: N/A **Release note**: ```release-note NONE ```
-
Yu-Ju Hong authored
This allows a daemon external to the container runtime to rotate the log file, and then ask the runtime to reopen the files.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58955, 58968, 58971, 58963, 58298). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. removes the remainder from ScalerFor method **What this PR does / why we need it**: this PR removes existing scalers from `ScalerFor` method **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58955, 58968, 58971, 58963, 58298). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove dead testing code Removes a deprecated etcd server init function and stops starting an etc server during unit tests that we never use.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58955, 58968, 58971, 58963, 58298). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove dead prefix field The `Prefix` field was never used.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58955, 58968, 58971, 58963, 58298). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove --tls-ca-file which had no effect The flag has had no effect since we started configuring loopback based on the direct cert. I've marked it deprecated this release so we don't break launch scripts right away, but its coming. I think we should remove it in 1.11. ```release-note-action-required kube-apiserver flag --tls-ca-file has had no effect for some time. It is now deprecated and slated for removal in 1.11. If you are specifying this flag, you must remove it from your launch config before ugprading to 1.11. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58955, 58968, 58971, 58963, 58298). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. pkg: kubelet: do not assume anything about images names This patch fixes a regression introduced by https://github.com/kubernetes/kubernetes/pull/51751 in the CRI interface. That commit actually changed a unit test where we were previously *not* assuming anything about an image name. Before that commit, if you send the image "busybox" through the CRI, the container runtime receives "busybox". After that patch the container runtime gets "docker.io/library/busybox". While that may be correct for the internal kube dockershim, in the CRI we must not assume anything about image names. The ImageSpec is not providing any spec around the image so the container runtime should just get the raw image name from the pod spec. Every container runtime can handle image names the way it wants. The "docker.io" namespace is not at all "standard", CRI-O is not following what the docker UI say since that's the docker UI. We should not focus the CRI on wrong UI design, especially around a default namespace. Image name normalization is a Docker implementation detail around short images names, not the CRI. ImageSpec is not standardized yet: https://github.com/kubernetes/kubernetes/issues/46255 and https://github.com/kubernetes/kubernetes/issues/7203 This is something which should land in 1.9 as well since the regression is from 1.8. Signed-off-by:
Antonio Murdaca <runcom@redhat.com> **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note Fix regression in the CRI: do not add a default hostname on short image names ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 56995, 58498, 57426, 58902, 58863). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. cleanup enable/disable api resources code **What this PR does / why we need it**: After #57228, `runtime-config` flag has stop support enable/disable resources of a specific groupVersion, so this pr does some clean work about this. Mainly delete unused code in `k8s.io/apiserver/pkg/server/storage/resource_config.go` **Special notes for your reviewer**: /assign @deads2k @sttts **Release note**: ```release-note NONE ``` /kind cleanup
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 56995, 58498, 57426, 58902, 58863). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubelet: remove the rktshim directory This package contains only placeholders without actual implementation. Since it is not currently under active development, remove it to avoid unnecessary change needed whenever the interface is changed.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 56995, 58498, 57426, 58902, 58863). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. gce: reorder authorizers to the order Node,Webhook,RBAC,ABAC ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 56995, 58498, 57426, 58902, 58863). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Get windows kernel version directly from registry **What this PR does / why we need it**: kubernetes/kubernetes#55143 gets windows kernel version by calling windows.GetVersion(), but it doesn't work on windows 10. From https://msdn.microsoft.com/en-us/library/windows/desktop/ms724439(v=vs.85).aspx, GetVersion requires app to be manifested. Applications not manifested for Windows 8.1 or Windows 10 will return the Windows 8 OS version value (6.2). I tried a toy go program using GetVersion on Windows 10 and it returns 0x23f00206. Given the limited win32 functions in golang, we should read from registry directly. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #58497 **Special notes for your reviewer**: Should also cherry-pick to v1.9. **Release note**: ```release-note Get windows kernel version directly from registry ``` /cc @JiangtianLi @taylorb-microsoft
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 56995, 58498, 57426, 58902, 58863). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. flag precedence redo Changes the Kubelet configuration flag precedence order so that flags take precedence over config from files/ConfigMaps. This should fix the re-parse issue with #56097 that led to revert. Fixes #56171. In order to prevent global flags (registered in 3rd party libs, etc.) from leaking into the command's help text, this PR turns off Cobra's flag parsing in the `kubelet` command and re-implements help and usage funcs for the Kubelet. Cobra's default funcs automatically merge all global flags into the command's flagset, which results in incorrect help text. I tried to keep the formatting as close as possible to the what the Kubelet currently produces. Diff between Kubelet's help text on `upstream/master` vs `mtaufen/kc-flags-precedence-redo`, which shows a leaked flag being removed, but no change to the formatting: ``` diff --git a/upstream.master.help b/mtaufen.kc-flags-precedence-redo.help index 798a030..0797869 100644 --- a/upstream.master.help +++ b/mtaufen.kc-flags-precedence-redo.help @@ -30,7 +30,6 @@ Flags: --authorization-mode string Authorization mode for Kubelet server. Valid options are AlwaysAllow or Webhook. Webhook mode uses the SubjectAccessReview API to determine authorization. (default "AlwaysAllow") --authorization-webhook-cache-authorized-ttl duration The duration to cache 'authorized' responses from the webhook authorizer. (default 5m0s) --authorization-webhook-cache-unauthorized-ttl duration The duration to cache 'unauthorized' responses from the webhook authorizer. (default 30s) - --azure-container-registry-config string Path to the file containing Azure container registry configuration information. --bootstrap-checkpoint-path string <Warning: Alpha feature> Path to to the directory where the checkpoints are stored --bootstrap-kubeconfig string Path to a kubeconfig file that will be used to get client certificate for kubelet. If the file specified by --kubeconfig does not exist, the bootstrap kubeconfig is used to request a client certificate from the API server. On success, a kubeconfig file referencing the generated client certificate and key is written to the path specified by --kubeconfig. The client certificate and key file will be stored in the directory pointed by --cert-dir. --cadvisor-port int32 The port of the localhost cAdvisor endpoint (set to 0 to disable) (default 4194) ``` Ultimately, I think we should implement a common lib that K8s components can use to generate clean help text, as the global flag leakage problem affects all core k8s binaries. I would like to do so in a future PR, to keep this PR simple. We could base the help text format on the default values returned from `Command.HelpTemplate` and `Command.UsageTemplate`. Unfortunately, the template funcs used to process these defaults are private to Cobra, so we'd have to re-implement these, or avoid using them. ```release-note NONE ```
-
Lantao Liu authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. clean up unused const **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
p0lyn0mial authored
all remaining scalers were replaced by GenericScaler exept JobScaler. It is not clear whether JobScaler could use generic scaler or not. For more details see the pull request.
-
Lantao Liu authored
Signed-off-by:Lantao Liu <lantaol@google.com>
-
Antonio Murdaca authored
This patch fixes a regression introduced by https://github.com/kubernetes/kubernetes/pull/51751 in the CRI interface. That commit actually changed a unit test where we were previously *not* assuming anything about an image name. Before that commit, if you send the image "busybox" through the CRI, the container runtime receives "busybox". After that patch the container runtime gets "docker.io/library/busybox". While that may be correct for the internal kube dockershim, in the CRI we must not assume anything about image names. The ImageSpec is not providing any spec around the image so the container runtime should just get the raw image name from the pod spec. Every container runtime can handle image names the way it wants. The "docker.io" namespace is not at all "standard", CRI-O is not following what the docker UI say since that's the docker UI. We should not focus the CRI on wrong UI design, especially around a default namespace. ImageSpec is not standardized yet: https://github.com/kubernetes/kubernetes/issues/46255 and https://github.com/kubernetes/kubernetes/issues/7203 This is something which should land in 1.9 as well since the regression is from 1.8. Signed-off-by:
Antonio Murdaca <runcom@redhat.com>
-
Michael Taufen authored
This changes the Kubelet configuration flag precedence order so that flags take precedence over config from files/ConfigMaps. See #56171 for rationale. Note: Feature gates accumulate with the following precedence (greater number overrides lesser number): 1. file-based config 2. dynamic cofig 3. flag-based config
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58969, 58970). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix parameter advertise_address should be --advertise-address **What this PR does / why we need it**: Not sure how we missed this, the correct param is `--advertise-address` **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Michael Taufen authored
This PR completes the work started in https://github.com/kubernetes/kubernetes/pull/58760 by completely removing the KubeletConfigFile feature gate. We stopped setting the gate in test-infra in https://github.com/kubernetes/test-infra/pull/6490.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove unused test for node auto-repair. This test is testing GKE only feature and should use different infrastructure.
-
David Eads authored
-
Davanum Srinivas authored
-
Krzysztof Jastrzebski authored
This test is testing GKE only feature and should use different infrastructure.
-
David Eads authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Mini fix about typo ```release-note NONE ```
-
David Eads authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove deprecated --require-kubeconfig flag, remove default --kubeconfig value **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #41161 **Special notes for your reviewer**: **Release note**: ```release-note Remove deprecated --require-kubeconfig flag, remove default --kubeconfig value ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Hide generated files only on github **What this PR does / why we need it**: #54766 and #55114 introduced ability to hide generated files in diffs. It's nice and reasonable in github UI, but locally it's very frequent that author wants to verify the generated changes. This PR modifes `.gitattributes` so that the generated files are hidden only on github, leaving diff-able locally. /assign @liggitt @mikekap fyi, since you authored the original PRs **Release note**: ```release-note NONE ```
-
zhangxiaoyu-zidif authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Clean up unused functions and consts **What this PR does / why we need it**: Clean up unused functions and consts. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix webhook admission README There is no target `deploy-only` in the Makefile **Release note**: ```release-note NONE ```
-
- 28 Jan, 2018 2 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update README.md with punctuation improvements Added a semicolon on line 10 after "hosts" to improve sentence structure and prevent confusion. ```release-note NONE ```
-
Cao Shufeng authored
-