• Kubernetes Submit Queue's avatar
    Merge pull request #58955 from runcom/fix-cri-image-spec · da601bc7
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 58955, 58968, 58971, 58963, 58298). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    pkg: kubelet: do not assume anything about images names
    
    This patch fixes a regression introduced by
    https://github.com/kubernetes/kubernetes/pull/51751 in the CRI
    interface.
    That commit actually changed a unit test where we were previously *not*
    assuming anything about an image name.
    Before that commit, if you send the image "busybox" through the CRI,
    the container runtime receives "busybox". After that patch the
    container runtime gets "docker.io/library/busybox".
    While that may be correct for the internal kube dockershim, in the CRI
    we must not assume anything about image names. The ImageSpec is not
    providing any spec around the image so the container runtime should
    just get the raw image name from the pod spec. Every container runtime
    can handle image names the way it wants. The "docker.io" namespace is
    not at all "standard", CRI-O is not following what the docker UI say
    since that's the docker UI. We should not focus the CRI on wrong UI
    design, especially around a default namespace.
    Image name normalization is a Docker implementation detail around short images names, not the CRI. 
    
    ImageSpec is not standardized yet:
    https://github.com/kubernetes/kubernetes/issues/46255 and
    https://github.com/kubernetes/kubernetes/issues/7203
    
    This is something which should land in 1.9 as well since the regression
    is from 1.8.
    Signed-off-by: 's avatarAntonio Murdaca <runcom@redhat.com>
    
    
    
    **What this PR does / why we need it**:
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    Fix regression in the CRI: do not add a default hostname on short image names
    ```
    da601bc7
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
docs Loading commit data...
examples Loading commit data...
hack Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
translations Loading commit data...
vendor Loading commit data...
.bazelrc Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.kazelcfg.json Loading commit data...
BUILD.bazel Loading commit data...
CHANGELOG-1.10.md Loading commit data...
CHANGELOG-1.2.md Loading commit data...
CHANGELOG-1.3.md Loading commit data...
CHANGELOG-1.4.md Loading commit data...
CHANGELOG-1.5.md Loading commit data...
CHANGELOG-1.6.md Loading commit data...
CHANGELOG-1.7.md Loading commit data...
CHANGELOG-1.8.md Loading commit data...
CHANGELOG-1.9.md Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
SUPPORT.md Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...