1. 01 Jul, 2017 1 commit
  2. 29 Jun, 2017 30 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #47643 from CaoShuFeng/golang.org/x/exp/inotify · 956acc2b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46336, 47643)
      
      Fix invalid filename in kubelet log
      
      Fixes: https://github.com/kubernetes/kubernetes/issues/47641
      **Release note**:
      
      ```
      NONE
      ```
      956acc2b
    • Kubernetes Submit Queue's avatar
      Merge pull request #46336 from feiskyer/runAsUser · 786407cb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46336, 47643)
      
      Add node e2e tests for runAsUser
      
      **What this PR does / why we need it**:
      
      This PR adds node e2e tests for runAsUser.
      
      **Which issue this PR fixes** 
      
      Part of #44118.
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      786407cb
    • Kubernetes Submit Queue's avatar
      Merge pull request #48284 from nicksardo/ingress-ignore-delete-err · dc2b4e79
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47850, 47835, 46197, 47250, 48284)
      
      Do not fail on error when deleting ingress
      
      Fixes #48239
      
      If the api server or master is unavailable, the test should manually teardown load balancer resources. 
      
      **Release note**:
      ```release-note
      NONE
      ```
      dc2b4e79
    • Kubernetes Submit Queue's avatar
      Merge pull request #47250 from xiangpengzhao/fix-headless · fcf6eea7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47850, 47835, 46197, 47250, 48284)
      
      Populate endpoints for headless service with no ports
      
      **What this PR does / why we need it**:
      - populate endpoints with headless service (thanks @fraenkel for the original PR!)
      - allow ports with headless service
      - nits
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #32796 https://github.com/kubernetes/kubernetes/issues/32796#issuecomment-270462724
      
      **Special notes for your reviewer**:
      /cc @thockin @fraenkel 
      **Release note**:
      
      ```release-note
      NONE
      ```
      fcf6eea7
    • Kubernetes Submit Queue's avatar
      Merge pull request #46197 from xiangpengzhao/fix-allocate-clusterip · cc4b3cc7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47850, 47835, 46197, 47250, 48284)
      
      Allocate clusterIP when change service type from ExternalName to ClusterIP
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #35354 #46190
      
      **Special notes for your reviewer**:
      /cc @smarterclayton @thockin 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      cc4b3cc7
    • Kubernetes Submit Queue's avatar
      Merge pull request #47835 from juju-solutions/feature/security · d19773d8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47850, 47835, 46197, 47250, 48284)
      
      Securing the cluster created by Juju
      
      **What this PR does / why we need it**: This PR secures the deployments done with Juju master. Works around certain security issues inherent to kubernetes (see for example dashboard access)
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```
      Securing Juju kubernetes dashboard
      ```
      d19773d8
    • Kubernetes Submit Queue's avatar
      Merge pull request #47850 from dcbw/checkpoint-hostnetwork · 1cca341b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47850, 47835, 46197, 47250, 48284)
      
      dockershim: checkpoint HostNetwork property
      
      To ensure kubelet doesn't attempt network teardown on HostNetwork
      containers that no longer exist but are still checkpointed, make
      sure we preserve the HostNetwork property in checkpoints.  If
      the checkpoint indicates the container was a HostNetwork one,
      don't tear down the network since that would fail anyway.
      
      Related: https://github.com/kubernetes/kubernetes/issues/44307#issuecomment-299548609
      
      @freehan @kubernetes/sig-network-misc
      1cca341b
    • Kubernetes Submit Queue's avatar
      Merge pull request #48277 from abgworrall/master · 472e4ed9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47619, 47951, 46260, 48277)
      
      Write images.json file into artifacts dir
      
      /assign @fejta 
      /release-note-none
      
      Hi Erick - I picked the wring outputdir first time round ...
      472e4ed9
    • Kubernetes Submit Queue's avatar
      Merge pull request #46260 from perotinus/depsyncconv2 · 406c79cf
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47619, 47951, 46260, 48277)
      
      [Federation] Convert the deployment controller to a sync controller.
      
      This is based off of the work done for the ReplicaSet controller. It extracts out a schedulingAdapter that handles the shared logic between the two controllers.
      
      Targets #40989
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      406c79cf
    • Kubernetes Submit Queue's avatar
      Merge pull request #47951 from ixdy/bazel-busybox-image · a7a84124
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47619, 47951, 46260, 48277)
      
      bazel: update rules_docker and use official busybox base image
      
      **What this PR does / why we need it**: Follow-up of #46820 now that https://github.com/bazelbuild/rules_docker/issues/40 is fixed. Now all images built by bazel should have the same dependencies as those built with the dockerized build system.
      We can also stop worrying about updating our .deb dependency.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      /release-note-none
      /assign @mikedanese @spxtr
      a7a84124
    • Kubernetes Submit Queue's avatar
      Merge pull request #47619 from mtanino/iscsi-remove-redundant-nil-check · ad077c4c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47619, 47951, 46260, 48277)
      
      iSCSi plugin: Remove redundant nil check
      
      **What this PR does / why we need it**:
      
      This patch is for cleanup of redundant nil check in iSCSI plugin.
      This was mentioned at the code review on origin github thread.
      
      https://github.com/openshift/origin/pull/14565
      
      **Which issue this PR fixes** 
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```
      NONE
      ```
      ad077c4c
    • Nick Sardo's avatar
      Do not fail on error when deleting ingress · 642154a7
      Nick Sardo authored
      642154a7
    • Kubernetes Submit Queue's avatar
      Merge pull request #47984 from ironcladlou/local-cluster-vmodule · 33fc75e2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46850, 47984)
      
      Enable vmodule support for all components
      
      Support vmodule (via `LOG_SPEC`) for all local cluster components.
      
      ```release-note
      NONE
      ```
      33fc75e2
    • Kubernetes Submit Queue's avatar
      Merge pull request #46850 from x13n/nanny-version · d3aa0d5a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46850, 47984)
      
      Update addon-resizer version
      
      Update addon-resizer version and remove the flags that have been deprecated in the new version.
      
      **What this PR does / why we need it**:
      ref kubernetes/contrib#2623
      
      **Special notes for your reviewer**:
      Need to wait for merging kubernetes/contrib#2623 first.
      
      **Release note**:
      ```release-note
      addon-resizer flapping behavior was removed.
      ```
      d3aa0d5a
    • Kubernetes Submit Queue's avatar
      Merge pull request #48204 from shyamjvs/logdump-only-n-nodes · 70184799
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Allow log-dumping only N randomly-chosen nodes in the cluster
      
      This should let us save "lots" (~3-4 hours) of time in our 5000-node cluster scale tests as we copy logs from all the nodes to jenkins worker and then upload all of them to gcs (while we don't need too many).
      This will also prevent the jenkins container facing "No space left on device" error while dumping logs, that we saw in runs 12-13 of gce-enormous-cluster.
      
      The longterm fix will be to enable [logexporter](https://github.com/kubernetes/test-infra/tree/master/logexporter) for our tests.
      
      cc @kubernetes/sig-scalability-misc @kubernetes/test-infra-maintainers @gmarek @fejta
      70184799
    • Kubernetes Submit Queue's avatar
      Merge pull request #47900 from yiqinguo/yiqinguo_add_type_judgment · c9ad8dcd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add type conversion judgment
      
      If do not type conversion judgment, there may be panic.
      
      **Release note**:
      ```release-note
      NONE
      ```
      c9ad8dcd
    • Daniel Kłobuszewski's avatar
      Update addon-resizer version · 63ccedcf
      Daniel Kłobuszewski authored
      Also, remove the flags that have been deprecated in the new version.
      63ccedcf
    • Kubernetes Submit Queue's avatar
      Merge pull request #47729 from paultyng/pt/useragent · 343d751b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47286, 47729)
      
      Set default User-Agent on http probe
      
      **Set a default User-Agent on `httpGet` probes**:
      
      Currently the default Go HTTP client sets a `User-Agent` specific to the language and version, but every Go client has the same one.  In Kubernetes, users can override the User-Agent by setting a header in their probe definition, but its tedious to do this everywhere.
      
      This PR changes the default User-Agent only if not set (or removed) in the probe definition.
      
      **Which issue this PR fixes** 
      fixes #29025
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Change default `httpGet` probe `User-Agent` to `kube-probe/<version major.minor>` if none specified, overriding the default Go `User-Agent`.
      ```
      343d751b
    • Kubernetes Submit Queue's avatar
      Merge pull request #47286 from cosmincojocar/client_cert_azure_cloud_provider · db46e4f8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47286, 47729)
      
      Add client certificate authentication to Azure cloud provider
      
      This adds support for client cert authentication in Azure cloud provider. The certificate can be provided in PKCS #12 format with password protection. Not that this authentication will be active only when no client secret is configured.
      
      cc @brendandburns @colemickens
      db46e4f8
    • Kubernetes Submit Queue's avatar
      Merge pull request #48172 from gyliu513/const · 06fcfe23
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48137, 48172)
      
      Used const variable in scheduler test.
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      none
      ```
      06fcfe23
    • Kubernetes Submit Queue's avatar
      Merge pull request #48137 from danwinship/utiltests · 3b356964
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fixes to two pkg/util unit tests
      
      Spun out from #46537. Trivial unit test fixes:
      - `pkg/util/ebtables/ebtables_test.go`'s tests are incorrectly named and so weren't getting run by "go test". (And one of them had a typo in it so it failed after the name was fixed)
      - In `pkg/util/iptables/iptables_test.go`, the deletion tests were apparently written by copying+pasting+editing the creation tests, but they forgot to change the names of the tests to match the behavior that was being tested in the new version
      3b356964
    • Guangya Liu's avatar
      Used const variable in scheduler test. · e0d02f14
      Guangya Liu authored
      e0d02f14
    • Dawn Chen's avatar
      Merge pull request #48235 from xiangpengzhao/fix-get-capacity · 8bece8ec
      Dawn Chen authored
      Implement GetCapacity in container_manager_unsupported
      8bece8ec
    • xiangpengzhao's avatar
      53c536b5
    • Kubernetes Submit Queue's avatar
      Merge pull request #47827 from yiqinguo/yiqinguo_repeat_type_coversions · b6972221
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Remove repeat type conversions
      
      Here is the type of conversion for the variable is repeated.
      
      **Release note**:
      ```release-note
      NONE
      ```
      b6972221
    • Pengfei Ni's avatar
      Add node e2e tests for runAsUser · 00eeb7f5
      Pengfei Ni authored
      00eeb7f5
    • Adam Worrall's avatar
      Write output into the correct dir · f375dcf4
      Adam Worrall authored
      f375dcf4
    • Jonathan MacMillan's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #48154 from krousey/upgrades · b353792f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48214, 48154)
      
      Adding a retry and traceroute to the master version checking
      
      This is hitting a lot of connection refused errors in the e2e upgrade tests. We should make this more robust in case this is intermittent network errors. In the event of an error, attempt to log a traceroute to the master.
      
      cc @kubernetes/sig-cluster-lifecycle-bugs @dchen1107 
      
      #47379
      b353792f
    • Kubernetes Submit Queue's avatar
      Merge pull request #48214 from shyamjvs/heapster-node-in-gce · bcb44655
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48214, 48154)
      
      Allow creating special node for running heapster in GCE
      
      This should enable scheduling heapster pod(s) in our large cluster tests, where the minions are very small (n1-standard-1) and heapster can't schedule on them due to high memory requests.
      We need this for running heapster dependent correctness tests in 5k-node cluster.
      
      cc @kubernetes/sig-scalability-misc @kubernetes/heapster-maintainers @gmarek
      bcb44655
  3. 28 Jun, 2017 9 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #47014 from boingram/deletePod-handler-shouldnt-set-owner-refs · 37c9367a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      deletePod handler in the deployment controller shouldn't set owner refs
      
      **What this PR does / why we need it**:
      This PR stops the deletePod handler in the deployment controller from adopting replica sets when determining if a deployment needs to be requeued. It leaves this logic to the replication loop, removing the replica set adoption side effect.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #46933 
      
      **Special notes for your reviewer**:
      @kargakis PR for delete pod handler setting owner refs issue
      
      **Release note**:
      
      ```release-note
      ```
      37c9367a
    • Shyam Jeedigunta's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #48065 from ironcladlou/unstructured-field-fix · d0735b90
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48183, 45611, 48065)
      
      Fix Unstructured field accessor
      
      Fix the Unstructured GetDeletionGracePeriodSeconds accessor which was
      always returning nil regardless of the underlying stored value. The
      field value always appearing nil prevents Custom Resource instances
      from being deleted when garbage collection is enabled for CRs and
      when DeletePropagationOrphan is used. More generally, this fix means that
      delete-on-update now works for CR instances.
      
      Add some test coverage for Unstructured metadata deserialization.
      
      The Unstructured DeletionGracePeriodSeconds field marshals as a value
      type from JSON and as a pointer type via SetDeletionGracePeriodSeconds.
      The GetDeletionGracePeriodSeconds method now supports handling both
      int64 and *int64 values so that either underlying value can be returned.
      
      Add a reflection-based unit test which attempts to exercise all the
      Object Get/Set methods for nil handling.
      
      ```release-note
      Registries backed by the generic Store's `Update` implementation support delete-on-update, which allows resources to be automatically deleted during an update provided:
      
      * Garbage collection is enabled for the Store
      * The resource being updated has no finalizers
      * The resource being updated has a non-nil DeletionGracePeriodSeconds equal to 0
      
      With this fix, Custom Resource instances now also support delete-on-update behavior under the same circumstances.
      ```
      d0735b90
    • Kubernetes Submit Queue's avatar
      Merge pull request #45611 from atombender/issue-45608 · 7c656ab4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48183, 45611, 48065)
      
      kubectl: 'apply view-last-applied' must not use printf() semantics
      
      **What this PR does / why we need it**:
      This fixes `kubectl apply view-last-applied` to not use `fmt.Fprintf()`, as this will cause format codes in the YAML/JSON to be interpreted. For example, if a resource manifest contains `%r`, this would cause `view-last-applied` so print `%!r(MISSING)`.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #45608.
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Fixes an edge case where "kubectl apply view-last-applied" would emit garbage if the data contained Go format codes.
      ```
      7c656ab4
    • Kubernetes Submit Queue's avatar
      Merge pull request #48183 from xiangpengzhao/fix-proxy-panic · 40f7b595
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix kube-proxy panic when running with "--cleanup-iptables=true"
      
      **What this PR does / why we need it**:
      Save the `--cleanup-iptables` config for new ProxyServer when it's true.
      Also check if Broadcaster and EventClient are nil to avoid other potential panic.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48177
      
      **Special notes for your reviewer**:
      /cc @ncdc @irake99
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      40f7b595
    • Shyam Jeedigunta's avatar
      cc8bb857
    • Kris's avatar
      Add traceroute logging on connection failure · faf7dff7
      Kris authored
      faf7dff7
    • Kubernetes Submit Queue's avatar
      Merge pull request #48199 from MaciekPytel/fix_autoscaler_e2e_on_gke · 40f33a4b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48168, 48199)
      
      Fix some flakes in autoscaler e2e on gke
      
      This PR should fix some of the flakes we found in e2e runs, while testing for 1.7 release:
       - if one of the nodes is unschedulable in set up (causing set up to fail) we used to wait for wrong number of nodes in clean-up, adding unnecessary 20 minute wait to failing test
       - we did not check for errors when creating RC in test, leading to tests failing later in hard to debug way (added retry loop and explicit test failure)
      40f33a4b
    • Kubernetes Submit Queue's avatar
      Merge pull request #48168 from abgworrall/abw-image-version-metadata · 4c1667e3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48168, 48199)
      
      Log the OS images used during GCP cluster creation
      
      /assign @fejta
      4c1667e3