1. 12 May, 2017 21 commits
  2. 11 May, 2017 19 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #45495 from deads2k/server-24-stop · 86eb1894
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      plumb stopch to post start hook index since many of them are starting go funcs
      
      Many post-start hooks require a stop channel to properly terminate their go funcs.
      
      @p0lyn0mial I think you need this for https://github.com/kubernetes/kubernetes/pull/45355 ptal.
      @ncdc per request
      @sttts can you review too since Andy is out?
      86eb1894
    • Kubernetes Submit Queue's avatar
      Merge pull request #45672 from wojtek-t/bump_l7_threshold · c93c50b4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Bump l7-lb-controller resource usage threshold in tests
      
      Fix #45512
      c93c50b4
    • Kubernetes Submit Queue's avatar
      Merge pull request #45559 from rmmh/no-xss · 69ad6add
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      HTML escape apiserver errors to avoid triggering vulnerability scanners.
      
      Simple XSS scans might fetch /<script>alert('vulnerable')</script>, and
      fail when the response body includes the script tag verbatim, despite
      the headers directing the browser to interpret the response as text.
      
      This isn't a real vulnerability, but it's easier to fix this here than
      it is to fix the scanners.
      
      
      **Release note**:
      ```release-note
      NONE
      ```
      69ad6add
    • Bowei Du's avatar
      Update kube-dns version to 1.14.2 · 1c223c8e
      Bowei Du authored
      Changes:
      
      - Support kube-master-url flag without kubeconfig
      - Fix concurrent R/Ws in dns.go
      - Fix confusing logging when initialize server
      - Fix printf in cmd/kube-dns/app/server.go
      - Fix version on startup and --version flag
      - Support specifying port number for nameserver in stubDomains
      1c223c8e
    • Kubernetes Submit Queue's avatar
      Merge pull request #41684 from gyliu513/kubelet-types-labels · 3dfffac7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Improved code coverage for pkg/kubelet/types/labels
      
      The test coverage improved from 0% to 100%.
      This fixed part of #40780
      
      
      
      **What this PR does / why we need it**:
      Increase test coverage.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      release-note-none
      
      **Release note**:
      
      ```NONE
      ```
      3dfffac7
    • Wojciech Tyczynski's avatar
    • Dan Winship's avatar
      Fix XDG-based kubectl plugin dirs · 415fe527
      Dan Winship authored
      415fe527
    • Crazykev's avatar
      return success if ImageNotFound in RemoveImage() · ebb5c3d1
      Crazykev authored
      Signed-off-by: 's avatarCrazykev <crazykev@zju.edu.cn>
      ebb5c3d1
    • Julien Balestra's avatar
    • deads2k's avatar
    • deads2k's avatar
      orphan when kubectl delete --cascade=false · e91716a2
      deads2k authored
      e91716a2
    • Kubernetes Submit Queue's avatar
      Merge pull request #45631 from nilebox/nilebox/remove-doc-insecure · 48caf95a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Remove mentioning insecure server (which is not supported anymore) from API server docs
      
      **What this PR does / why we need it**:
      Remove mentioning insecure serving from the docs, since only secure serving is supported now.
      48caf95a
    • Kubernetes Submit Queue's avatar
      Merge pull request #45641 from xilabao/update-token-ttl-description · 640373da
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44626, 45641)
      
      update token ttl description
      640373da
    • Kubernetes Submit Queue's avatar
      Merge pull request #44626 from madhusudancs/fed-dns-paged-list · 15df7fed
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 44626, 45641)
      
      Update Google Cloud DNS provider Rrset.Get(name) method to return a list and change the `Rrset.List()` implementation to perform a paged walk
      
      Some federated service e2e tests and a few ingress tests would become flaky after a few hundred runs. @csbell spent quite a lot of time debugging this and found out that this flakiness was due to a bug in the federated service controller deletion logic. Deletion of a federated service object triggers a logic in the controller to update the DNS records corresponding to that object. This DNS record update logic would return an error in failed runs which would in-turn cause the controller to reschedule the operation. This led to an infinite retry-failure cycle that never gave the API server a chance to garbage collect the deleted service object.
      
      A couple of days ago we started seeing a correlation between the number of resource records in a DNS managed zone and these test failures. If you look at the test runs before and after run 2900 in the test grid - https://k8s-testgrid.appspot.com/cluster-federation#gce, you will notice that the grid became super green at 2900. That's when I deleted all the dangling DNS records from the past runs.
      
      After some investigation yesterday, we found that `ResourceRecordSet.Get()` interface and its implementation, and `ResourceRecordSet.List()` implementation at least for Google Cloud DNS were incorrect.
      
      This PR makes minimal set of changes (read: least invasive) in Google Cloud DNS provider implementation to fix these problems:
      
      1. Modifies DNS provider Rrset.Get(name) interface to return multiple records and updates federated service controller.
      
          There can be multiple DNS resource records for a given name. They can vary by type, ttl, rrdata and a number of various other parameters. It is incorrect to return a single resource record for a given name.
      
          This change updates the Get interface to return multiple records for a given name and uses this list in the federated service controller to perform DNS operations.
      
      2. Update Google Cloud DNS List implementation to perform a paged walk of lists to aggregate all the DNS records.
      
          The current `List()` implementation just lists the DNS resorce records in a given managed zone once and retruns the list. It neither performs a paged walk nor does it consider the `page_token` in the returned response.
      
          This change walks all the pages and aggregates the records in the pages and returns the aggregated list. This is potentially dangerous as it can blow up memory if there are a huge number of records in the given managed zone. But this is the best we can do without changing the provider interface too much. 
      
          Next step is to define a new paged list interface and implement it.
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      /assign @csbell 
      
      cc @justinsb @shashidharatd @quinton-hoole @kubernetes/sig-federation-pr-reviews
      15df7fed
    • Kubernetes Submit Queue's avatar
      Merge pull request #44861 from sttts/sttts-dynamic-client-listoptions-fallback · 6288c4e9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      apimachinery: NotRegisteredErr for known kinds not registered in target GV
      
      Fixes the fall back to core v1 for *Options in the parameter encoder of the dynamic client.
      
      The dynamic client uses NotRegisteredErr to fall back to core v1 if ListOptions is not known
      in the given GV. This commit fixes the case that ListOptions is known in some group, but not
      in the given one.
      6288c4e9
    • Kubernetes Submit Queue's avatar
      Merge pull request #45630 from zjj2wry/e2e · 33356a18
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      small change to view more test info
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      small change to view more test info, think you very much
      
      **Release note**:
      
      ```release-note
      ```
      33356a18
    • Dr. Stefan Schimanski's avatar
      NotRegisteredErr for known kinds not registered in target GV · 2ece9e4d
      Dr. Stefan Schimanski authored
      The dynamic client uses NotRegisteredErr to fall back to core v1 if ListOptions is not known
      in the given GV. This commit fixes the case that ListOptions is known in some group, but not
      in the given one.
      2ece9e4d
    • Madhusudan.C.S's avatar
      Remove all the existing records before creating new ones to avoid DNS misconfiguration. · 4bde13ac
      Madhusudan.C.S authored
      When we fetch the dns records by name, we get a list of records that match
      the given name. As an optimization we look up to see if the new record we
      want to create is already in the returned list to avoid performing any updates.
      
      However, when the new record we want to create isn't in the returned list, it
      is hard to say if the returned list contains the list of records that we want
      to retain. For example, we might get a list of A records and we want to create
      a CNAME record. Creating a new CNAME record without removing the A records is
      a DNS misconfiguration. So to play safe we just remove all the existing records
      in the list and create the new desired record.
      
      **Note**: This is the opposite of what I said here - https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/44626#-Ki9xQOzybryHvsxNrra.
      4bde13ac
    • xilabao's avatar
      update token ttl description · 7f5e8fde
      xilabao authored
      7f5e8fde