- 15 May, 2017 40 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 41331, 45591, 45600, 45176, 45658) Updating generic registry to return UID of the deleted resource Ref https://github.com/kubernetes/kubernetes/issues/42594 cc @kubernetes/sig-api-machinery-pr-reviews @smarterclayton ```release-note Updating apiserver to return UID of the deleted resource. Clients can use this UID to verify that the resource was deleted or waiting for finalizers. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 41331, 45591, 45600, 45176, 45658) Fixing typo in ImagePolicyWebhook admission.go **What this PR does / why we need it**: Noticed a typo in kubectl events when working with the ImagePolicyWebhook admission controller **Special notes for your reviewer**: first time contributor
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 41331, 45591, 45600, 45176, 45658) Move client/unversioned/remotecommand to client-go Module remotecommand originally part of kubernetes/pkg/client/unversioned was moved to client-go/tools, and will be used as authoritative in kubectl, e2e and other places. Module remotecommand relies on util/exec module which was copied to client-go/pkg/util
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45826, 45747, 45548, 45606, 41766) CRI: using typed filed for sysctls **What this PR does / why we need it**: CRI supports sysctls via annotations [today](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/api/v1alpha1/runtime/api.proto#L237), we should move them to typed and structured fields instead. (refer [here](https://github.com/kubernetes/kubernetes/issues/30819#issuecomment-253369441)) **Which issue this PR fixes** Part of #39130. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45826, 45747, 45548, 45606, 41766) fixed typo in cockroachdb-statefulset.yaml **What this PR does / why we need it**: typo, the syntax was invalid. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45826, 45747, 45548, 45606, 41766) Fix typo in name of ss controller
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45826, 45747, 45548, 45606, 41766) OwnerReferencesPermissionEnforcement ignores pods/status **What this PR does / why we need it**: It makes the `OwnerReferencesPermissionEnforcement` admission plug-in ignore pods/status operations. If a cluster has version skew with its master (1.6) and nodes (1.6-N), the kubelet is doing a pods/status operation and that code path is causing an error because ownerRef has new fields unknown to kubelet. **Release note**: ```release-note OwnerReferencesPermissionEnforcement admission plugin ignores pods/status. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45826, 45747, 45548, 45606, 41766) prevent pods/status from touching ownerreferences pods/status updates touching ownerreferences causes new fields to be dropped. I think we really want to protect our metatdata by default with something like https://github.com/kubernetes/kubernetes/pull/45552 . This fixes the immediate problem. ```release-note prevent pods/status from touching ownerreferences ``` @derekwaynecarr @eparis
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix resource typo
-
Anthony Yeh authored
CHANGELOG: Add Known Issues for v1.6.3
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix the outdated link to the Helm Charts repo **What this PR does / why we need it**: It is only a link fix, the repo URL has changed **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue docs:examples:guestbook: don't advice untagged image Using untagged images means no version at all, this can cause weird problems. Right now, `redis:latest` is no longer compatible with the redis version used in the slave service of the example.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45807, 45814) Fix invalid bash script in unit test. This change fix such error when we run "make test": "find: invalid expression; you have used a binary operator '-o' with nothing before it." @deads2k **Release note**: ```release-note ``` -
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45807, 45814) Fix typo.
-
Derek Carr authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45070, 45821, 45732, 45494, 45789) Rename vars scheduledJob to cronJob **What this PR does / why we need it**: Rename vars scheduledJob to cronJob **Special notes for your reviewer**: refer to #45480 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45070, 45821, 45732, 45494, 45789) Fix lint errors in juju kubernetes master and e2e charms **What this PR does / why we need it**: Fixes style error in the Juju charms **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ``` Code style fixes in Juju charms ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45070, 45821, 45732, 45494, 45789) apiextesions-server integration tests: test multiple registration **What this PR does / why we need it**: Add integration test for Multiple registrations XREF: #45511 **Special notes for your reviewer**: @deads2k my first plan was to submit one single PR for both tests but I'm facing one issue with resources deregistration. Get in touch via slack
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45070, 45821, 45732, 45494, 45789) Minor fix in run-gcloud-compute-with-retries output piping To work with older versions of bash. cc @wojtek-t @gmarek
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Uses container/heap for DelayingQueue The current implementation of DelayingQueue doesn't perform very well when a large number of items (at random delays) are inserted. The original authors seemed to be aware of this and noted it in a `TODO` comment. This is my attempt at switching the implementation to use a priority queue based on `container/heap`. Benchmarks from before the change: ``` ╰─ go test -bench=. -benchmem | tee /tmp/before.txt BenchmarkDelayingQueue_AddAfter-8 300000 256824 ns/op 520 B/op 3 allocs/op PASS ok k8s.io/kubernetes/staging/src/k8s.io/client-go/util/workqueue 77.237s ``` After: ``` ╰─ go test -bench=. -benchmem | tee /tmp/after.txt BenchmarkDelayingQueue_AddAfter-8 500000 3519 ns/op 406 B/op 4 allocs/op PASS ok k8s.io/kubernetes/staging/src/k8s.io/client-go/util/workqueue 2.969s ``` Comparison: ``` ╰─ benchcmp /tmp/before.txt /tmp/after.txt benchmark old ns/op new ns/op delta BenchmarkDelayingQueue_AddAfter-8 256824 3519 -98.63% benchmark old allocs new allocs delta BenchmarkDelayingQueue_AddAfter-8 3 4 +33.33% benchmark old bytes new bytes delta BenchmarkDelayingQueue_AddAfter-8 520 406 -21.92% ``` I also find the `container/heap`-based code a bit more easy to understand. The implementation of the PriorityQueue is based on the documentation for `container/heap`. Feedback definitely welcomed. This is one of my first contributions. ```release-note NONE ```
-
deads2k authored
-
Dmitry Shulyak authored
-
Dmitry Shulyak authored
-
Dmitry Shulyak authored
-
Dmitry Shulyak authored
client-go/pkt/util was removed in favor of client-go util, which consists only from CodeExitError and ExitError interface
-
Dmitry Shulyak authored
Module remotecommand originally part of kubernetes/pkg/client/unversioned was moved to client-go/tools, and will be used as authoritative in kubectl, e2e and other places. Module remotecommand relies on util/exec module which will be copied to client-go/pkg/util
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue kube-apiextensions-server: Fix potential SEGV with null delegate handler **What this PR does / why we need it**: In the kube-apiextensions-server there is a fallback value for `null` delegate to `http.NotFoundHandler()` in handling group and versions discovery, but no fallback for custom resources endpoint. It leads to SEGV when running with `genericapiserver.EmptyDelegate`.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix discovery version for autoscaling to be v1 The order of the storage setup blocks in the setup for the autoscaling API group was accidentally inverted, meaning that if the v2alpha1 API group was turned on, it would be set to the preferred API group-version for discovery. This was unintentional; the latest stable version should (v1) should be preferred instead. **Release note**: ```release-note Ensure that autoscaling/v1 is the preferred version for API discovery when autoscaling/v2alpha1 is enabled. ```
-
Salvatore Dario Minonne authored
-
Shyam Jeedigunta authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue [Federation] Fix federated service reconcilation issue due to addition of External… …TrafficPolicy field to v1.Service **What this PR does / why we need it**: New fields (ExternalTrafficPolicy) are introduced to v1.Service by this PR #41162. If this field is not specified in service spec, the service controller will assign default and updates the service spec. In federation, the service spec is not updated and we continuously try to reconcile as the federated service and the service in federated cluster do not match. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #45795 **Special notes for your reviewer**: **Release note**: ``` NONE ``` cc @kubernetes/sig-federation-bugs @madhusudancs
-
Cao Shufeng authored
This change fix such error when we run "make test": "find: invalid expression; you have used a binary operator '-o' with nothing before it." -
nikhiljindal authored
-
nikhiljindal authored
-
nikhiljindal authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue util/iptables: fix cross-build failures due to syscall.Flock() Fixes: https://github.com/kubernetes/kubernetes/issues/45554 Related: https://github.com/kubernetes/kubernetes/pull/44895 @luxas @k82cn @danwinship
-
Xing Zhou authored
Fixed typo.
-
shashidharatd authored
Fix federated service reconcilation issue due to addition of ExternalTrafficPolicy field to v1.Service
-
Pengfei Ni authored
-
Pengfei Ni authored
-