- 13 Aug, 2016 1 commit
-
-
Tim Hockin authored
Repro case: $ make clean generated_files $ hack/update-generated-protobuf.sh This would complain about not finding `fmt`, and it was indicating the wrong GOROOT. The problem was that the first step built binaries for generating code, which *embeds* the value of GOROOT into the binary. The whole tree was bind-mounted into the build container and then JUST the dockerized dir was mounted over it. The in-container build tried to use the existing binaries, but GOROOT is wrong. This change whites-out the whole _output dir. I first made just an anonymous volume for _output, but docker makes that as root, which means I can't write to it from our non-root build. So I just put it in the data container. This seems to work. The biggest change this makes is that the $GOPATH/bin/ and $GOPATH/pkg/ dirs will persist across dockerized builds.
-
- 12 Aug, 2016 35 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add support for kube-up.sh to deploy Calico network policy to GCI masters Also remove requirement for calicoctl from Debian / salt installed nodes and clean it up a little by deploying calico-node with a manifest rather than calicoctl. This also makes it more reliable by retrying properly. How to use: ``` make quick-release NETWORK_POLICY_PROVIDER=calico cluster/kube-up.sh ``` One place where I was uncertain: - CPU allocations (on the master particularly, where there's very little spare capacity). I took some from etcd, but if there's a better way to decide this, I'm happy to change it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/29037) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update HumanResourcePrinter signature w single PrintOptions param release-note-none - Makes [HumanReadablePrinter options field non-exported again](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/resource_printer.go#L346-349) - Adds test-case for HumanReadablePrinter resource printing with aliases. - Better formatting for saving resource "kind" aliases []() <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/28509) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Implement 'kubectl top' command ```release-note Added 'kubectl top' command showing the resource usage metrics. ``` Sample output: Nodes: ``` $ kubectl top node NAME CPU MEMORY STORAGE TIMESTAMP kubernetes-minion-group-xxxx 76m 1468 Mi 0 Mi Tue, 12 Jul 2016 17:37:00 +0200 kubernetes-minion-group-yyyy 73m 1511 Mi 0 Mi Tue, 12 Jul 2016 17:37:00 +0200 kubernetes-minion-group-zzzz 46m 1506 Mi 0 Mi Tue, 12 Jul 2016 17:37:00 +0200 kubernetes-master 76m 2059 Mi 0 Mi Tue, 12 Jul 2016 17:37:00 +0200 ``` Pods in all namespaces: ``` $ kubectl top pod --all-namespaces NAMESPACE NAME CPU MEMORY STORAGE TIMESTAMP default nginx-1111111111-zzzzz 0m 1 Mi 0 Mi Tue, 12 Jul 2016 17:49:00 +0200 kube-system etcd-server-kubernetes-master 4m 116 Mi 0 Mi Tue, 12 Jul 2016 17:49:00 +0200 kube-system fluentd-cloud-logging-kubernetes-minion-group-xxxx 14m 110 Mi 0 Mi Tue, 12 Jul 2016 17:49:00 +0200 kube-system kube-dns-v18-zzzzz 1m 6 Mi 0 Mi Tue, 12 Jul 2016 17:49:00 +0200 ... ``` Pod with containers: ``` $ kubectl top pod heapster-v1.1.0-1111111111-miail --namespace=kube-system --containers NAMESPACE NAME CPU MEMORY STORAGE TIMESTAMP kube-system heapster-v1.1.0-1111111111-miail 1m 42 Mi 0 Mi Tue, 12 Jul 2016 17:52:00 +0200 heapster 1m 26 Mi 0 Mi eventer 0m 3 Mi 0 Mi heapster-nanny 0m 6 Mi 0 Mi eventer-nanny 0m 6 Mi 0 Mi ``` ref #11382 []() <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/28844) <!-- Reviewable:end --> -
Kubernetes Submit Queue authored
Automatic merge from submit-queue return err on `kubectl run --image` with invalid value When running `kubectl run <configname> --image="Invalid$$%ImageValue%%__"`, a configuration is successfully created with an image name that is not a valid value for an image reference. This patch validates that the image name is a valid image reference, and returns an error before creating a config if an invalid value is passed. `$ kubectl run test --image="Invalid__%imagename"` ``` error: Invalid image name "Invalid__%imagename": invalid reference format ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30162) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Basic audit log Fixes #2203 by introducing simple audit logging, including the information about impersonation. We currently have something identical in openshift, but I'm open to any suggestions. Sample logs look like that: as `<self>`: ``` AUDIT: id="75114bb5-970a-47d5-a5f1-1e99cea0574c" ip="127.0.0.1" method="GET" user="test-admin" as="<self>" namespace="openshift" uri="/api/v1/namespaces/openshift/pods/python" AUDIT: id="75114bb5-970a-47d5-a5f1-1e99cea0574c" response=200 ``` as user: ``` AUDIT: id="b0a443ae-f7d8-408c-a355-eb9501fd5c59" ip="192.168.121.118" method="GET" user="system:admin" as="test-admin" namespace="openshift" uri="/api/v1/namespaces/openshift/pods/python" AUDIT: id="b0a443ae-f7d8-408c-a355-eb9501fd5c59" response=200 ``` ```release-note * Add basic audit logging ``` @ericchiang @smarterclayton @roberthbailey @erictune @ghodss []() <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/27087) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add an issue template, tighten PR template Supersedes #28488 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30167) <!-- Reviewable:end -->
-
Marcin Wielgus authored
Federation e2e test util using clientset 1.4
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fixed misconfigured kubelet on containervm image for node-e2e. Fixed #30412 to unblock @coufon's performance benchmark work. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30415) <!-- Reviewable:end -->
-
Maciej Szulik authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Avoid computing DeepEqual in controllers all the time Computing DeepCopy was responsible for ~33% of cpu usage of controller-manager before this PR. <!-- Checklist for submitting a Pull Request Please remove this comment block before submitting. 1. Please read our [contributor guidelines](https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md). 2. See our [developer guide](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md). 3. If you want this PR to automatically close an issue when it is merged, add `fixes #<issue number>` or `fixes #<issue number>, fixes #<issue number>` to close multiple issues (see: https://github.com/blog/1506-closing-issues-via-pull-requests). 4. Follow the instructions for [labeling and writing a release note for this PR](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes) in the block below. --> ```release-note * Use the release-note-* labels to set the release note state * Clear this block to use the PR title as the release note -OR- * Enter your extended release note here (newlines are formatted as bullets) ``` <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30277) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue cluster/log-dump scp shouldn't check host keys for aws parity with cluster/aws/util.sh:ssh-to-node <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30472) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Let kubectl delete rc and rs with DeleteOptions.OrphanDependents=false so that when the garbage collector is enabled, RC and RS are deleted immediately without waiting for the garbage collector to orphan the pods. There is no user visible changes, so we don't need a release note. cc @fabioy <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30461) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Marked NodePhase deprecated. cc/ @lavalamp Even Kubernetes stops set NodePhase for a while, the user might patch NodeStatus with NodePhase. Marked the field deprecated and documented first. xref: https://github.com/kubernetes/kubernetes.github.io/pull/549 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30005) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue t.Errorf output wrong variables in identity_mapper_test.go t.Errorf output wrong variables in identity_mapper_test.go <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/29502) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue hack/e2e.go: Make --dump run if --up fails, and if --down isn't specified See https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-e2e-aws/629 for why this would be useful. (And the requirement for --down is just unnecessary AFAICT.) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30405) <!-- Reviewable:end -->
-
Marcin Wielgus authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix some typos in control-plane-resilience.md Fix some typos in control-plane-resilience.md <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30209) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Name jobs created by sj deterministically ```release-note Name the job created by scheduledjob (sj) deterministically with sj's name and a hash of job's scheduled time. ``` @erictune @soltysh <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30420) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Turn on flake mitigation for the node e2e test <!-- Reviewable:start --> This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30485) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix code generators-- make scheme building composable I needed to make some changes to make my other refactoring possible and this got rather large. We now provide a "SchemeBuilder" to help all of the api packages provide their scheme-building functions (addKnownTypes and friends) in a standardized way. This also allows generated deepcopies & conversions to be entirely self contained, the project will now build without them being present (as they can add themselves to the SchemeBuilder). (Although if you actually build without them, you will get reduced performance!) Previously, there was no way to construct your own runtime.Scheme (e.g., to test), you had to use the api.Scheme object, which has all sorts of non-hermetic cruft in it. Now you can get everything from a package by calling the scheme builder's AddToScheme, including the generated functions, if they are present. Next steps are to allow for declaring dependencies, and to standardize the registration & install code. (#25434) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/25526) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue the observed usage should match those that have hard constraints in the sync process, the quota will be replenished, the new observed usage will be sumed from each evaluator, if the previousUsed set is not be cleared, the new usage will be dirty, maybe some unusage resource still in , as the code below newUsage = quota.Mask(newUsage, matchedResources) for key, value := range newUsage { usage.Status.Used[key] = value } so i think here shoul not set value previousUsed <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/29653) <!-- Reviewable:end --> -
Kubernetes Submit Queue authored
Automatic merge from submit-queue Quota admission errors if usage is negative If quota observes negative usage for an artifact, that artifact could game the quota system. This adds a global check in the quota system to catch this scenario for all evaluators. /cc @deads2k <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30396) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Display pod tolerations with kubectl describe pod @kubernetes/rh-cluster-infra @kubernetes/kubectl <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30381) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update github.com/spf13/pflag and github.com/spf13/cobra Update github.com/spf13/pflag and github.com/spf13/cobra Update: github.com/spf13/cobra to f62e98d28ab7ad31d707ba837a966378465c7b57 github.com/spf13/cobra/doc to f62e98d28ab7ad31d707ba837a966378465c7b57 github.com/spf13/pflag to 1560c1005499d61b80f865c04d39ca7505bf7f0b Closes issue #29852 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/27855) <!-- Reviewable:end --> -
Kubernetes Submit Queue authored
Automatic merge from submit-queue kubelet: mark source ready after updating the cache This ensures that cleanup routines don't start until the cache content is up-to-date. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30417) <!-- Reviewable:end -->
-
Janet Kuo authored
-
Tim Hockin authored
I looked at a few other examples of templates and tried to make ours more succint and helpful. Feedback is welcome.
-
Dawn Chen authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Remove unversioned federation client, clientset and versioned release_1_3 clientset and all their accesses in e2e tests. Switch everything to federation release_1_4 external client. cc @kubernetes/sig-cluster-federation <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30397) <!-- Reviewable:end -->
-
Daniel Smith authored
-
Matt authored
-
Daniel Smith authored
-
Daniel Smith authored
-
Daniel Smith authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue HyperLink not found and can't redirect HyperLink "http://kubernetes.io/v1.1/docs/design/expansion.html" not found and can't redirected, should be changed to "http://kubernetes.io/kubernetes/v1.1/docs/design/expansion.html" <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/29609) <!-- Reviewable:end -->
-
- 11 Aug, 2016 4 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add Time Series Data and Labels in Node density test This pull requests contain: 1. Increase the pod creation latency limit according to test results; 2. Add 'GetResourceSeriesWithLabels' in 'resource_collector.go' to provide resource usage time series data; 3. Modify 'GetBasicCPUStats' in 'resource_collector.go' to make a copy of CPU usage array before sorting (otherwise time series data is disordered); 4. Add 'ResourceUsageToPerfDataWithLabels' and 'CPUUsageToPerfDataWithLabels' to attach labels to 'PerfData' for benchmark dashboard; <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30333) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add Lantao Liu as node e2e reviewer. Relieve pwittroc@ from node e2e maintenance <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30470) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add AppArmor validation logic The validation checks the prerequisites described in the [AppArmor proposal](https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/apparmor.md#prerequisites). In order to unblock the AppArmor implementation from waiting on the APIs to merge, this PR uses 2 helper stubs for handling the Pod API. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/29812) <!-- Reviewable:end -->
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Start verifying golint on a per-package basis as packages are fixed <!-- Checklist for submitting a Pull Request Please remove this comment block before submitting. 1. Please read our [contributor guidelines](https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md). 2. See our [developer guide](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md). 3. If you want this PR to automatically close an issue when it is merged, add `fixes #<issue number>` or `fixes #<issue number>, fixes #<issue number>` to close multiple issues (see: https://github.com/blog/1506-closing-issues-via-pull-requests). 4. Follow the instructions for [labeling and writing a release note for this PR](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes) in the block below. --> ```release-note Added `golint` for pkg/security/podsecuritypolicy/capabilities` along with validation. ``` []() This is a POC to start enabling `golint` checks on a per-package basis, we did this on the docker project and it was a great way for new contributors to help and it benefits the project overall. All they have to do is add the package they fixed to the bash array in `hack/verify-golint.sh` and fix all the lint errors. Eventually when all the packages have been fixed we can change the function to `find_files`. Or something based off which files are changed in a patch set to verify `golint`. Now I used this specific package as the POC because I wanted to show the downside of this changing the api of the package. Most of the times this arose in docker/docker we decided that if someone wasn't importing their deps locally then it was their loss, but I'm not sure if you all will agree. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.kubernetes.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/27911) <!-- Reviewable:end -->
-