- 03 Nov, 2017 40 commits
-
-
Mike Danese authored
-
Mike Danese authored
-
Mike Danese authored
-
Mike Danese authored
-
Mike Danese authored
-
Marcin Wielgus authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix panic in kubelet because of uninitialized map **What this PR does / why we need it**: Initialized the uninitialized map in kubelet **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes [#54927](https://github.com/kubernetes/kubernetes/issues/54927) **Special notes for your reviewer**: The default value of --enable-controller-attach-detach is true, map will be initialized like: ``` if kl.enableControllerAttachDetach { if node.Annotations == nil { node.Annotations = make(map[string]string) } ... } ``` if set --enable-controller-attach-detach to false, map will have no Initialized. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubelet: dockershim: remove orphaned checkpoint files Fixes https://github.com/kubernetes/kubernetes/issues/55070 Currently, `ListPodSandbox()` returns a combined list of sandboxes populated from both the runtime and the dockershim checkpoint files. However the sandboxes in the checkpoint files might not exist anymore. The kubelet sees the sandbox returned by `ListPodSandbox()` and determines it shouldn't be running and calls `StopPodSandbox()` on it. This generates an error when `StopContainer()` is called as the container does not exist. However the checkpoint file is not cleaned up. This leads to subsequent calls to `StopPodSandbox()` that fail in the same way each time. This PR removes the checkpoint file if StopContainer fails due to container not found. The only other place `RemoveCheckpoint()` is called, except if it is corrupt, is from `RemoveSandbox()`. If the container does not exist, what `RemoveSandbox()` would have done has been effectively been done already. So this is just clean up. @derekwaynecarr @eparis @freehan @dcbw
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update deletionTimestamp with information about finalizer effect **What this PR does / why we need it**: ref https://github.com/kubernetes/community/pull/1177 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # https://github.com/kubernetes/website/issues/6128 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55050, 53464, 54936, 55028, 54928). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. output empty creationTimestamp as null **Release note** ```release-note NONE ``` Updates the value of the `creationTimestamp` field to be `null` when empty, to keep parity between it and `deletionTimestamp`. Adds a round-trip test to ensure that unstructured objects containing empty metadata fields are able to be re-converted back into internal or external objects. Prior to the proposed patch in this PR, an unstructured object whose `.metadata.creationTimestamp` value had been set through the metadata accessor to an empty value (`metav1.Time{}` in this case), was unable to be re-converted to an internal or external type using the runtime decoder. Conversion would fail with the error: ``` unstructured_test.go:177: FromUnstructured failed: parsing time "" as "2006-01-02T15:04:05Z07:00": cannot parse "" as "2006" ``` cc @liggitt @fabianofranz
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove version check in kubectl e2e test. **What this PR does / why we need it**: We don't need to check these versions for kubectl e2e tests in current cycle. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: ref: #55053 **Special notes for your reviewer**: /cc @liggitt since you're also from sig-cli-maintainers :) **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51401, 54056, 54977, 55017, 55052). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. refactor admission handler and add UT **What this PR does / why we need it**: remove Redundant code, and add UT case. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51401, 54056, 54977, 55017, 55052). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. extensions: remove TPR remnants The extensions group still had the TPR types + generated client. Having this in the codebase doesn't create any problems but would be good to clean up, especially since TPR access has been removed in 1.8. **Release note**: ```release-note NONE ``` /assign @sttts @deads2k
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51401, 54056, 54977, 55017, 55052). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [test/e2e_node]Redirect dl.k8s.io to the kubernetes-release GCS bucket **What this PR does / why we need it**: fixes [#33726](https://github.com/kubernetes/kubernetes/pull/33726)Redirect dl.k8s.io to the kubernetes-release GCS bucket ref :[kubernetes/k8s.io#15](https://github.com/kubernetes/k8s.io/pull/15) **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51401, 54056, 54977, 55017, 55052). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix example and comments for kubectl convert Signed-off-by:
yuexiao-wang <wang.yuexiao@zte.com.cn> **What this PR does / why we need it**: There are some erros in example and comments in convert **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51401, 54056, 54977, 55017, 55052). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [cli] exit when Validate() returns an error cmdutil.UsageErrorf() does nothing but returna a string. When Validate() returns an error, we should call exit() function. fix: https://github.com/kubernetes/kubectl/issues/119 **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55063, 54523, 55053). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Don't need to check version for auth e2e test **What this PR does / why we need it**: In 1.9 cycle, some e2e test don't need to run against so older versions. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: ref: #55050 **Special notes for your reviewer**: /cc @tallclair @liggitt **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55063, 54523, 55053). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. unit tests for syncRolloutStatus in pkg/controller/deployment **What this PR does / why we need it**: Adds unit tests for syncRolloutStatus func in controller/deployment package. **Which issue this PR fixes**: fixes #53663 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix exported method run's comment **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51874, 54394). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. conversion-gen: cut off kube dependencies in extra-peer-dirs Fixes #54301 This makes conversion-gen usable in a context without a vendored k8s.io/kubernetes. ```release-note In conversion-gen removed Kubernetes core API from default extra-peer-dirs. ```
-
xiangpengzhao authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kube-proxy IPVS: Fix IPVS availability check **What this PR does / why we need it**: The current implementation of `CanUseIPVSProxier()` reads `/proc/modules` to check whether IPVS related kernel modules can be loaded. You might get a false-negative when the kernel modules are installed to the system but haven't been loaded into the kernel. This patch firstly try to run `modprobe` to load specified kernel modules, then just log warnings if error occured. Secondly, it will check loaded kernel modules by reading `/proc/modules`, return an error if any required module is missing. This change will not break the compatability of existing implementation. Running kube-proxy in a container without mounting `/lib/modules` will cause `modprobe` warnings, but not raise an error if all required modules are present in the host kernel. **Special notes for your reviewer**: **Release note**: ```release-note Fix IPVS availability check ```
-
xiangpengzhao authored
-
Nikhita Raghunath authored
-
Nikhita Raghunath authored
-
Nikhita Raghunath authored
-
Nikhita Raghunath authored
There are still TPR types and generated client in the extensions group. It is better to clean that up, now that it has been removed from master.
-
xiangpengzhao authored
-
chenpengdev authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove duplicate healthz check register **What this PR does / why we need it**: We registe healthz check twice, another is https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-controller-manager/app/controllermanager.go#L203 we should remove the duplicate one **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add scale down to 1 e2e test. This PR adds test checking scale to 1 functionality.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. make easy validation admission plugins into validators This switches "easy" admission plugins that need to be validators to be validators. I also did one simple plugin to do both mutation and validation for practice. @kubernetes/sig-api-machinery-pr-reviews @caesarxuchao
-
David Eads authored
-
Krzysztof Jastrzebski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Node autoprovisioning e2e test. This PR adds test scenario for cluster-autoscaler in GKE for node autoprovisioning.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove dependency on drv_cfg binary for querying ScaleIO devices **What this PR does / why we need it**: This PR fixes the issue where a ScleIO kubernetes plugin required additional binary `drv_cfg` to be present on the local node to work properly, making it harder for the kubelet binary to be containerized without providing access to local paths inside the container. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #54954 **Special notes for your reviewer**: **Release note**: ```release-note ScaleIO driver completely removes dependency on drv_cfg binary so a Kubernetes cluster can easily run a containerized kubelet. ```
-
xiangpengzhao authored
-
xiangpengzhao authored
-
hzxuzhonghu authored
-
xiangpengzhao authored
-