- 10 Jan, 2018 34 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 58025, 57112, 57879, 57571, 58062). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Let mutating webhook defaults the object ...after applying the patch sent back by the webhook This should be treated as a bug and cherrypicked to 1.9. Fixes #57982
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove options.md, which is outdated and doesn't contain any useful information xref #49213 ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix for local-up-cluster.sh bad cloud_config_arg Fixes #58086 Adding fix for bad arg in local-up-cluster.sh where cloud_config_param was invalid
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49874, 56919, 57246). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Enable support for etcd3 **What this PR does / why we need it**: With this PR juju deployments of kubernetes can use both etcd2 and 3. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: **Special notes for your reviewer**: Lets not merge this immediately. Lets wait for next year. **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49874, 56919, 57246). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. refactor getting uninitialized in kubectl get **What this PR does / why we need it**: remove leftover TODO to refactor getting uninitialized in kubectl get **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: /assign @smarterclayton **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49874, 56919, 57246). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Added nodeAffinity in validation error msg. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # N/A **Release note**: ```release-note NONE ```
-
Scott Creeley authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add volID based delete() and resize() if volID is available in pv spec.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55316, 57934). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Increase test coverage in `pkg/controllers/podautoscaler/metrics` **What this PR does / why we need it**: Increase test coverage for `pkg/controllers/podautoscaler/metrics`. The biggest addition is unit tests for `pkg/controller/podautoscaler/metrics/utilization.go`. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 55316, 57934). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make StatefulSet report an event when recreating failed pod When StatefulSet finds any of its pods in phase Failed it will delete it and create it again. While doing so it will emit delete+create event which is really confusing for the user as he has no idea what's happening. Fixes https://github.com/kubernetes/kubernetes/issues/58082
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix populateDesiredStateOfWorld bug for attach/detach controller **What this PR does / why we need it**: The `attachDetachController.populateDesiredStateOfWorld` mehod will fetch all pods from the informer cache and add each pods to `DesiredStateOfWorld` by the [addPod method](https://github.com/kubernetes/kubernetes/blob/da9a4d5da9ecc6f687c873fb990d662b1f9f98b2/pkg/controller/volume/attachdetach/attach_detach_controller.go#L338). However, the element type of pod list returned by `podLister.List` is already `*v1.Pod`, so we needn't to take the address any more. **Release note**: ```release-note NONE ``` /sig storage /kind bug
-
Humble Chirammal authored
Signed-off-by:Humble Chirammal <hchiramm@redhat.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make code generators log to stderr by default **What this PR does / why we need it**: Most code generators inside `staging/` are CLI tools. It makes sense for CLI tools (in general) to log to stdout/err, especially knowing that [`glog` has a 30sec flush interval](https://github.com/kubernetes/kubernetes/blob/a227c1ea2cb5e1bfee3a34362c225784f0bb4af7/pkg/kubectl/util/logs/logs.go#L49), which leads to logs being lost and makes troubleshooting tedious for people not aware of that quirk. Fixes #53791 ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. check function return err **What this PR does / why we need it**: check function return err **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. make controller port exposure optional Makes it possible to disable the http server part of controllers if a user wishes.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57581, 58030). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. cmd/kubectl: fix broken error formatting for run This patch adds missing value to a format string (%s) in --restart flag validation for "kubectl run". "kubectl run --restart=foo" was giving error: error: invalid restart policy: %!s(MISSING) Now it says: error: invalid restart policy: foo /release-note-none
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Updated Flexvolume setup mechanisms for COS instance image. - If REMOUNT_VOLUME_PLUGIN_DIR is set to true, VOLUME_PLUGIN_DIR is remounted with `exec` option during cluster startup. This allows any writable location to be used as the plugin directory. - New HostPath added to controller-manager deployment to enable access to volume plugin directory. - Improved how the default directory is passed to master and node setup. **What this PR does / why we need it**: Part of the fix for #57353 /release-note-none /sig storage /assign @saad-ali @roberthbailey /cc @chakri-nelluri @wongma7
-
Robert Bailey authored
useful information.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57733, 57613, 57953). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix device name change issue for azure disk: add remount logic **What this PR does / why we need it**: fix device name change issue for azure disk: add remount logic Accoding to [Troubleshoot Linux VM device name change](https://docs.microsoft.com/en-us/azure/virtual-machines/linux/troubleshoot-device-names-problems), there is possibility of device name change, so when kubelet is restarted, we need to check whether the following two paths are still valid: 1. `/var/lib/kubelet/plugins/kubernetes.io/azure-disk/mounts/m358246426`: in MountDevice func 2. `/var/lib/kubelet/pods/950f2eb8-d4e7-11e7-bc95-000d3a041274/volumes/kubernetes.io~azure-disk/pvc-67e4e319-d4e7-11e7-bc95-000d3a041274`: in SetUpAt func **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #57952 **Special notes for your reviewer**: this is a corresponding fix of https://github.com/kubernetes/kubernetes/pull/57549, #57549 uses '/dev/disk/by-id', and this PR would check whether the mountPath is valid when kubelet restart(e.g. after VM reboot since device name may change), if not valid, remount, remember '/dev/disk/by-id' will be always valid. **Release note**: ``` fix device name change issue for azure disk: add remount logic ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57733, 57613, 57953). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Explicit kubelet flags The Kubelet was using the global flag set. Libraries also often use the global flag set. There are flags in the Kubelet's usage statement for which the Kubelet does not control registration. This is bad, we must have full control of our command-line API. This PR puts a stop to it. I worked through the Kubelet's usage printout and tracked down the flags. In the below list, flags with checkboxes are one of: - explicitly **registered** in this PR - thought about and outright **rejected** - thought about and **registered-deprecated** for legacy reasons For the others we need to figure out whether they should be **registered** or **rejected** or **registered-deprecated**. ### cadvisor: grep commands, for reference: ``` # flag definitions in cadvisor git grep -E "\"application_metrics_count_limit\"|\"boot_id_file\"|\"container_hints\"|\"containerd\"|\"docker\"|\"docker_env_metadata_whitelist\"|\"docker_only\"|\"docker_root\"|\"docker-tls\"|\"docker-tls-ca\"|\"docker-tls-cert\"|\"docker-tls-key\"|\"enable_load_reader\"|\"event_storage_age_limit\"|\"event_storage_event_limit\"|\"global_housekeeping_interval\"|\"housekeeping_interval\"|\"log_cadvisor_usage\"|\"machine_id_file\"|\"storage_driver_buffer_duration\"|\"storage_driver_db\"|\"storage_driver_host\"|\"storage_driver_password\"|\"storage_driver_secure\"|\"storage_driver_table\"|\"storage_driver_user\"" -- vendor/github.com/google/cadvisor # flag invocations git grep -E "\--application_metrics_count_limit|--boot_id_file|--container_hints|--containerd|--docker|--docker_env_metadata_whitelist|--docker_only|--docker_root|--docker_tls|--docker_tls_ca|--docker_tls_cert|--docker_tls_key|--enable_load_reader|--event_storage_age_limit|--event_storage_event_limit|--global_housekeeping_interval|--housekeeping_interval|--log_cadvisor_usage|--machine_id_file|--storage_driver_buffer_duration|--storage_driver_db|--storage_driver_host|--storage_driver_password|--storage_driver_secure|--storage_driver_table|--storage_driver_user" -- ':(exclude)pkg/generated/bindata.go' ':(exclude)Godeps' ':(exclude)CHANGELOG*' ':(exclude)vendor' # normalized flag invocations git grep -E "\--application-metrics-count-limit|--boot-id-file|--container-hints|--containerd|--docker|--docker-env-metadata-whitelist|--docker-only|--docker-root|--docker-tls|--docker-tls-ca|--docker-tls-cert|--docker-tls-key|--enable-load-reader|--event-storage-age-limit|--event-storage-event-limit|--global-housekeeping-interval|--housekeeping-interval|--log-cadvisor-usage|--machine-id-file|--storage-driver-buffer-duration|--storage-driver-db|--storage-driver-host|--storage-driver-password|--storage-driver-secure|--storage-driver-table|--storage-driver-user" -- ':(exclude)pkg/generated/bindata.go' ':(exclude)Godeps' ':(exclude)CHANGELOG*' ':(exclude)vendor' # flag names git grep -E "application_metrics_count_limit|boot_id_file|container_hints|containerd|docker|docker_env_metadata_whitelist|docker_only|docker_root|docker_tls|docker_tls_ca|docker_tls_cert|docker_tls_key|enable_load_reader|event_storage_age_limit|event_storage_event_limit|global_housekeeping_interval|housekeeping_interval|log_cadvisor_usage|machine_id_file|storage_driver_buffer_duration|storage_driver_db|storage_driver_host|storage_driver_password|storage_driver_secure|storage_driver_table|storage_driver_user" ':(exclude)pkg/generated/bindata.go' ':(exclude)Godeps' ':(exclude)CHANGELOG*' ':(exclude)vendor' # normalized flag names git grep -E "application-metrics-count-limit|boot-id-file|container-hints|containerd|docker|docker-env-metadata-whitelist|docker-only|docker-root|docker-tls|docker-tls-ca|docker-tls-cert|docker-tls-key|enable-load-reader|event-storage-age-limit|event-storage-event-limit|global-housekeeping-interval|housekeeping-interval|log-cadvisor-usage|machine-id-file|storage-driver-buffer-duration|storage-driver-db|storage-driver-host|storage-driver-password|storage-driver-secure|storage-driver-table|storage-driver-user" ':(exclude)pkg/generated/bindata.go' ':(exclude)Godeps' ':(exclude)CHANGELOG*' ':(exclude)vendor' # normalized and underscore names combined git grep -E "application_metrics_count_limit|boot_id_file|container_hints|containerd|docker|docker_env_metadata_whitelist|docker_only|docker_root|docker_tls|docker_tls_ca|docker_tls_cert|docker_tls_key|enable_load_reader|event_storage_age_limit|event_storage_event_limit|global_housekeeping_interval|housekeeping_interval|log_cadvisor_usage|machine_id_file|storage_driver_buffer_duration|storage_driver_db|storage_driver_host|storage_driver_password|storage_driver_secure|storage_driver_table|storage_driver_user|application-metrics-count-limit|boot-id-file|container-hints|containerd|docker-env-metadata-whitelist|docker-only|docker-root|docker-tls|docker-tls-ca|docker-tls-cert|docker-tls-key|enable-load-reader|event-storage-age-limit|event-storage-event-limit|global-housekeeping-interval|housekeeping-interval|log-cadvisor-usage|machine-id-file|storage-driver-buffer-duration|storage-driver-db|storage-driver-host|storage-driver-password|storage-driver-secure|storage-driver-table|storage-driver-user" ':(exclude)pkg/generated/bindata.go' ':(exclude)Godeps' ':(exclude)CHANGELOG*' ':(exclude)vendor' ``` - [x] --docker-root (**registered** - this is used in `cluster/saltbase/salt/kubelet/default`) - [x] --housekeeping-interval (**registered** - e2e node tests rely on this (`test/e2e_node/resource_collector.go`)) - [x] --application-metrics-count-limit (**registered-deprecated** - temporarily register for legacy) - [x] --boot-id-file (**registered-deprecated** - temporarily register for legacy) - [x] --container-hints (**registered-deprecated** - temporarily register for legacy) - [x] --containerd (**registered-deprecated** - temporarily register for legacy) - [x] --docker (**registered-deprecated** - temporarily register for legacy) - [x] --docker-env-metadata-whitelist (**registered-deprecated** - temporarily register for legacy) - [x] --docker-only (**registered-deprecated** - temporarily register for legacy) - [x] --docker-tls (**registered-deprecated** - temporarily register for legacy) - [x] --docker-tls-ca (**registered-deprecated** - temporarily register for legacy) - [x] --docker-tls-cert (**registered-deprecated** - temporarily register for legacy) - [x] --docker-tls-key (**registered-deprecated** - temporarily register for legacy) - [x] --enable-load-reader (**registered-deprecated** - temporarily register for legacy) - [x] --event-storage-age-limit (**registered-deprecated** - the Kubelet overrides the default via the global flagset (`pkg/kubelet/cadvisor/cadvisor_linux.go`), but nothing else in core repo provides) - [x] --event-storage-event-limit (**registered-deprecated** - the Kubelet overrides the default via the global flagset (`pkg/kubelet/cadvisor/cadvisor_linux.go`), but nothing else in core repo provides) - [x] --global-housekeeping-interval (**registered-deprecated** - temporarily register for legacy) - [x] --log-cadvisor-usage (**registered-deprecated** - temporarily register for legacy) - [x] --machine-id-file (**registered-deprecated** - temporarily register for legacy) - [x] --storage-driver-user (**registered-deprecated** - temporarily register for legacy) - [x] --storage-driver-password (**registered-deprecated** - temporarily register for legacy) - [x] --storage-driver-host (**registered-deprecated** - temporarily register for legacy) - [x] --storage-driver-db (**registered-deprecated** - temporarily register for legacy) - [x] --storage-driver-table (**registered-deprecated** - temporarily register for legacy) - [x] --storage-driver-secure (**registered-deprecated** - temporarily register for legacy) - [x] --storage-driver-buffer-duration (**registered-deprecated** - temporarily register for legacy) ### pkg/apiserver/util/logs: - [x] --log-flush-frequency (**registered** - like the glog flags, this is probably useful) ### pkg/credentialprovider/azure/azure_credentials.go: - [x] --azure-container-registry-config (**registered** - This isn't quite as straightforward as --google-json-key, because the file it points to isn't static. For now we will just register, and we will deprecate it when there is an alternative. See below comments.) ### pkg/credentialprovider/gcp/jwt.go: - [x] --google-json-key (**registered-deprecated** - This is really old legacy stuff to allow kubelets to authenticate with gcr (see: d5e0054e). See @liggit's below comment for what should be used instead.) ### pkg/cloudprovider/providers/gce/gce_loadbalancer.go: - [x] --cloud-provider-gce-lb-src-cidrs (**rejected** - Kubelet doesn't need to know about the cidrs that were opened in the firewall for the load balancer) ### glog: I registered all of these, since this logging library is used pretty much everywhere in the Kubelet, and all of its toggles are probably useful. - [x] --logtostderr (**registered**) - [x] --alsologtostderr (**registered**) - [x] -v, --v (**registered**) - [x] --stderrthreshold (**registered**) - [x] --vmodule (**registered**) - [x] --log-backtrace-at (**registered**) - [x] --log-dir (**registered**) ### verflag: This is how you get the Kubelet's version, absolutely necessary to register this. - [x] --version (**registered**) ```release-note The Kubelet now explicitly registers all of its command-line flags with an internal flagset, which prevents flags from third party libraries from unintentionally leaking into the Kubelet's command-line API. Many unintentionally leaked flags are now marked deprecated, so that users have a chance to migrate away from them before they are removed. One previously leaked flag, --cloud-provider-gce-lb-src-cidrs, was entirely removed from the Kubelet's command-line API, because it is irrelevant to Kubelet operation. ``` Thanks to @liggitt for being surprised that we didn't already do this. Thanks to @dashpole for realizing cadvisor flags were leaked after seeing #55863. Thanks to @tallclair who recognized this problem a long time ago in #19432.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57733, 57613, 57953). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [eviction manager]fix type error **What this PR does / why we need it**: It should not wrong hint messages when create memory threshold notifier failed **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57993, 58028). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove aws from the cluster/ directory. xref #49213 ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57993, 58028). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add volumemetrics for glusterfs plugin. Signed-off-by:
Humble Chirammal <hchiramm@redhat.com> **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. dockershim: bump the minimum supported docker version to 1.11 Drop the 1.10 compatibilty code. **Release note**: ```release-note NONE ```
-
Michael Taufen authored
This explicitly registers Kubelet flags from libraries that were registering flags globally, and stops parsing the global flag set. In general, we should always be explicit about flags we register and parse, so that we maintain control over our command-line API.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove the empty vsphere directory from cluster/ xref #49213 ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Node e2e non docker specific Fixes https://github.com/kubernetes/kubernetes/issues/57977. Make node e2e test generic to container runtimes. With this change, other than tests with `[Feature:Docker]`, all tests can run against all CRI container runtimes. Note that this PR also marks cpu manager test as `Serial`, because it restarts kubelet during the test. It doesn't cause problem in regular node e2e suite today, because it is skipped if node has less than 2 CPUs, which is the case for our test environment. /cc @balajismaniam @yujuhong @mrunalp @feiskyer /cc @dashpole @balajismaniam @bprashanth Because I addressed your comments. /cc @kubernetes/sig-node-pr-reviews **Release note**: ```release-note none ```
-
Ahmet Alp Balkan authored
This patch adds missing value to a format string (%s) in --restart flag validation for "kubectl run". "kubectl run --restart=foo" was giving error: error: invalid restart policy: %!s(MISSING) Now it says: error: invalid restart policy: foo Signed-off-by:Ahmet Alp Balkan <ahmetb@google.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57919, 58021, 58020, 58023). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. removed deprecated libvirt-coreos kube-up/ from cluster This kube-up hasn't been maintained for over a year and has been deprecated for > 6 months. see #49213 @kubernetes/sig-cluster-lifecycle-pr-reviews ```release-note Remove deprecated and unmaintained libvirt-coreos kube-up.sh. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57919, 58021, 58020, 58023). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. removed deprecated windows install script from cluster Hasn't been touched in over a year. see #49213 @kubernetes/sig-cluster-lifecycle-pr-reviews ```release-note Remove deprecated and unmaintained windows installer. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57919, 58021, 58020, 58023). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove deprecated openstack heat this directory hasn't been touched in a year. see #49213 @kubernetes/sig-cluster-lifecycle-pr-reviews ```release-note Remove deprecated and unmaintained openstack-heat kube-up.sh. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57919, 58021, 58020, 58023). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add GCE "Custom" folder **What this PR does / why we need it**: Allows creating clusters with image type custom **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` This will need to be cherrypicked back to the 1.9 branch /assign @dchen1107 @yguo0905
-
Robert Bailey authored
-
Robert Bailey authored
-
- 09 Jan, 2018 6 commits
-
-
Chao Xu authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57511, 57978). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Renews cached NodeInfo with new vSphere connection **What this PR does / why we need it**: This PR modifies two public functions of nodemanager.go- GetNodeInfo and GetNodeDetails. For both these functions NodeInfo object is renewed with new GoVmomiClient and new vclib VirtualMachine and Datacenter. **Which issue(s) this PR fixes** : Fixes vmware#404 **Special notes for your reviewer**: Code has been structured to minimize impact on existing 1.9 release code and any side-effects due to NodeInfo modification. This is a quick solution for vSphere connection renewal problem. A more enhanced solution is target for upcoming major release. Testing: - [x] Successfully tried out pod creation, deletion with dynamic volume. - [x] Successfully ran e2e tests. **Release note**: ```release-note Fixes authentication problem faced during various vSphere operations. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57511, 57978). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Small improvement of showKind get **What this PR does / why we need it**: Given the complexity of determining whether to show resource with kind, this PR will be a small improvement when with `--show-kind=true`. There's no need to waste time to run the complex logic if we already decided to show resource with kind. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Lantao Liu authored
-
Lantao Liu authored
-
Mike Danese authored
see #49213
-