1. 04 Aug, 2017 1 commit
  2. 02 Aug, 2017 28 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #49886 from ironcladlou/int-test-logging · dd819b50
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49992, 48861, 49267, 49356, 49886)
      
      Set default vmodule flag in integration tests
      
      Re-introduce a default glog vmodule flag to the integration test setup.
      The default was removed in d08dfb92 because it was hard-coded and
      prevented local override. This commit makes the default overridable.
      
      ```release-note
      NONE
      ```
      
      /cc @caesarxuchao
      dd819b50
    • Kubernetes Submit Queue's avatar
      Merge pull request #49356 from duan-yue/code_clear · 1dd7faca
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49992, 48861, 49267, 49356, 49886)
      
      remove unused function
      
      **What this PR does / why we need it**:
      remove unused function which is not used months ago.
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      1dd7faca
    • Kubernetes Submit Queue's avatar
      Merge pull request #49267 from MrHohn/kube-proxy-abort-when-healthz-fails · acc00afe
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49992, 48861, 49267, 49356, 49886)
      
      Emit event and retry when fail to start healthz server on kube-proxy
      
      **What this PR does / why we need it**: Enhance kube-proxy's logic when fail to start healthz server.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: From #49263.
      
      **Special notes for your reviewer**:
      /assign @thockin @nicksardo @bowei 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      acc00afe
    • Kubernetes Submit Queue's avatar
      Merge pull request #48861 from mbohlool/openapi_aggr · 9067d359
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49992, 48861, 49267, 49356, 49886)
      
      Reintegrate aggregation support for OpenAPI
      
      Reintegrating changes of #46734
      
      Changes summary:
      
      - Extracted all OpenAPI specs to new repo `kube-openapi`
      - Make OpenAPI spec aggregator to copy and rename any non-requal model (even with documentation change only).
      - Load specs when adding APIServices and retry on failure until successful spec retrieval or a 404.
      - Assumes all Specs except aggregator's Spec are static 
      - A re-register of any APIService will result in updating the spec for that service (Suggestion for TPR: they should be registered to aggregator API Server, Open for discussion if any more changes needed for another PR.)
      
      fixes #48548
      9067d359
    • Kubernetes Submit Queue's avatar
      Merge pull request #49992 from liggitt/debug-flake · 35c3a51e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49992, 48861, 49267, 49356, 49886)
      
      Correctly handle empty watch event cache
      
      Fixes https://github.com/kubernetes/kubernetes/issues/49956
      
      Introduced by https://github.com/kubernetes/kubernetes/commit/ada60236f70c31dfa8fd8b5799cae12ab44d3e36 which did not adjust the oldest available resourceVersion for an empty watch event cache.
      
      Exposed by https://github.com/kubernetes/kubernetes/commit/74b9ba3b4d7c6f0a116464ac01a5f98b915d4586, which allowed controllers to get list results from etcd before the watch cache is ready (normally they list with resourceVersion=0 which serves the list request from the watch cache, blocking until it is ready)
      
      When the watch cache had an empty cache of watch events, it currently allows establishing a watch as if it can deliver a watch event for its currently synced resourceVersion. This results in an off-by-one error which can result in a missed watch event.
      
      Scenario:
      
      bob:
      1. creates object at resourceVersion=11
      
      sally:
      1. does a list API request, gets a list resourceVersion of 10 (just before bob creates the object)
      2. starts watch handled by watch cache at resourceVersion=10
      
      Watch cache:
      1. initial list gets resourceVersion=11, including the item created by bob
      2. when determining the initial watch events to send to sally's watch, there are no watch events in the cache, so no initial watch events are sent.
      3. the cache listerwatcher watches etcd starting at resourceVersion=11, so future events are fed into the event cache and to sally's watch
      
      The watch cache should have dropped sally's watch from resourceVersion=10 with a "gone" error, since it can't deliver the watch event for resourceVersion=11. This would force sally to relist (where she would get a list at resourceVersion=11) and rewatch (from resourceVersion=11)
      
      This particularly affects tests that create CRD/TPRs and establish watches on the new types as the storage layer's watch cache is also populating for that type.
      
      ```release-note
      Fix a bug in watch cache sometimes causing missing events after watch cache initialization.
      ```
      35c3a51e
    • Kubernetes Submit Queue's avatar
      Merge pull request #48429 from shyamjvs/parallel-upgrade · e9617b69
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add parallelism to GCE cluster upgrade
      
      Fixes https://github.com/kubernetes/kubernetes/issues/48373
      Should allow upgrading 500-node cluster (1.6->1.7) in < 1 hr. It currently takes ~1.5 day.
      Though it is the duty of the upgrader to choose the right parallelism in order to avoid disrupting too many pods.
      
      /cc @kubernetes/sig-cluster-lifecycle-pr-reviews @kubernetes/sig-scalability-misc @mikedanese @gmarek
      e9617b69
    • Kubernetes Submit Queue's avatar
      Merge pull request #49940 from shyamjvs/logdump-rocks · 0a5ac4e7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Don't stop log-dumping if logexporter fails
      
      Just noticed.
      
      Ref https://github.com/kubernetes/kubernetes/issues/48513
      0a5ac4e7
    • Kubernetes Submit Queue's avatar
      Merge pull request #48999 from vladimirvivien/scaleio-vol-attribs-update · 0cb5ec75
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49871, 49422, 49092, 49858, 48999)
      
      ScaleIO Volume Plugin - Volume attribute fixes and updates
      
      **What this PR does / why we need it**:
      This is a housekeeping PR for small enhancements and fixes to the ScaleIO volume plugin to address issues:
      - Enforcement of fsGroup
      - Enable ScaleIO multiple-instance volume mapping
      - Tighter validation of PVC parameters
      - Injection of default PVC capacity when omitted
      - Better alignment of PVC, PV, and volume names for dynamic provisioning
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Enforcement of fsGroup; enable ScaleIO multiple-instance volume mapping; default PVC capacity; alignment of PVC, PV, and volume names for dynamic provisioning
      ```
      0cb5ec75
    • Kubernetes Submit Queue's avatar
      Merge pull request #49858 from smarterclayton/openapi_perf · ba118b40
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49871, 49422, 49092, 49858, 48999)
      
      bump(github.com/googleapis/gnostic):0c5108395e2de
      
      Pick up performance improvements to OpenAPI serialization.
      
      Fixes #49776
      ba118b40
    • Kubernetes Submit Queue's avatar
      Merge pull request #49092 from huangjiuyuan/fix-apiserver-option-test · f33297d5
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49871, 49422, 49092, 49858, 48999)
      
      adding kube-apiserver starting option tests
      
      **What this PR does / why we need it**:
      There is only one test for `--enable-swagger-ui` option in `cmd/kube-apiserver/app/options/options_test.go`, I have expanded this test with more kube-apiserver starting options.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      `NONE`
      f33297d5
    • Kubernetes Submit Queue's avatar
      Merge pull request #49422 from crassirostris/logging-e2e-refactoring · 39736051
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49871, 49422, 49092, 49858, 48999)
      
      Refactor logging e2e tests, add new checks
      
      I split existing code into smaller files to simplify the review and future changes
      
      Also, there are new tests for stackdriver logging:
      - ingesting system logs from all nodes
      - ingesting logs in json format
      - ingesting logs in glog format
      39736051
    • Kubernetes Submit Queue's avatar
      Merge pull request #49871 from xiangpengzhao/fix-make · 5d4d422b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49871, 49422, 49092, 49858, 48999)
      
      Add KUBE_COVER help to "make test"
      
      **What this PR does / why we need it**:
      Add help info on `KUBE_COVER` to tell contributors how to run test with code coverage.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      /sig contributor-experience
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      5d4d422b
    • Kubernetes Submit Queue's avatar
      Merge pull request #47828 from yiqinguo/yiqinguo_add_continue · 5bb42cbc
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      If error continue for loop
      
      If err does not add continue, type conversion will be error.
      If do not add continue, pod. (* V1.Pod) may cause panic to run.
      **Release note**:
      ```release-note
      NONE
      ```
      5bb42cbc
    • mbohlool's avatar
      10d9a475
    • Kubernetes Submit Queue's avatar
      Merge pull request #49991 from mikedanese/fix-owner · 5ec7701c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      rename OWNER to OWNERS
      5ec7701c
    • Kubernetes Submit Queue's avatar
      Merge pull request #49888 from MrHohn/addon-manager-remove-old-codes · a4221961
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      [addon-manager] Remove unneeded annotation codes
      
      **What this PR does / why we need it**:
      Clean up addon-manager codes to make it less confusing. The annotation logics is only needed for 1.4->1.5 upgrade.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      a4221961
    • Kubernetes Submit Queue's avatar
      Merge pull request #49908 from freehan/cloud-provider-fix · bcc43f8f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49870, 49416, 49872, 49892, 49908)
      
      fix alpha/beta endpoint when api endpoint is specified
      
      fix a bug in alpha/beta compute API endpoint bootstraping when api-endpiont is specified. 
      
      ```release-note
      None
      ```
      bcc43f8f
    • Kubernetes Submit Queue's avatar
      Merge pull request #49892 from mikedanese/rpms · 55d314a8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49870, 49416, 49872, 49892, 49908)
      
      kubeadm: make rpm use --bootstrap-kubeconfig
      
      Missed this in https://github.com/kubernetes/kubernetes/pull/49681
      55d314a8
    • Kubernetes Submit Queue's avatar
      Merge pull request #49872 from xiangpengzhao/fix-kubeadm-ver · 58e8c3e2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49870, 49416, 49872, 49892, 49908)
      
      Make "kubeadm version" json format output more readable.
      
      **What this PR does / why we need it**:
      Add indent to json format output.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      ref: #43750 #46598
      
      **Special notes for your reviewer**:
      output example:
      ```
      #kubeadm version -o json
      {
        "clientVersion": {
          "major": "1",
          "minor": "8+",
          "gitVersion": "v1.8.0-alpha.2.1026+d8205661-dirty",
          "gitCommit": "d8205661",
          "gitTreeState": "dirty",
          "buildDate": "2017-07-31T12:14:28Z",
          "goVersion": "go1.8.3",
          "compiler": "gc",
          "platform": "linux/amd64"
        }
      }
      ```
      
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      58e8c3e2
    • Kubernetes Submit Queue's avatar
      Merge pull request #49416 from mtanino/issue/49392 · 2672f1cd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49870, 49416, 49872, 49892, 49908)
      
      FC volume plugin: remove block device at DetachDisk
      
      **What this PR does / why we need it**:
      
      After a volume is unmounted from pod and worker node, and then PV and PVC are deleted, cluster admin or external-provisioner might delete the disk from storage, therefore block device on the node should be cleaned up beforehand.
      
      The photon volume plugin already has same functionality.
      
      **Which issue this PR fixes**: fixes #49392
      
      **Special notes for your reviewer**:
      
      /assign @rootfs  
      /cc @jsafrane @saad-ali 
      
      **Release note**:
      
      ```
      NONE
      ```
      2672f1cd
    • Kubernetes Submit Queue's avatar
      Merge pull request #49870 from k82cn/nc_rename_zone_tainer · 455d85a9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49870, 49416, 49872, 49892, 49908)
      
      Renamed zoneNotReadyOrUnreachableTainer to zoneNoExecuteTainer.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: partially fixes #42001 
      
      **Release note**:
      
      ```release-note
      None
      ```
      455d85a9
    • Jordan Liggitt's avatar
      Correctly handle empty watch event cache · 0df769f5
      Jordan Liggitt authored
      0df769f5
    • Kubernetes Submit Queue's avatar
      Merge pull request #49491 from eparis/make-plus-append-is-bad · 23bb7654
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49898, 49897, 49919, 48860, 49491)
      
      Fix usage a make(struct, len()) followed by append()
      
      A couple of places in the code we allocate with make() but then use
      append(), instead of copy() or direct assignment. This results in a
      slice with len() zero elements at the front followed by the expected
      data. The correct form for such usage is `make(struct, 0, len())`.
      
      I found these by running:
      ```
      $ git grep -EI -A7 'make\([^,]*, len\(' | grep 'append(' -B7 | grep -v vendor
      ```
      And then manually looking through the results. I'm sure something better
      could exist.
      
      **Release note**:
      ```release-note
      NONE
      ```
      23bb7654
    • Kubernetes Submit Queue's avatar
      Merge pull request #48860 from ddysher/local-volume-e2e · bcb78ad1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49898, 49897, 49919, 48860, 49491)
      
      Add basic local volume provisioner e2e tests
      
      **What this PR does / why we need it**:
      Adds e2e tests to test local volume provisioner.
      
      **Which issue this PR fixes**: fixes https://github.com/kubernetes/kubernetes/issues/48832
      
      **Special notes for your reviewer**:
      - bring up local volume provisioner using bootstrapper
      - have provisioner create a volume by creating a directory under discovery path.  
      - check persistent volume is created
      - make a claim on the PV, write some data then delete the claim. Verify volume is cleaned up.
      
      **Release note**:
      
      ```release-note
      ```
      
      @ianchakeres @msau42
      bcb78ad1
    • Kubernetes Submit Queue's avatar
      Merge pull request #49919 from liggitt/deconflict-reflector · f5b4f9a0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49898, 49897, 49919, 48860, 49491)
      
      Fix duplicate metrics collector registration attempted error
      
      Fixes "duplicate metrics collector registration attempted" error seen in https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/batch/pull-kubernetes-unit/43931/
      f5b4f9a0
    • Kubernetes Submit Queue's avatar
      Merge pull request #49897 from mikedanese/atomic-append · 49955b15
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49898, 49897, 49919, 48860, 49491)
      
      gce: make append_or_replace.. atomic
      
      Before this change,
      * the final echo is not atomically written to the target file
      * two concurrent callers will use the same tempfile
      
      Helps with https://github.com/kubernetes/kubernetes/issues/49895
      
      cc @miekg
      49955b15
    • Kubernetes Submit Queue's avatar
      Merge pull request #49898 from mikedanese/clober-tokens · d79c8fe4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49898, 49897, 49919, 48860, 49491)
      
      gce: extend CLOBBER_CONFIG to support known_tokens.csv
      
      Helps with #49895
      d79c8fe4
    • Mike Danese's avatar
      rename OWNER to OWNERS · 780e0eae
      Mike Danese authored
      780e0eae
  3. 01 Aug, 2017 11 commits