• Kubernetes Submit Queue's avatar
    Merge pull request #49491 from eparis/make-plus-append-is-bad · 23bb7654
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 49898, 49897, 49919, 48860, 49491)
    
    Fix usage a make(struct, len()) followed by append()
    
    A couple of places in the code we allocate with make() but then use
    append(), instead of copy() or direct assignment. This results in a
    slice with len() zero elements at the front followed by the expected
    data. The correct form for such usage is `make(struct, 0, len())`.
    
    I found these by running:
    ```
    $ git grep -EI -A7 'make\([^,]*, len\(' | grep 'append(' -B7 | grep -v vendor
    ```
    And then manually looking through the results. I'm sure something better
    could exist.
    
    **Release note**:
    ```release-note
    NONE
    ```
    23bb7654
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
translations Loading commit data...
vendor Loading commit data...
.bazelrc Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.kazelcfg.json Loading commit data...
BUILD.bazel Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
Vagrantfile Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...