1. 08 Jun, 2017 3 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #46630 from danwinship/networkpolicy-test-v1 · 551d01c1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45877, 46846, 46630, 46087, 47003)
      
      update NetworkPolicy e2e test for v1 semantics
      
      This makes the NetworkPolicy test at least correct for v1, although ideally we'll eventually add a few more tests... (So this covers about half of #46625.)
      
      I've tested that this compiles, but not that it passes, since I don't have a v1-compatible NetworkPolicy implementation yet...
      
      @caseydavenport @ozdanborne, maybe you're closer to having a testable plugin than I am?
      
      **Release note**:
      ```release-note
      NONE
      ```
      551d01c1
    • Kubernetes Submit Queue's avatar
      Merge pull request #46846 from carlory/fix · 9567a4df
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45877, 46846, 46630, 46087, 47003)
      
      func parseEndpointWithFallbackProtocol should check if protocol of endpoint is empty
      
      **What this PR does / why we need it**:
      func parseEndpointWithFallbackProtocol should check if protocol of endpoint is empty
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: part of #45927
      NONE
      **Special notes for your reviewer**:
      NONE
      **Release note**:
      
      ```release-note
      NONE
      ```
      9567a4df
    • Kubernetes Submit Queue's avatar
      Merge pull request #45877 from zhangxiaoyu-zidif/add-ut-for-test-podlist · 41f6f9dd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45877, 46846, 46630, 46087, 47003)
      
      add Unit Test for PodList Printer
      Signed-off-by: 's avatarzhangxiaoyu-zidif <zhang.xiaoyu33@zte.com.cn>
      
      
      
      **What this PR does / why we need it**:
      add Unit Test for PodList Printer
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      41f6f9dd
  2. 07 Jun, 2017 37 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #47013 from smarterclayton/fix_printer · 49866b86
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47024, 47050, 47086, 47081, 47013)
      
      Wrap HumanReadablePrinter in tab output unless explicitly asked not to
      
      `kubectl get` was not properly aligning its output due to #40848 
      
      Fixes an accidental regression. In general, we should not accept an incoming tabwriter and instead manage at a higher level. Fix the bug and add a comment re: future refactoring.
      49866b86
    • Kubernetes Submit Queue's avatar
      Merge pull request #47081 from luxas/kubeadm_postinst_idempotency · 7e0c9e79
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47024, 47050, 47086, 47081, 47013)
      
      kubeadm: Make the creation of the RBAC rules phase idempotent
      
      **What this PR does / why we need it**:
      
      Bugfix: Currently kubeadm fails with a non-zero code if resources it's trying to create already exist. This PR fixes that by making kubeadm try to Update resources that already exist.
      
      After this PR, https://github.com/kubernetes/kubernetes/pull/46879 and a beta.1 release, kubeadm will be fully upgradeable from v1.6 to v1.7 using only kubeadm init.
      
      Last piece of https://github.com/kubernetes/kubeadm/issues/288
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      Fixes: https://github.com/kubernetes/kubeadm/issues/288
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      kubeadm: Modifications to cluster-internal resources installed by kubeadm will be overwritten when upgrading from v1.6 to v1.7.
      ```
      @pipejakob @mikedanese @timothysc
      7e0c9e79
    • Kubernetes Submit Queue's avatar
      Merge pull request #47086 from enisoc/crd-namespace-cleanup · 20bf5f23
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47024, 47050, 47086, 47081, 47013)
      
      apiextensions-apiserver: Fix decoding of DeleteOptions.
      
      Fixes #47072 by making apiextensions-apiserver capable of decoding unversioned DeleteOptions, rather than only handling Unstructured objects (i.e. Custom Resources).
      
      This also closes #46736 and #37554 since the added regression test works for TPR as well.
      20bf5f23
    • Kubernetes Submit Queue's avatar
      Merge pull request #47050 from sttts/sttts-deprecate-tpr-example · 43295501
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47024, 47050, 47086, 47081, 47013)
      
      client-go: deprecate TPR example and add CRD example
      
      /cc @nilebox
      
      Part of https://github.com/kubernetes/kubernetes/issues/46702
      43295501
    • Kubernetes Submit Queue's avatar
      Merge pull request #47024 from CaoShuFeng/legacy_hijack · 507ca732
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      [legacy audit] add response audit for hijack
      
      Fixes #47097
      **Release note**:
      
      ```
      NONE
      ```
      507ca732
    • Kubernetes Submit Queue's avatar
      Merge pull request #47136 from smarterclayton/skip_on_not_found · 8f4aacf6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Skip dynamic configuration of initializers test on alpha disable
      
      Fixes #47133
      8f4aacf6
    • Kubernetes Submit Queue's avatar
      Merge pull request #47103 from madhusudancs/fed-ds-uncheck-label · b8b5c68c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43005, 46660, 46385, 46991, 47103)
      
      Ignore `daemonset-controller-hash` label key in federation before comparing the federated object with its cluster equivalent.
      
      Kubernetes daemonset controller writes a daemonset's hash to the object label as an optimization to avoid recomputing it every time. Adding a new label to the object that the federation is unaware of causes problems because federated controllers compare the objects in federation and their equivalents in clusters and try to reconcile them. This leads to a constant fight between the federated daemonset
      controller and the cluster controllers, and they never reach a stable state.
      
      Ideally, cluster components should not update an object's spec or metadata in a way federation cannot replicate. They can update an object's status though. Therefore, this daemonset hash should be a
      field in daemonset's status, not a label in object meta. @janetkuo says that this label is only a short term solution. In the near future, they are going to replace it with revision numbers in daemonset status. We
      can then rip this bandaid out.
      
      Fixes #46925
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      /assign @csbell 
      
      /cc @shashidharatd @marun @nikhiljindal @perotinus 
      
      /sig federation
      b8b5c68c
    • Kubernetes Submit Queue's avatar
      Merge pull request #46991 from MrHohn/defer-deleteStaticIP-before-assert · 24f958d4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43005, 46660, 46385, 46991, 47103)
      
      [gke-slow always fails] Defer DeleteGCEStaticIP before asserting error
      
      From https://github.com/kubernetes/kubernetes/issues/46918.
      
      I'm getting close to the root cause: During tests, CreateGCEStaticIP() in fact successfully created static IP, but the parser we wrote in test mistakenly think we failed, probably because the gcloud output format was changed recently (or not). I'm still looking into fixing that.
      
      This PR defer the delete function before asserting the error so that we can stop consistently leaking static IP in every run.
      
      /assign @krzyzacy @dchen1107 
      
      ```release-note
      NONE
      ```
      24f958d4
    • Kubernetes Submit Queue's avatar
      Merge pull request #46385 from rickypai/rpai/host_mapping_node_e2e_test · 6ee02824
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43005, 46660, 46385, 46991, 47103)
      
      add e2e node test for Pod hostAliases feature
      
      **What this PR does / why we need it**: adds node e2e test for #45148 
      
      tests requested in https://github.com/kubernetes/kubernetes/issues/43632#issuecomment-298434125
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      @yujuhong @thockin
      6ee02824
    • Kubernetes Submit Queue's avatar
      Merge pull request #46660 from jackfrancis/azure-cloudprovider-backoff · 3adb9b42
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43005, 46660, 46385, 46991, 47103)
      
      Azure cloudprovider retry using flowcontrol
      
      An initial attempt at engaging exponential backoff for API error responses.
      
      Addresses #47048
      
      Uses k8s.io/client-go/util/flowcontrol; implementation inspired by GCE
      cloudprovider backoff.
      
      
      
      **What this PR does / why we need it**:
      
      The existing azure cloudprovider implementation has no guard rails in place to adapt to unexpected underlying operational conditions (i.e., clogs in resource plumbing between k8s runtime and the cloud API). The purpose of these changes is to support exponential backoff wrapping around API calls; and to support targeted rate limiting. Both of these options are configurable via `--cloud-config`.
      
      Implementation inspired by the GCE's use of `k8s.io/client-go/util/flowcontrol` and `k8s.io/apimachinery/pkg/util/wait`, this PR likewise uses `flowcontrol` for rate limiting; and `wait` to thinly wrap backoff retry attempts to the API.
      
      **Special notes for your reviewer**:
      
      
      Pay especial note to the declaration of retry-able conditions from an unsuccessful HTTP request:
      - all `4xx` and `5xx` HTTP responses
      - non-nil error responses
      
      And the declaration of retry success conditions:
      - `2xx` HTTP responses
      
      Tests updated to include additions to `Config`.
      
      Those may be incomplete, or in other ways non-representative.
      
      **Release note**:
      
      ```release-note
      Added exponential backoff to Azure cloudprovider
      ```
      3adb9b42
    • Kubernetes Submit Queue's avatar
      Merge pull request #43005 from cmluciano/cml/consolidatesysctl · 69342bd1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 43005, 46660, 46385, 46991, 47103)
      
      Consolidate sysctl commands for kubelet
      
      **What this PR does / why we need it**:
      These commands are important enough to be in the Kubelet itself.
      By default, Ubuntu 14.04 and Debian Jessie have these set to 200 and
      20000. Without this setting, nodes are limited in the number of
      containers that they can start.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #26005 
      
      **Special notes for your reviewer**:
      I had a difficult time writing tests for this. It is trivial to create a fake sysctl for testing, but the Kubelet does not have any tests for the prior settings.
      **Release note**:
      
      ```release-note
      ```
      69342bd1
    • Kubernetes Submit Queue's avatar
      Merge pull request #47088 from mikedanese/integration-race · 783b940c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      enable race detection on integration tests
      
      Fix an old TODO
      783b940c
    • Clayton Coleman's avatar
    • Madhusudan.C.S's avatar
      Ignore `daemonset-controller-hash` label key in federation before comparing the… · 3530c9ce
      Madhusudan.C.S authored
      Ignore `daemonset-controller-hash` label key in federation before comparing the federated object with its cluster equivalent.
      
      Kubernetes daemonset controller writes a daemonset's hash to the object
      label as an optimization to avoid recomputing it every time. Adding a
      new label to the object that the federation is unaware of causes
      problems because federated controllers compare the objects in
      federation and their equivalents in clusters and try to reconcile them.
      This leads to a constant fight between the federated daemonset
      controller and the cluster controllers, and they never reach a stable
      state.
      
      Ideally, cluster components should not update an object's spec or
      metadata in a way federation cannot replicate. They can update an
      object's status though. Therefore, this daemonset hash should be a
      field in daemonset's status, not a label in object meta. @janetkuo says
      that this label is only a short term solution. In the near future, they
      are going to replace it with revision numbers in daemonset status. We
      can then rip this bandaid out.
      3530c9ce
    • Kubernetes Submit Queue's avatar
      Merge pull request #46120 from shashidharatd/federation-service-e2e-1 · 33579467
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Federation: create loadbalancer service in tests only if test depends on it
      
      **What this PR does / why we need it**:
      Creating LoadBalancer type of service for every test case is kind of expensive and time consuming to provision. So this PR changes the test cases to use LoadBalancer type services only when necessary.
      
      **Which issue this PR fixes** (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #47068 
      
      **Release note**:
      ```release-note
      NONE
      ```
      cc @kubernetes/sig-federation-pr-reviews 
      /assign @madhusudancs
      33579467
    • Anthony Yeh's avatar
      0921c9a1
    • Kubernetes Submit Queue's avatar
      Merge pull request #46809 from rickypai/rpai/properly_validate_hostalias_hostnames · 41541910
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46977, 47005, 47018, 47061, 46809)
      
      Fix HostAlias to validate against DNS1123 hostname instead of just labels
      
      **What this PR does / why we need it**: the validation for HostAlias was validating the hostnames against DNS labels instead of hostnames. This means hostnames like `foo.bar` would fail. I did not catch this because unit test cases only had hostnames like `foo`.
      
      **Which issue this PR fixes**: fixes issue introduced in #44641
      
      **Release note**:
      ```release-note
      fixed HostAlias in PodSpec to allow `foo.bar` hostnames instead of just `foo` DNS labels.
      ```
      41541910
    • Kubernetes Submit Queue's avatar
      Merge pull request #47061 from madhusudancs/fed-sync-loop-clause-bug · 3b149249
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46977, 47005, 47018, 47061, 46809)
      
      Directly grab map values instead of using loop-clause variables when setting up federated sync controller tests.
      
      Go's loop-clause variables are allocated once and the items are copied to that variable while iterating through the loop. This means, these variables can't escape the scope since closures are bound to loop-clause variables whose value change during each iteration. Doing so would lead to undesired behavior. For more on this topic see: https://github.com/golang/go/wiki/CommonMistakes
      
      So in order to workaround this problem in sync controller e2e tests, we iterate through the map and copy the map value to a variable inside the loop before using it in closures.
      
      Fixes issue: #47059
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      /assign @marun @shashidharatd @perotinus 
      
      cc @csbell @nikhiljindal 
      
      /sig federation
      3b149249
    • Kubernetes Submit Queue's avatar
      Merge pull request #47018 from FengyunPan/fix-attach · a1ed965c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46977, 47005, 47018, 47061, 46809)
      
      Waiting attach operation to be finished rather than returning nil
      
      Fixes #46882
      a1ed965c
    • Kubernetes Submit Queue's avatar
      Merge pull request #47005 from MaciekPytel/add_e2e_setup_time · e7bb6af4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46977, 47005, 47018, 47061, 46809)
      
      Fix for cluster-autoscaler e2e failures
      
      This may help with cluster-autoscaler e2e failing in setup if the tests are run before all machines in mig get fully ready.
      e7bb6af4
    • Lucas Käldström's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #46977 from php-coder/improve_cert_controller_logging · d0626295
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      newCFSSLSigner: improve error reporting by including file name in the message
      
      **What this PR does / why we need it**:
      
      This PR improves error reporting by including an action and a file name into the error message.
      
      Before:
      >E0605 17:01:57.020485   29156 certificates.go:38] Failed to start certificate controller: open : no such file or directory
      
      After:
      >E0605 18:21:32.375884    4896 certificates.go:38] Failed to start certificate controller: error reading CA file "": open : no such file or directory
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      CC @mfojtik
      d0626295
    • Dan Winship's avatar
      a2cb5166
    • Dan Winship's avatar
      Abstract out duplicated cleanup code · bc13aa5e
      Dan Winship authored
      bc13aa5e
    • Dan Winship's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #47121 from sttts/sttts-kube-apiserver-owner · f89d2493
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      kube-apiserver: add myself to OWNERS
      f89d2493
    • Dr. Stefan Schimanski's avatar
    • Dr. Stefan Schimanski's avatar
      d2a257a0
    • Kubernetes Submit Queue's avatar
      Merge pull request #46669 from kow3ns/statefulset-update · 0613ae50
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46235, 44786, 46833, 46756, 46669)
      
      implements StatefulSet update
      
      **What this PR does / why we need it**:
      1. Implements rolling update for StatefulSets
      2. Implements controller history for StatefulSets.
      3. Makes StatefulSet status reporting consistent with DaemonSet and ReplicaSet.
      
      https://github.com/kubernetes/features/issues/188
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      Implements rolling update for StatefulSets. Updates can be performed using the RollingUpdate, Paritioned, or OnDelete strategies. OnDelete implements the manual behavior from 1.6. status now tracks 
      replicas, readyReplicas, currentReplicas, and updatedReplicas. The semantics of replicas is now consistent with DaemonSet and ReplicaSet, and readyReplicas has the semantics that replicas did prior to this release.
      ```
      0613ae50
    • Kubernetes Submit Queue's avatar
      Merge pull request #46756 from girikuncoro/japanese-translate · 443ed358
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46235, 44786, 46833, 46756, 46669)
      
      Add Japanese translation for kubectl
      
      **What this PR does / why we need it**:
      I messed up the original PR(#45562) which was already been reviewed and approved. This PR provides first attempt to translate kubectl in Japanese (related to #40645 and #40591).
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      No issues
      
      **Special notes for your reviewer**:
      Should be reviewed by member of Japanese k8s community (I stayed in Japan for 4 years, but my language is not as good as native Japanese)
      443ed358
    • Kubernetes Submit Queue's avatar
      Merge pull request #46833 from wasylkowski/fix-rc-cleanup · 07e4cca7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46235, 44786, 46833, 46756, 46669)
      
      Fixed ResourceConsumer.CleanUp to properly clean up non-replication-controller resources and pods
      
      **What this PR does / why we need it**: Without this fix CleanUp does not remove non-replication-controller resources and pods. This leads to pollution that in some cases inadvertently affects what is happening in AfterEachs before the namespace gets deleted.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      07e4cca7
    • Kubernetes Submit Queue's avatar
      Merge pull request #44786 from tsandall/f8n-scheduling-policy · eae59aaf
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46235, 44786, 46833, 46756, 46669)
      
      federation: Add admission controller for policy-based placement
      
      @nikhiljindal 
      
      Here's the initial version of the scheduling policy admission controller. It's at the point where it would benefit from having another pair of eyes look at it. The main thing I'm unsure of is the serialization of Kube resources for the webhook/query call.
      
      Release Note:
      
      ```
      The federation-apiserver now supports a SchedulingPolicy admission controller that enables policy-based control over placement of federated resources.
      ```
      
      Ref #39982
      eae59aaf
    • Kubernetes Submit Queue's avatar
      Merge pull request #46235 from droot/cmd-printer-refactor · a42867f1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46235, 44786, 46833, 46756, 46669)
      
      Get command uses print-column extn from Openapi schema
      
      **What this PR does / why we need it**:
      
      Kubectl Get command now uses metadata 'x-kubernetes-print-column' from Openapi schema to display a resource. This is to enable richer experience for non-compiled types (like service catalog API resources) in Kubectl. This functionality is currently guarded by a boolean flag "use-openapi-print-columns". 
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      fixes https://github.com/kubernetes/kubectl/issues/22
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Get command uses OpenAPI schema to enhance display for a resource if run with flag 'use-openapi-print-columns'. 
      An example command:
      kubectl get pods --use-openapi-print-columns 
      ```
      a42867f1
    • Jack Francis's avatar
      preferring float32 for rate limit QPS param · acb65170
      Jack Francis authored
      acb65170
    • Jack Francis's avatar
      go vet errata · 2accbbd6
      Jack Francis authored
      2accbbd6
    • Jack Francis's avatar
      rate limiting everywhere · 6d73a09d
      Jack Francis authored
      not waiting to rate limit until we get an error response from the API, doing so on initial request for all API requests
      6d73a09d
    • Kubernetes Submit Queue's avatar
      Merge pull request #47060 from deads2k/crd-12-prefix · d3b740bf
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix etcd storage location for CRs
      
      Fixes https://github.com/kubernetes/kubernetes/issues/46031
      
      The first commit is easy, the second commit is hard.  
      
      @sttts Read the second commit very carefully and search the repo to make sure that you agree this is only affecting aggregator and apiextensions.
      
      @pmorie @derekwaynecarr make sure you check to see if service catalog is double prefixing.  Looks like we missed it in 1.6, but no one was using it.
      d3b740bf