• Kubernetes Submit Queue's avatar
    Merge pull request #46991 from MrHohn/defer-deleteStaticIP-before-assert · 24f958d4
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 43005, 46660, 46385, 46991, 47103)
    
    [gke-slow always fails] Defer DeleteGCEStaticIP before asserting error
    
    From https://github.com/kubernetes/kubernetes/issues/46918.
    
    I'm getting close to the root cause: During tests, CreateGCEStaticIP() in fact successfully created static IP, but the parser we wrote in test mistakenly think we failed, probably because the gcloud output format was changed recently (or not). I'm still looking into fixing that.
    
    This PR defer the delete function before asserting the error so that we can stop consistently leaking static IP in every run.
    
    /assign @krzyzacy @dchen1107 
    
    ```release-note
    NONE
    ```
    24f958d4
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
hooks Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
translations Loading commit data...
vendor Loading commit data...
.bazelrc Loading commit data...
.gazelcfg.json Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
BUILD.bazel Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
Vagrantfile Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...