- 19 Jul, 2017 36 commits
-
-
saadali authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Remove service on termination when exec 'kubectl run' command with flags "--rm" and "--expose" **What this PR does / why we need it**: As the title says and issue #40504 mentioned. cc @tanapoln **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #40504 **Special notes for your reviewer**: Related to: #44915 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Improve the warning message if the rbd command is not found. **What this PR does / why we need it**: The previous warning msg is not correct if there is no rbd cmd. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue k8s.io/metrics: restrict k8s.io/metrics imports
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Restore cAdvisor prometheus metrics to the main port But under a new path - `/metrics/cadvisor`. This ensures a secure port still exists for metrics while getting the benefit of separating out container metrics from the kubelet's metrics as recommended in the linked issue. Fixes #48483 ```release-note-action-required Restored cAdvisor prometheus metrics to the main port -- a regression that existed in v1.7.0-v1.7.2 cAdvisor metrics can now be scraped from `/metrics/cadvisor` on the kubelet ports. Note that you have to update your scraping jobs to get kubelet-only metrics from `/metrics` and `container_*` metrics from `/metrics/cadvisor` ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49116, 49095) update-staging-godeps: do not exclude k8s.io/metrics Counterpart to https://github.com/kubernetes/test-infra/pull/3560
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49116, 49095) Move pkg/api/v1/ref -> client-go/tools/reference `pkg/api/v1/ref` is the only remaining package copied from pkg/api/v1 to client-go via staging/copy.sh.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48043, 48200, 49139, 36238, 49130) expose RegisterAllAdmissionPlugins so that admission chains can be reused Exposes the admission plugin registration functions so that sets of plugins can be re-used. @sttts @p0lyn0mial
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48043, 48200, 49139, 36238, 49130) Implement equivalence cache by caching and re-using predicate result The last part of #30844, I opened a new PR instead of overwrite the old one because we changed some basic assumption by allowing invalidating equivalence cache item by individual predicate. The idea of this PR is based on discussion in https://github.com/kubernetes/kubernetes/issues/32024 - [x] Pods belong to same controllerRef considered to be equivalent - [x] ` podFitsOnNode` will use cached predicate result if it's available - [x] Equivalence cache will be updated when if a fresh new predicate is done - [x] `factory.go` will invalid specific predicate cache(s) based on the object change - [x] Since `schedule` and `bind` are async, we need to optimistically invalid affected cache(s) before `bind` - [x] Fully unit test of affected files - [x] e2e test to verify cache update/invalid workflow - [x] performance test results - [x] Some nits fixes related but expected to result in `needs-rebase` so they are split to: #36060 #35968 #37512 cc @wojtek-t @davidopp
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48043, 48200, 49139, 36238, 49130) expose method to allow externally setting defaults on an external type The options are an exposed type. This allows you to set the defaults on them. @derekwaynecarr who normally owns this bit?
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48043, 48200, 49139, 36238, 49130) [Federation] Make arguments to scheduling type adapter methods generic This is in the process of trying to rebase https://github.com/kubernetes/kubernetes/pull/45993 on latest. cc @marun @perotinus @kubernetes/sig-federation-misc Hoping I get some attention to this and later PRs soon. Associated issue https://github.com/kubernetes/kubernetes/issues/49181 **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48043, 48200, 49139, 36238, 49130) Validate --storage-backend type. **What this PR does / why we need it**: Validate --storage-backend type as early as possible. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #47517 This PR is as per https://github.com/kubernetes/kubernetes/pull/47517/files#r121975646 **Special notes for your reviewer**: /cc @justinsb **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49120, 46755, 49157, 49165, 48950) kubectl: deduplicate deployment generators **What this PR does / why we need it**: See the description on https://github.com/kubernetes/kubectl/issues/44 **Which issue this PR fixes**: fixes https://github.com/kubernetes/kubectl/issues/44 **Special notes for your reviewer**: Yes, the lines added and removed are about the same. This is because I added 20+ lines of docstrings. Check the diff. You'll see I deleted a lot of duplicated logic :) **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49120, 46755, 49157, 49165, 48950) gce: don't print every file in mounter to stdout This is printing ~3000 lines.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49120, 46755, 49157, 49165, 48950) gce: make some global variables local /approve no-issue
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49120, 46755, 49157, 49165, 48950) add cmd test for kubectl auth can-i **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49120, 46755, 49157, 49165, 48950) Modify podpreset lister to use correct namespace Previously a pod with an empty namespace field submitted to a given namespace was incorrectly matching preset labels in a different namespace. Fixes https://github.com/kubernetes/kubernetes/issues/49141 Release note: ```release-note Fix pod preset to ignore input pod namespace in favor of request namespace ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110) Remove affinity annotations leftover **What this PR does / why we need it**: This is a further cleanup for affinity annotations, following #47869. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # ref: #47869 **Special notes for your reviewer**: - I remove the commented test cases and just leave TODOs instead. I think converting these untestable test cases for now is not necessary. We can add new test cases in future. - I remove the e2e test case `validates that embedding the JSON PodAffinity and PodAntiAffinity setting as a string in the annotation value work` because we have a test case `validates that InterPod Affinity and AntiAffinity is respected if matching` to test the same thing. /cc @aveshagarwal @bsalamat @gyliu513 @k82cn @timothysc **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110) make sure that the template param is the right type before using it The CLI should attempt to make sure that the flags it uses conform to expectations instead of unconditionally killing a process. This allows for possible re-use of the printing stack.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110) add a union category expander Adds a union category expander for use when we need to combined hardcoded and non-hardcoded options.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110) add svc and netpol to discovery Fixes https://github.com/kubernetes/kubernetes/issues/48962 one shortname was missing entirely, the other was on a storage not actually used as storage. @ncdc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110) OpenAPI bug: Array/Map Ptr Elements' handing was incorrect If you have an array of map of pointers, OpenAPI spec generation would fail. fixes: #49074
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871) do not close os.Stdin manually **What this PR does / why we need it**: We don't need close os.Stdin manually, it will block our read from stdin after finish the visit. **Special notes for your reviewer**: **Release note**: ``` None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871) fix NamespaceLifecycle admission forceLiveLookupCache is designed to save recently deleted namespaces. But currently, cluster scoped resources are also put into it. For example, when we run: kubectl delete clusterrole edit The "edit" is put into forceLiveLookupCache as a deleted namespace. This change fix the invalid action. **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871) Fix health check node port test flake **What this PR does / why we need it**: - Releases the allocated HealthCheck NodePort at the end of each associated test case. - Fixes the weird output `0` in `failed to allocate requested HealthCheck NodePort 0` **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49098 **Special notes for your reviewer**: /cc @freehan **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871) Adopt debian-base as baseimage **What this PR does / why we need it**: Based on discussion from - https://github.com/kubernetes/kubernetes/pull/44910/files#r125150263 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49169 **Special notes for your reviewer**: **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871) Log error when fail to execute command in with-retry() **What this PR does / why we need it**: Enhance gke/util.sh logging. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48913 **Special notes for your reviewer**: /cc @krzyzacy **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232) Move admission/v1alpha1 to k8s.io/api Fix https://github.com/kubernetes/kubernetes/issues/47972
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232) Cleanup the conversion of ObjectReference **What this PR does / why we need it**: No need to convert ObjectReference as `k8s.io/kubernetes/pkg/api/v1` and `k8s.io/client-go/pkg/api/v1` has been consistent in `k8s.io/api/core/v1`. **Which issue this PR fixes**: fixes #48747 **Special notes for your reviewer**: /assign @caesarxuchao **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232) aggr: don't write empty CA files write now if the metadata is not supplied, we write an empty file for these certs. we should just fail. Notice the removal of the ":-"s
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232) Move GPU e2e tests under owning SIG. Supercedes #48723 **Release note**: ```release-note NONE ``` /sig scheduling /assign @vishh @fejta @grodrigues3
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232) Rackspace for cloud-controller-manager This implements the NodeAddressesByProviderID and InstanceTypeByProviderID methods used by the cloud-controller-manager to the RackSpace provider. The instance type returned is the flavor name, for consistency InstanceType has been implemented too returning the same value. This is part of #47257 cc @wlan0 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add approvers to owners file for hpa Currently none of hpa developers or people in sig-autoscaling has the right to approve PRs to hpa, meaning it needs to be approved at pkg/controller level by people not working on autoscaling.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48481, 48256) Refactor: pkg/util into sub-pkgs **What this PR does / why we need it**: - move code in pkg/util into sub-pkgs - delete some unused funcs **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #15634 **Special notes for your reviewer**: This is the final work of #15634. It will close that issue. /cc @thockin **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48481, 48256) Protect against nil panic in apply **What this PR does / why we need it**: `kubectl apply` has a potential panic (actually verified in OpenShift in https://github.com/openshift/origin/issues/15017) where a `patcher` calls the `runDelete` function with a nil `resource.RESTClient`, but under some conditions the client is required by that function. **Release note**: ```release-note NONE ``` @pwittrock @kubernetes/sig-cli-bugs
-
Mike Danese authored
-
- 18 Jul, 2017 4 commits
-
-
Mike Danese authored
-
Chao Xu authored
-
Mike Danese authored
write now if the metadata is not supplied, we write an empty file for these certs. we should just fail
-
Dr. Stefan Schimanski authored
-