- 08 Jun, 2017 31 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 47065, 47157, 47143) Removed a race condition from ResourceConsumer **What this PR does / why we need it**: Without this PR there is a race condition in ResourceConsumer that sometimes results in communication to pods that might not exist anymore. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #47127 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue test header removal for impersonation Fixes https://github.com/kubernetes/kubernetes/issues/37722 Adds a test that fails if the headers aren't removed. @lavalamp per request
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Audit webhook config for GCE Add a `ADVANCED_AUDIT_BACKEND` (comma delimited list) environment variable to the GCE cluster config to select the audit backend, and add configuration for the webhook backend. ~~Based on the first commit from https://github.com/kubernetes/kubernetes/pull/46557~~ For kubernetes/features#22 Since this is GCE-only configuration plumbing, I think this should be exempt from code-freeze.
-
Dawn Chen authored
Revert "add gzip compression to GET and LIST requests"
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46559, 46970) Add e2e test that ensures that CRDs work in kube-apiserver part of https://github.com/kubernetes/kubernetes/issues/45511
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add Traditional Chinese translation for kubectl **What this PR does / why we need it**: This PR provides first attempt to translate kubectl in Traditional Chinese (related to https://github.com/kubernetes/kubernetes/pull/40645, https://github.com/kubernetes/kubernetes/pull/45573, https://github.com/kubernetes/kubernetes/pull/45562, https://github.com/kubernetes/kubernetes/pull/40591). **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # No issues **Special notes for your reviewer**: This PR requires Chinese people to assist in the review, especially Chinese speaking Taiwanese or Cantonese, thanks!
-
Jordan Liggitt authored
This reverts commit fc650a54.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Remove Initializers from admission-control in kubernetes-master charm for pre-1.7 **What this PR does / why we need it**: This fixes a problem with the kubernetes-master charm where kube-apiserver never comes up: ``` failed to initialize admission: Unknown admission plugin: Initializers ``` The Initializers plugin does not exist before Kubernetes 1.7. The charm needs to support 1.6 as well. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #47062 **Special notes for your reviewer**: This fixes a problem introduced by https://github.com/kubernetes/kubernetes/pull/36721 **Release note**: ```release-note Remove Initializers from admission-control in kubernetes-master charm for pre-1.7 ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fixes 47182 **What this PR does / why we need it**: Adds some state guards to the idle_status message to speed up the deployment **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #47182 **Special notes for your reviewer**: This adds additional state guards of the idle_status method, which will prevent it from being run until a worker has joined the relationship. Previous invocations may have some messaging inconsistencies but will reach eventual consistency once a worker has joined. This prevents the polling loop from executing too soon, bloating the installation time by bare-minimum an additional 10 minutes. **Release note**: ```release-note Added state guards to the idle_status messaging in the kubernetes-master charm to make deployment faster on initial deployment. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Bump up npd version to v0.4.0 Fixes #47070. Bump up npd version to [v0.4.0](https://github.com/kubernetes/node-problem-detector/releases/tag/v0.4.0). ```release-note Bump up Node Problem Detector version to v0.4.0, which added support of parsing log from /dev/kmsg and ABRT. ``` /cc @dchen1107 @ajitak
-
Charles Butler authored
This adds additional state guardsof the idle_status method, which will prevent it from being run until a worker has joined the relationship. Previous invocations may have some message artifacting, but will reach eventual consistency once a worker has joined. This prevents the polling loop from executing too soon, bloating the installation time by bare-minimum an additional 10 minutes.
-
Shiyang Wang authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue kubeadm: Enable the Node Authorizer/Admission plugin in v1.7 **What this PR does / why we need it**: This is similar to https://github.com/kubernetes/kubernetes/pull/46796, but for kubeadm. Basically it was a part of https://github.com/kubernetes/kubernetes/pull/46796, but there were some other upgradability and compability concerns for kubeadm I took care of while working today. Example: ```console $ kubeadm init --kubernetes-version v1.7.0-beta.0 [kubeadm] WARNING: kubeadm is in beta, please do not use it for production clusters. [init] Using Kubernetes version: v1.7.0-beta.0 [init] Using Authorization mode: [RBAC Node] ... $ sudo kubectl --kubeconfig=/etc/kubernetes/kubelet.conf get secret foo Error from server (Forbidden): User "system:node:thegopher" cannot get secrets in the namespace "default".: "no path found to object" (get secrets foo) $ echo '{"apiVersion":"v1","kind":"Node","metadata":{"name":"foo"}}' | sudo kubectl create -f - --kubeconfig=/etc/kubernetes/kubelet.conf Error from server (Forbidden): error when creating "STDIN": nodes "foo" is forbidden: node thegopher cannot modify node foo ``` **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: Depends on https://github.com/kubernetes/kubernetes/pull/46864 (uses that PR as a base, will rebase once it's merged) Please only review the second commit. Will also fix tests in a minute. **Release note**: ```release-note kubeadm: Enable the Node Authorizer/Admission plugin in v1.7 ``` @mikedanese @liggitt @pipejakob @roberthbailey @jbeda @timothysc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Bump external provisioner image to smaller version The image is roughly half as big so this should improve speed/flakiness maybe --> ```release-note NONE ```
-
William Chang authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Deprecated binding for 1.7 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #10043 ```release-note Deprecated Binding objects in 1.7. ```
-
Andrzej Wasylkowski authored
-
Chao Xu authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Support windows in dockershim **What this PR does / why we need it**: This is the 2nd part for https://github.com/kubernetes/kubernetes/issues/45927 . The non-cri implementation dockertools was removed from kubelet v1.7 . Part of previous work for supporting windows container lies in v1.6 dockertools, this PR is to port them to dockershim. Main reference file in v1.6 dockertools windows support: https://github.com/kubernetes/kubernetes/blob/v1.6.4/pkg/kubelet/dockertools/docker_manager_windows.go **Which issue this PR fixes** 45927, for now catching up the implementation of v1.6 **Special notes for your reviewer**: The code change includes 4 parts, put them together as we discussed in https://github.com/kubernetes/kubernetes/pull/46089 1. Update go-winio package to a newer version 'go-winio' package is used by docker client. This change is to bring the support for Go v1.8, specifically included in the PR: https://github.com/Microsoft/go-winio/pull/48 Otherwise it will produce a lot of error like in: https://github.com/fsouza/go-dockerclient/issues/648 2. Add os dependent getSecurityOpts helper method. seccomp not supported on windows Corresponding code in v1.6: https://github.com/kubernetes/kubernetes/blob/v1.6.4/pkg/kubelet/dockertools/docker_manager_windows.go#L78 3. Add updateCreateConfig. Allow user specified network mode setting. This is to be compatible with what kube-proxy package does on Windows. Also, there is a Linux section in both sandbox config and container config: LinuxPodSandboxConfig, LinuxContainerConfig. And that section later goes to Config and HostConfig section under docker container createConfig. Ideally hostconfig section should be dependent on host os, while config should depend on container image os. To simplify the case, here it assumes that windows host supports windows type container image only. It needs to be updated when kubernetes is to support windows host running linux container image or the like. Corresponding code in v1.6: https://github.com/kubernetes/kubernetes/blob/v1.6.4/pkg/kubelet/dockertools/docker_manager_windows.go#L57 4. Add podIpCache in dockershim. For v1.6 windows implementation, it still does not use sandbox, thus only allow single container to be exposed. Here added a cache for saving container IP, to get adapted to the new CRI api. Corresponding code in v1.6: No sandbox: https://github.com/kubernetes/kubernetes/blob/v1.6.4/pkg/kubelet/dockertools/docker_manager_windows.go#L66 Use container id as pod ip: https://github.com/kubernetes/kubernetes/blob/v1.6.4/pkg/kubelet/dockertools/docker_manager.go#L2727 **Release note**:
-
Klaus Ma authored
-
Klaus Ma authored
-
Klaus Ma authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46979, 47078, 47138, 46916) Add a secretbox and AES-CBC path for encrypt at rest Add a secretbox and AES-CBC encrypt at rest provider and alter the config, based on feedback from security review. AES-CBC is more well reviewed and generally fits better with common criteria and FIPS, secretbox is newer and faster than CBC. ```release-note Add secretbox and AES-CBC encryption modes to at rest encryption. AES-CBC is considered superior to AES-GCM because it is resistant to nonce-reuse attacks, and secretbox uses Poly1305 and XSalsa20. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46979, 47078, 47138, 46916) DeleteCollection should include uninitialized resources Users who delete a collection expect all resources to be deleted, and users can also delete an uninitialized resource. To preserve this expectation, DeleteCollection selects all resources regardless of initialization. The namespace controller should list uninitialized resources in order to gate cleanup of a namespace. Fixes #47137
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46979, 47078, 47138, 46916) HPA: only send updates when the status has changed This commit only sends updates if the status has actually changed. Since the HPA runs at a regular interval, this should reduce the volume of writes, especially on short HPA intervals with relatively constant metrics. Fixes #47077 **Release note**: ```release-note The HorizontalPodAutoscaler controller will now only send updates when it has new status information, reducing the number of writes caused by the controller. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46979, 47078, 47138, 46916) [federation][e2e] Fix cleanupServiceShardLoadBalancer **What this PR does / why we need it**: Fixes the issue mentioned in #46976 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #46976 **Special notes for your reviewer**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45877, 46846, 46630, 46087, 47003) Remove duplicate errors from an aggregate error input. This PR, in general, removes duplicate errors from an aggregate error input, and returns unique errors with their occurrence count. Specifically, this PR helps with some scheduler errors that fill the log enormously. For example, see the following `truncated` output from a 300-plus nodes cluster, as there was a same error from almost all nodes. [SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected., SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found......... After this PR, the output looks like (on a 2-node cluster): SchedulerPredicates failed due to persistentvolumeclaims "mongodb" not found, which is unexpected.(Count=2) @derekwaynecarr @smarterclayton @kubernetes/sig-scheduling-pr-reviews Fixes https://github.com/kubernetes/kubernetes/issues/47145
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45877, 46846, 46630, 46087, 47003) gpusInUse info error when kubelet restarts **What this PR does / why we need it**: In my test, I found 2 errors in the nvidia_gpu_manager.go. 1. the number of activePods in gpusInUse() equals to 0 when kubelet restarts. It seems the Start() method was called before pods recovery which caused this error. So I decide not to call gpusInUse() in the Start() function, just let it happen when new pod needs to be created. 2. the container.ContainerID in line 242 returns the id in format of "docker://<container_id>", this will make the client failed to inspect the container by id. We have to erase the prefix of "docker://". **Special notes for your reviewer**: **Release note**: ``` Avoid assigning the same GPU to multiple containers. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45877, 46846, 46630, 46087, 47003) update NetworkPolicy e2e test for v1 semantics This makes the NetworkPolicy test at least correct for v1, although ideally we'll eventually add a few more tests... (So this covers about half of #46625.) I've tested that this compiles, but not that it passes, since I don't have a v1-compatible NetworkPolicy implementation yet... @caseydavenport @ozdanborne, maybe you're closer to having a testable plugin than I am? **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45877, 46846, 46630, 46087, 47003) func parseEndpointWithFallbackProtocol should check if protocol of endpoint is empty **What this PR does / why we need it**: func parseEndpointWithFallbackProtocol should check if protocol of endpoint is empty **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: part of #45927 NONE **Special notes for your reviewer**: NONE **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45877, 46846, 46630, 46087, 47003) add Unit Test for PodList Printer Signed-off-by:zhangxiaoyu-zidif <zhang.xiaoyu33@zte.com.cn> **What this PR does / why we need it**: add Unit Test for PodList Printer **Release note**: ```release-note NONE ```
-
- 07 Jun, 2017 9 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 47024, 47050, 47086, 47081, 47013) Wrap HumanReadablePrinter in tab output unless explicitly asked not to `kubectl get` was not properly aligning its output due to #40848 Fixes an accidental regression. In general, we should not accept an incoming tabwriter and instead manage at a higher level. Fix the bug and add a comment re: future refactoring.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 47024, 47050, 47086, 47081, 47013) kubeadm: Make the creation of the RBAC rules phase idempotent **What this PR does / why we need it**: Bugfix: Currently kubeadm fails with a non-zero code if resources it's trying to create already exist. This PR fixes that by making kubeadm try to Update resources that already exist. After this PR, https://github.com/kubernetes/kubernetes/pull/46879 and a beta.1 release, kubeadm will be fully upgradeable from v1.6 to v1.7 using only kubeadm init. Last piece of https://github.com/kubernetes/kubeadm/issues/288 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Fixes: https://github.com/kubernetes/kubeadm/issues/288 **Special notes for your reviewer**: **Release note**: ```release-note kubeadm: Modifications to cluster-internal resources installed by kubeadm will be overwritten when upgrading from v1.6 to v1.7. ``` @pipejakob @mikedanese @timothysc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 47024, 47050, 47086, 47081, 47013) apiextensions-apiserver: Fix decoding of DeleteOptions. Fixes #47072 by making apiextensions-apiserver capable of decoding unversioned DeleteOptions, rather than only handling Unstructured objects (i.e. Custom Resources). This also closes #46736 and #37554 since the added regression test works for TPR as well.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 47024, 47050, 47086, 47081, 47013) client-go: deprecate TPR example and add CRD example /cc @nilebox Part of https://github.com/kubernetes/kubernetes/issues/46702
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue [legacy audit] add response audit for hijack Fixes #47097 **Release note**: ``` NONE ```
-
Clayton Coleman authored
Users who delete a collection expect all resources to be deleted, and users can also delete an uninitialized resource. To preserve this expectation, DeleteCollection selects all resources regardless of initialization. The namespace controller should list uninitialized resources in order to gate cleanup of a namespace.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Skip dynamic configuration of initializers test on alpha disable Fixes #47133
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43005, 46660, 46385, 46991, 47103) Ignore `daemonset-controller-hash` label key in federation before comparing the federated object with its cluster equivalent. Kubernetes daemonset controller writes a daemonset's hash to the object label as an optimization to avoid recomputing it every time. Adding a new label to the object that the federation is unaware of causes problems because federated controllers compare the objects in federation and their equivalents in clusters and try to reconcile them. This leads to a constant fight between the federated daemonset controller and the cluster controllers, and they never reach a stable state. Ideally, cluster components should not update an object's spec or metadata in a way federation cannot replicate. They can update an object's status though. Therefore, this daemonset hash should be a field in daemonset's status, not a label in object meta. @janetkuo says that this label is only a short term solution. In the near future, they are going to replace it with revision numbers in daemonset status. We can then rip this bandaid out. Fixes #46925 **Release note**: ```release-note NONE ``` /assign @csbell /cc @shashidharatd @marun @nikhiljindal @perotinus /sig federation
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43005, 46660, 46385, 46991, 47103) [gke-slow always fails] Defer DeleteGCEStaticIP before asserting error From https://github.com/kubernetes/kubernetes/issues/46918. I'm getting close to the root cause: During tests, CreateGCEStaticIP() in fact successfully created static IP, but the parser we wrote in test mistakenly think we failed, probably because the gcloud output format was changed recently (or not). I'm still looking into fixing that. This PR defer the delete function before asserting the error so that we can stop consistently leaking static IP in every run. /assign @krzyzacy @dchen1107 ```release-note NONE ```
-