- 30 May, 2017 33 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43275, 45014, 46449, 46488, 46525) Fix typo **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue use make slice to store objects to improve efficiency Signed-off-by:allencloud <allen.sun@daocloud.io> **What this PR does / why we need it**: we we know the slice length in advance, I think we had better use make to create the specified length of slice. This will improve some kind of performance. Since if we create a slice with []type{}, we did not know how much space runtime should reserve, since slice implementation should be continuous in memory. While when we make a slice with specified length, runtime would reserve a continuous memory space which will not result in slice movement in case of current space is not enough. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # NONE **Special notes for your reviewer**: NONE **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue delete unreachable code Signed-off-by:yupengzte <yu.peng36@zte.com.cn> **What this PR does / why we need it**: After panic, the code is unreachable,delete them. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue kubelet: remove a redundant check for mounting the hosts file HostNetwork is not part of the Pod.Spec.SecurityContext in the versioned pod. Remove the redundant check. See https://github.com/kubernetes/kubernetes/issues/43632#issuecomment-304370330 for the explanation.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45534, 37212, 46613, 46350) Speed up and reduce number of memory allocations in kube-proxy This is a second (and last PR) in this series - this solves all very-low-hanging fruits. This PR: - reduces cpu usage by ~25% - reduces memory allocations by ~3x (together with #46033 by 10-12x) Without this PR: ``` (pprof) top 8.59GB of 8.79GB total (97.75%) Dropped 238 nodes (cum <= 0.04GB) Showing top 10 nodes out of 64 (cum >= 0.11GB) flat flat% sum% cum cum% 3.66GB 41.60% 41.60% 8.72GB 99.17% k8s.io/kubernetes/pkg/proxy/iptables.(*Proxier).syncProxyRules 3.07GB 34.96% 76.56% 3.07GB 34.96% runtime.rawstringtmp 0.62GB 7.09% 83.65% 0.62GB 7.09% runtime.hashGrow 0.34GB 3.82% 87.46% 0.34GB 3.82% runtime.stringtoslicebyte 0.29GB 3.24% 90.71% 0.58GB 6.61% encoding/base32.(*Encoding).EncodeToString 0.22GB 2.47% 93.18% 0.22GB 2.47% strings.genSplit 0.18GB 2.04% 95.22% 0.18GB 2.04% runtime.convT2E 0.11GB 1.22% 96.44% 0.73GB 8.36% runtime.mapassign 0.10GB 1.08% 97.52% 0.10GB 1.08% syscall.ByteSliceFromString 0.02GB 0.23% 97.75% 0.11GB 1.25% syscall.SlicePtrFromStrings ``` with this PR: ``` (pprof) top 2.98GB of 3.08GB total (96.78%) Dropped 246 nodes (cum <= 0.02GB) Showing top 10 nodes out of 70 (cum >= 0.10GB) flat flat% sum% cum cum% 1.99GB 64.60% 64.60% 1.99GB 64.60% runtime.rawstringtmp 0.58GB 18.95% 83.55% 0.58GB 18.95% runtime.hashGrow 0.10GB 3.40% 86.95% 0.69GB 22.47% runtime.mapassign 0.09GB 2.86% 89.80% 0.09GB 2.86% syscall.ByteSliceFromString 0.08GB 2.63% 92.44% 0.08GB 2.63% runtime.convT2E 0.03GB 1.13% 93.56% 0.03GB 1.13% syscall.Environ 0.03GB 0.99% 94.56% 0.03GB 0.99% bytes.makeSlice 0.03GB 0.97% 95.52% 0.03GB 1.06% os.Stat 0.02GB 0.65% 96.18% 3.01GB 97.79% k8s.io/kubernetes/pkg/proxy/iptables.(*Proxier).syncProxyRules 0.02GB 0.6% 96.78% 0.10GB 3.35% syscall.SlicePtrFromStrings ``` -
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45534, 37212, 46613, 46350) [e2e]Fix define redundant parameter When timeout to reach HTTP service, redundant parameter make the error is nil.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45534, 37212, 46613, 46350) Add unversioned.MicroTime type Ref. #36752 cc @smarterclayton @wojtek-t @dchen1107 @timothysc @bgrant0607
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45534, 37212, 46613, 46350) check err Signed-off-by:yupengzte <yu.peng36@zte.com.cn> **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615) Make log-monitor give up on trying to ssh to a dead node after some time Fix #38263
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615) add test for set image validation **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615) Add Unit Test:describe configmap **What this PR does / why we need it**: Add Unit Test:describe configmap **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615) fmt.Errorf replaces errors **What this PR does / why we need it**: fmt.Errorf replaces errors importing errors is redundant. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45488, 45335, 45909, 46074, 46615) Fix screwed-up log message format It had two %-verbs and three arguments **What this PR does / why we need it**: Fixes kubelet log lines like this: May 08 11:49:04 brya-1 kubelet[23248]: W0508 11:49:04.248123 23248 eviction_manager.go:128] Failed to admit pod kube-proxy-g3hjs_kube-system(55c1fbbb-33e4-11e7-b83c-42010a800002) - node has conditions: %v%!(EXTRA []v1.NodeConditionType=[MemoryPressure]) to remove the `%v%!(EXTRA` **Release note**: ```release-note NONE ``` -
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46561, 46566) Fix golint errors in cmd/kube-apiserver **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46561, 46566) Return nil when err is nil **What this PR does / why we need it**: Return nil directly when err is nil **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45327, 46217, 46377, 46428, 46588) Matches single without selector This is reducing cpu-usage of apiserver by ~5% in 5000-node clusters.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45327, 46217, 46377, 46428, 46588) ommitting close file while testing manifest ommitting close file while testing manifest.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45327, 46217, 46377, 46428, 46588) Fix comment typo in kube-apiserver and cachesize **What this PR does / why we need it**: Fix comment typo in files cmd/kube-apiserver/app/server.go and pkg/registry/cachesize/cachesize.go **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Not a major issue, just a minor improvement. **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45327, 46217, 46377, 46428, 46588) fix some typo **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Wojciech Tyczynski authored
-
Wojciech Tyczynski authored
-
Wojciech Tyczynski authored
-
Wojciech Tyczynski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue The first letter should be capitalized **What this PR does / why we need it**: The first letter should be capitalized **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
gmarek authored
-
FengyunPan authored
When timeout to reach HTTP service, redundant parameter make the error is nil.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Correct spelling in quobyte **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue avoiding unnecessary loop to copy pods listed **What this PR does / why we need it**: avoids unnecessary loop to copy pods listed **Which issue this PR fixes** : fixes #46433 **Release note**: ```release-note ``` /assign @wojtek-t
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Kubeadm - Make code OS-agnostic **What this PR does / why we need it**: Kubernetes just got Windows Containers alpha support, opening the opportunity for kubeadm to also be used to setup, at least, Windows Server 2016 or newer worker nodes. With that in mind, we should take the effort of writing OS-agnostic code whenever possible, e.g. when dealing with the filesystem. **Which issue this PR fixes** https://github.com/kubernetes/kubeadm/issues/108 **Special notes for your reviewer**: **Release note**:
-
Wojciech Tyczynski authored
-
Wojciech Tyczynski authored
-
Wojciech Tyczynski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix golint error in apimachinery/pkg/{fields,lables} Also add these two packages to linted packages lists **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
- 29 May, 2017 7 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue no-snat test This test checks that Pods can communicate with each other in the same cluster without SNAT. I intend to create a job that runs this in small clusters (\~3 nodes) at a low frequency (\~once per day) so that we have a signal as we work on allowing multiple non-masquerade CIDRs to be configured (see [kubernetes-incubator/ip-masq-agent](https://github.com/kubernetes-incubator/ip-masq-agent), for example). /cc @dnardo
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue AWS: support node port health check **What this PR does / why we need it**: if a custom health check is set from the beta annotation on a service it should be used for the ELB health check. This patch adds support for that. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: Let me know if any tests need to be added. **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue typos: spelling fixes in pkg/util/wait/wait.go ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix go-xgettext (go get) reference on translations README The `go get` command to install `xgettext` was wrongly pointing to `tree/master`.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45699, 46200, 46335, 46599) Bump CNI and etcd go base images to 1.7.6 **What this PR does / why we need it**: Addresses #46391 for CNI and etcd images. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` /assign @luxas
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45699, 46200, 46335, 46599) audit: implement stages Based on https://github.com/kubernetes/kubernetes/pull/46065. Implementing https://github.com/kubernetes/kubernetes/pull/46065#discussion_r117438531.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45699, 46200, 46335, 46599) apiextensions: add integration test for name conflicts **What this PR does / why we need it**: Add integration test for name conflicts. Create 2 CRDs with name conflict. The controller sets the NameConflict condition on the second one. Delete the first one. The second CRD should now get accepted. Update: - [x] Add integration test for name conflicts - [x] Fix naming controller so that when a resource is deleted, other resources in the same group are added to the queue - [x] Add integration test for self link (cluster scoped resources) - [x] Add bigger poll interval - [x] Fix DeleteCustomResourceDefinition poll condition **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: for #45511 **Special notes for your reviewer**: **Release note**: ``` NONE ``` @sttts
-