- 19 Jul, 2017 18 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110) Remove affinity annotations leftover **What this PR does / why we need it**: This is a further cleanup for affinity annotations, following #47869. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # ref: #47869 **Special notes for your reviewer**: - I remove the commented test cases and just leave TODOs instead. I think converting these untestable test cases for now is not necessary. We can add new test cases in future. - I remove the e2e test case `validates that embedding the JSON PodAffinity and PodAntiAffinity setting as a string in the annotation value work` because we have a test case `validates that InterPod Affinity and AntiAffinity is respected if matching` to test the same thing. /cc @aveshagarwal @bsalamat @gyliu513 @k82cn @timothysc **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110) make sure that the template param is the right type before using it The CLI should attempt to make sure that the flags it uses conform to expectations instead of unconditionally killing a process. This allows for possible re-use of the printing stack.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110) add a union category expander Adds a union category expander for use when we need to combined hardcoded and non-hardcoded options.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110) add svc and netpol to discovery Fixes https://github.com/kubernetes/kubernetes/issues/48962 one shortname was missing entirely, the other was on a storage not actually used as storage. @ncdc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49055, 49128, 49132, 49134, 49110) OpenAPI bug: Array/Map Ptr Elements' handing was incorrect If you have an array of map of pointers, OpenAPI spec generation would fail. fixes: #49074
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871) do not close os.Stdin manually **What this PR does / why we need it**: We don't need close os.Stdin manually, it will block our read from stdin after finish the visit. **Special notes for your reviewer**: **Release note**: ``` None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871) fix NamespaceLifecycle admission forceLiveLookupCache is designed to save recently deleted namespaces. But currently, cluster scoped resources are also put into it. For example, when we run: kubectl delete clusterrole edit The "edit" is put into forceLiveLookupCache as a deleted namespace. This change fix the invalid action. **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871) Fix health check node port test flake **What this PR does / why we need it**: - Releases the allocated HealthCheck NodePort at the end of each associated test case. - Fixes the weird output `0` in `failed to allocate requested HealthCheck NodePort 0` **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49098 **Special notes for your reviewer**: /cc @freehan **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871) Adopt debian-base as baseimage **What this PR does / why we need it**: Based on discussion from - https://github.com/kubernetes/kubernetes/pull/44910/files#r125150263 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49169 **Special notes for your reviewer**: **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48914, 48535, 49099, 48935, 48871) Log error when fail to execute command in with-retry() **What this PR does / why we need it**: Enhance gke/util.sh logging. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48913 **Special notes for your reviewer**: /cc @krzyzacy **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232) Move admission/v1alpha1 to k8s.io/api Fix https://github.com/kubernetes/kubernetes/issues/47972
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232) Cleanup the conversion of ObjectReference **What this PR does / why we need it**: No need to convert ObjectReference as `k8s.io/kubernetes/pkg/api/v1` and `k8s.io/client-go/pkg/api/v1` has been consistent in `k8s.io/api/core/v1`. **Which issue this PR fixes**: fixes #48747 **Special notes for your reviewer**: /assign @caesarxuchao **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232) aggr: don't write empty CA files write now if the metadata is not supplied, we write an empty file for these certs. we should just fail. Notice the removal of the ":-"s
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232) Move GPU e2e tests under owning SIG. Supercedes #48723 **Release note**: ```release-note NONE ``` /sig scheduling /assign @vishh @fejta @grodrigues3
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48702, 48965, 48740, 48974, 48232) Rackspace for cloud-controller-manager This implements the NodeAddressesByProviderID and InstanceTypeByProviderID methods used by the cloud-controller-manager to the RackSpace provider. The instance type returned is the flavor name, for consistency InstanceType has been implemented too returning the same value. This is part of #47257 cc @wlan0 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add approvers to owners file for hpa Currently none of hpa developers or people in sig-autoscaling has the right to approve PRs to hpa, meaning it needs to be approved at pkg/controller level by people not working on autoscaling.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48481, 48256) Refactor: pkg/util into sub-pkgs **What this PR does / why we need it**: - move code in pkg/util into sub-pkgs - delete some unused funcs **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #15634 **Special notes for your reviewer**: This is the final work of #15634. It will close that issue. /cc @thockin **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48481, 48256) Protect against nil panic in apply **What this PR does / why we need it**: `kubectl apply` has a potential panic (actually verified in OpenShift in https://github.com/openshift/origin/issues/15017) where a `patcher` calls the `runDelete` function with a nil `resource.RESTClient`, but under some conditions the client is required by that function. **Release note**: ```release-note NONE ``` @pwittrock @kubernetes/sig-cli-bugs
-
- 18 Jul, 2017 22 commits
-
-
Chao Xu authored
-
Mike Danese authored
write now if the metadata is not supplied, we write an empty file for these certs. we should just fail
-
Chao Xu authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46094, 48544, 48807, 49102, 44174) Allow user to pass various gluster volume options when glusterfs volumes are dynamically provisioned. This patch add new storage class parameter called `volumeoptions` which can be used to set various volume options. for eg# if you want to enable encryption on volumes, the values like `client.ssl on`, `server.ssl on`..etc can be passed to `volumeoptions` parameter in storageclass. Issue # https://github.com/kubernetes/kubernetes/issues/28454Signed-off-by:Humble Chirammal <hchiramm@redhat.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46094, 48544, 48807, 49102, 44174) add InstanceID to fake cadvisor (used in Kubemark) This change is for setting Node.Spec.ProviderID field in Kubemark hollow nodes. It shouldn't affect other tests using cadvisor.Fake as field is nil by default. cc @gmarek
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46094, 48544, 48807, 49102, 44174) Implement kubectl describe <fibre-channel PV> kubectl did not show any details about Fibre Channel volumes, someone just forgot to implement it. Tested with: ```shell $ kubectl create -f - <<EOF apiVersion: v1 kind: PersistentVolume metadata: name: myfc spec: capacity: storage: 100Gi accessModes: - ReadWriteOnce persistentVolumeReclaimPolicy: Delete fc: targetWWNs: ['500a0982991b8dc5', '500a0982891b8dc5'] lun: 2 fsType: ext4 readOnly: true EOF $ kubectl describe pv myfc Name: myfc Labels: <none> Annotations: <none> StorageClass: Status: Available Claim: Reclaim Policy: Delete Access Modes: RWO Capacity: 100Gi Message: Source: Type: FC (a Fibre Channel disk) TargetWWNs: 500a0982991b8dc5, 500a0982891b8dc5 LUN: 2 FSType: ext4 ReadOnly: true Events: <none> ``` ```release-note NONE ``` @kubernetes/sig-cli-pr-reviews -
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46094, 48544, 48807, 49102, 44174) Static deepcopy – phase 1 This PR is the follow-up of https://github.com/kubernetes/kubernetes/pull/36412, replacing the dynamic reflection based deepcopy with static DeepCopy+DeepCopyInto methods on API types. This PR **does not yet** include the code dropping the cloner from the scheme and all the porting of the calls to scheme.Copy. This will be part of a follow-up "Phase 2" PR. A couple of the commits will go in first: - [x] audit: fix deepcopy registration https://github.com/kubernetes/kubernetes/pull/48599 - [x] apimachinery+apiserver: separate test types in their own packages #48601 - [x] client-go: remove TPR example #48604 - [x] apimachinery: remove unneeded GetObjectKind() impls #48608 - [x] sanity check against origin, that OpenShift's types are fine for static deepcopy https://github.com/deads2k/origin/pull/34 TODO **after** review here: - [x] merge https://github.com/kubernetes/gengo/pull/32 and update vendoring commit
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46094, 48544, 48807, 49102, 44174) Shared Informer Run blocks until all goroutines finish **What this PR does / why we need it**: Makes Shared Informer Run method block until all goroutines it spawned finish. See #45454. **Which issue this PR fixes** Fixes #45454 **Release note**: ```release-note NONE ```
-
deads2k authored
-
deads2k authored
-
Rohit Agarwal authored
-
deads2k authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue amend the comment **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```NONE
-
Fabiano Franz authored
-
Humble Chirammal authored
`volumeoptions` which can be used to set various volume options. for eg# if you want to enable encryption on volumes, the values like `client.ssl on`, `server.ssl on`..etc can be passed to `volumeoptions` parameter in storageclass. Issue # https://github.com/kubernetes/kubernetes/issues/28454Signed-off-by:
Humble Chirammal <hchiramm@redhat.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48333, 48806, 49046) kubeadm: Split out markmaster to its own phase **What this PR does / why we need it**: Splits out related and atomic code into its own phase that can be invokable easily from the CLI. Makes the code much easier to read by not using recursion and `wait.InfinitePoll` _inside_ of a recursing function, etc. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Fixes: https://github.com/kubernetes/kubeadm/issues/53 Part of this more long-term goal: https://github.com/kubernetes/kubeadm/issues/148 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` @kubernetes/sig-cluster-lifecycle-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48333, 48806, 49046) kubeadm: Generate kube-proxy image name in its own pkg **What this PR does / why we need it**: code cleanup. Control kube-proxy image parameter in DaemonSet template. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: Minor cleanup. Attn @luxas **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48333, 48806, 49046) use v1.ResourcePods instead of hard coding "pods" Signed-off-by:sakeven <jc5930@sina.cn> **What this PR does / why we need it**: use v1.ResourcePods instead of hard coding 'pods' **Special notes for your reviewer**: **Release note**: ``` NONE ```
-
xiangpengzhao authored
-
Maciej Pytel authored
-
xiangpengzhao authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update autoscaling tests OWNERS Add current members of autoscaling team to autoscaling tests OWNERS
-