1. 30 Mar, 2018 8 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #61482 from filbranden/summary3 · 189a166a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix summary_test to work when XFS is used under overlay2 and add a check for Delegate=yes missing from docker.service
      
      **What this PR does / why we need it**:
      This fixes the summary_test checks to work in cases where:
      1. Docker is using overlay2 for its images with XFS as backing filesystem.
      1. The systemd unit for Docker does not include Delegate=yes.
      
      The former will break RootFs minimum usage check from summary_test, since it expects _some_ usage even though the upper layer only contains directories that are used as mount points. It turns out the XFS filesystem returns "0" blocks in the stat() result for a directory, so this breaks the test. Fix it by creating a file with some small contents in the test, so that `du` will actually return some usage.
      
      **NOTE**: I introduced this step in the loop part of the function. It works, but maybe it's not the best... Let me know if you think we should do some small cleanup here too, I'd be happy to do that.
      
      Regarding the latter, when `Delegate=yes` is not included in `docker.service`, then systemd might choose not to create Memory and CPU cgroups (actually, any of the resource cgroups) for the unit when it starts it. It's a bit more complicated than that, because it *does* create them if any sibling units need it, so the behavior is a bit hard to control... In any case, here we're checking on it and accepting that we might get a "nil" from cAdvisor in cases where `Delegate=yes` is missing.
      
      Both of these issues can be found on CentOS/RHEL, that's the motivation for the fixes.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      N/A
      
      **Special notes for your reviewer**:
      /assign dashpole
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      189a166a
    • Filipe Brandenburger's avatar
      In summary_test, make Docker cpu/memory checks optional if unavailable. · b8c39b70
      Filipe Brandenburger authored
      The numbers will only be available when docker.service has its own
      memory and cpu cgroups, which doesn't necessarily happen unless the unit
      has Delegate=yes configured.
      
      Let's work around that by checking the status of Delegate, in the case
      where we are:
      * running Docker
      * running Systemd
      * able to check the status through systemctl
      * the status is explicitly Delegate=no (the default)
      
      If all of those are true, let's make CPU and Memory expectations
      optional.
      
      Tested: make test-e2e-node REMOTE=true HOSTS=centos-e2e-node FOCUS="Summary API"
      b8c39b70
    • Filipe Brandenburger's avatar
      In summary_test, create a file outside the test volume too. · 351a70b6
      Filipe Brandenburger authored
      This is necessary to show any RootFs usage on systems where the backing
      filesystem of overlay2 is xfs.
      
      The current test only created directories (for mount points) in the
      upper layer of the overlay. Outside of the mount namespace, only the
      directories are visible. When running `du` on those, usually filesystems
      will show some usage, but not xfs, which shows a disk usage of 0 for
      directories.
      
      Fix this by creating a file in the root directory, outside the volumes,
      in order to trigger some disk usage that can be measured by `du`.
      
      Tested: make test-e2e-node REMOTE=true HOSTS=centos-e2e-node FOCUS="Summary API"
      351a70b6
    • Kubernetes Submit Queue's avatar
      Merge pull request #60100 from mtaufen/node-authz-nodeconfigsource · 5ae7bba4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61829, 61908, 61307, 61872, 60100). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      node authorizer sets up access rules for dynamic config
      
      This PR makes the node authorizer automatically set up access rules for
      dynamic Kubelet config.
      
      I also added some validation to the node strategy, which I discovered we
      were missing while writing this.
      
      This PR is based on another WIP from @liggitt.
      
      ```release-note
      The node authorizer now automatically sets up rules for Node.Spec.ConfigSource when the DynamicKubeletConfig feature gate is enabled.
      ```
      5ae7bba4
    • Kubernetes Submit Queue's avatar
      Merge pull request #61872 from rmmh/verify-coalesce · 6c107fcc
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61829, 61908, 61307, 61872, 60100). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Deduplicate identical typecheck errors between platforms.
      
      **What this PR does / why we need it**: Deduplicate identical typecheck errors between platforms.
      
      This will make typecheck output shorter for code that fails compilation everywhere,
      like [this](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/61869/pull-kubernetes-typecheck/3274/).
      
      **Release note**:
      ```release-note
      NONE
      ```
      6c107fcc
    • Kubernetes Submit Queue's avatar
      Merge pull request #61307 from filbranden/curl1 · fe7514cf
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61829, 61908, 61307, 61872, 60100). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Use curl instead of wget to fetch the CNI tarball in e2e-node test
      
      **What this PR does / why we need it**:
      
      Curl is more ubiquitous than wget. For instance, the GCE centos-7 and rhel-7 image families ship curl by default, but not wget.
      
      Looking at the shell scripts under cluster/, they tend to use curl more than wget. (The ones that use wget, such as get-kube.sh, try curl first and only fallback to wget if it's not available.)
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      
      Fixes running node e2e test on centos-7 or rhel-7 image families provided in GCE.
      
      **Special notes for your reviewer**:
      
      Tested by running node-e2e-test on Ubuntu, COS and CentOS.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      fe7514cf
    • Kubernetes Submit Queue's avatar
      Merge pull request #61908 from MrHohn/kube-dns-1.14.9 · 7cf5974c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61829, 61908, 61307, 61872, 60100). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Update kube-dns to Version 1.14.9
      
      **What this PR does / why we need it**:
      
      kube-dns version bump for kubeadm will be on a speparate PR.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #NONE 
      
      **Special notes for your reviewer**:
      /assign @rramkumar1 @bowei 
      
      **Release note**:
      
      ```release-note
      Update kube-dns to Version 1.14.9. Major changes:
      - Fix for kube-dns returns NXDOMAIN when not yet synced with apiserver.
      - Don't generate empty record for externalName service.
      - Add validation for upstreamNameserver port.
      - Update go version to 1.9.3.
      ```
      7cf5974c
    • Kubernetes Submit Queue's avatar
      Merge pull request #61829 from jonyhy96/patch-4 · d23d523b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 61829, 61908, 61307, 61872, 60100). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix comment error
      
      fix comment error
      ```release-note
      None
      ```
      d23d523b
  2. 29 Mar, 2018 21 commits
  3. 28 Mar, 2018 11 commits