Commit e953f4a0 authored by k8s-merge-robot's avatar k8s-merge-robot

Merge pull request #19628 from mikedanese/dns-headless

Auto commit by PR queue bot
parents b276a98b 69add2fb
...@@ -337,13 +337,13 @@ func (ks *kube2sky) generateSRVRecord(subdomain, portSegment, recordName, cName ...@@ -337,13 +337,13 @@ func (ks *kube2sky) generateSRVRecord(subdomain, portSegment, recordName, cName
} }
func (ks *kube2sky) addDNS(subdomain string, service *kapi.Service) error { func (ks *kube2sky) addDNS(subdomain string, service *kapi.Service) error {
if len(service.Spec.Ports) == 0 {
glog.Fatalf("Unexpected service with no ports: %v", service)
}
// if ClusterIP is not set, a DNS entry should not be created // if ClusterIP is not set, a DNS entry should not be created
if !kapi.IsServiceIPSet(service) { if !kapi.IsServiceIPSet(service) {
return ks.newHeadlessService(subdomain, service) return ks.newHeadlessService(subdomain, service)
} }
if len(service.Spec.Ports) == 0 {
glog.Info("Unexpected service with no ports, this should not have happend: %v", service)
}
return ks.generateRecordsForPortalService(subdomain, service) return ks.generateRecordsForPortalService(subdomain, service)
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment