Commit 69add2fb authored by Mike Danese's avatar Mike Danese

dns: don't die when a headless service declares no ports

Headless services are not required to declare ports. Signed-off-by: 's avatarMike Danese <mikedanese@google.com>
parent 10f7985d
......@@ -338,13 +338,13 @@ func (ks *kube2sky) generateSRVRecord(subdomain, portSegment, recordName, cName
}
func (ks *kube2sky) addDNS(subdomain string, service *kapi.Service) error {
if len(service.Spec.Ports) == 0 {
glog.Fatalf("Unexpected service with no ports: %v", service)
}
// if ClusterIP is not set, a DNS entry should not be created
if !kapi.IsServiceIPSet(service) {
return ks.newHeadlessService(subdomain, service)
}
if len(service.Spec.Ports) == 0 {
glog.Info("Unexpected service with no ports, this should not have happend: %v", service)
}
return ks.generateRecordsForPortalService(subdomain, service)
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment