Skip to content

K
k3s
Commit 4e3bd25a authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #46590 from yastij/disruption-getPodsForPdb

Automatic merge from submit-queue avoiding unnecessary loop to copy pods listed **What this PR does / why we need it**: avoids unnecessary loop to copy pods listed **Which issue this PR fixes** : fixes #46433 **Release note**: ```release-note ``` /assign @wojtek-t
parents 82765ba3 cc5977aa
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 6 deletions
pkg/controller/disruption/disruption.go
View file @ 4e3bd25a
......@@ -421,6 +421,8 @@ func (dc *DisruptionController) getPdbForPod(pod *v1.Pod) *policy.PodDisruptionB
return pdbs[0]
}
// This function returns pods using the PodDisruptionBudget object.
// IMPORTANT NOTE : the returned pods should NOT be modified.
func (dc *DisruptionController) getPodsForPdb(pdb *policy.PodDisruptionBudget) ([]*v1.Pod, error) {
sel, err := metav1.LabelSelectorAsSelector(pdb.Spec.Selector)
if sel.Empty() {
......@@ -433,12 +435,7 @@ func (dc *DisruptionController) getPodsForPdb(pdb *policy.PodDisruptionBudget) (
if err != nil {
return []*v1.Pod{}, err
}
// TODO: Do we need to copy here?
result := make([]*v1.Pod, 0, len(pods))
for i := range pods {
result = append(result, &(*pods[i]))
}
return result, nil
return pods, nil
}
func (dc *DisruptionController) worker() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment