Unverified Commit 3a266a1b authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #65368 from deads2k/server-17-discovery

Automatic merge from submit-queue (batch tested with PRs 61330, 64793, 64675, 65059, 65368). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. legacy api endpoints only support v1 ever The legacy API endpoint should only ever have a v1. This removes flexibility we don't need or want. @kubernetes/sig-api-machinery-pr-reviews @sttts ```release-note NONE ```
parents 039a83ee b063e9f8
...@@ -32,23 +32,21 @@ import ( ...@@ -32,23 +32,21 @@ import (
// legacyRootAPIHandler creates a webservice serving api group discovery. // legacyRootAPIHandler creates a webservice serving api group discovery.
type legacyRootAPIHandler struct { type legacyRootAPIHandler struct {
// addresses is used to build cluster IPs for discovery. // addresses is used to build cluster IPs for discovery.
addresses Addresses addresses Addresses
apiPrefix string apiPrefix string
serializer runtime.NegotiatedSerializer serializer runtime.NegotiatedSerializer
apiVersions []string
} }
func NewLegacyRootAPIHandler(addresses Addresses, serializer runtime.NegotiatedSerializer, apiPrefix string, apiVersions []string) *legacyRootAPIHandler { func NewLegacyRootAPIHandler(addresses Addresses, serializer runtime.NegotiatedSerializer, apiPrefix string) *legacyRootAPIHandler {
// Because in release 1.1, /apis returns response with empty APIVersion, we // Because in release 1.1, /apis returns response with empty APIVersion, we
// use stripVersionNegotiatedSerializer to keep the response backwards // use stripVersionNegotiatedSerializer to keep the response backwards
// compatible. // compatible.
serializer = stripVersionNegotiatedSerializer{serializer} serializer = stripVersionNegotiatedSerializer{serializer}
return &legacyRootAPIHandler{ return &legacyRootAPIHandler{
addresses: addresses, addresses: addresses,
apiPrefix: apiPrefix, apiPrefix: apiPrefix,
serializer: serializer, serializer: serializer,
apiVersions: apiVersions,
} }
} }
...@@ -71,7 +69,7 @@ func (s *legacyRootAPIHandler) handle(req *restful.Request, resp *restful.Respon ...@@ -71,7 +69,7 @@ func (s *legacyRootAPIHandler) handle(req *restful.Request, resp *restful.Respon
clientIP := utilnet.GetClientIP(req.Request) clientIP := utilnet.GetClientIP(req.Request)
apiVersions := &metav1.APIVersions{ apiVersions := &metav1.APIVersions{
ServerAddressByClientCIDRs: s.addresses.ServerAddressByClientCIDRs(clientIP), ServerAddressByClientCIDRs: s.addresses.ServerAddressByClientCIDRs(clientIP),
Versions: s.apiVersions, Versions: []string{"v1"},
} }
responsewriters.WriteObjectNegotiated(s.serializer, schema.GroupVersion{}, resp.ResponseWriter, req.Request, http.StatusOK, apiVersions) responsewriters.WriteObjectNegotiated(s.serializer, schema.GroupVersion{}, resp.ResponseWriter, req.Request, http.StatusOK, apiVersions)
......
...@@ -341,14 +341,9 @@ func (s *GenericAPIServer) InstallLegacyAPIGroup(apiPrefix string, apiGroupInfo ...@@ -341,14 +341,9 @@ func (s *GenericAPIServer) InstallLegacyAPIGroup(apiPrefix string, apiGroupInfo
return err return err
} }
// setup discovery
apiVersions := []string{}
for _, groupVersion := range apiGroupInfo.PrioritizedVersions {
apiVersions = append(apiVersions, groupVersion.Version)
}
// Install the version handler. // Install the version handler.
// Add a handler at /<apiPrefix> to enumerate the supported api versions. // Add a handler at /<apiPrefix> to enumerate the supported api versions.
s.Handler.GoRestfulContainer.Add(discovery.NewLegacyRootAPIHandler(s.discoveryAddresses, s.Serializer, apiPrefix, apiVersions).WebService()) s.Handler.GoRestfulContainer.Add(discovery.NewLegacyRootAPIHandler(s.discoveryAddresses, s.Serializer, apiPrefix).WebService())
return nil return nil
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment