rpmgs: download_any_tarball: use cached tarball with return, not continue

If the target tarball already exists in RPMSOURCEDIR and FORCEDOWNLOAD is not set, the previous code did 'continue' inside the FORMATS loop, which just iterated through extensions (always finding the same cached file) and ultimately fell through to 'fatal'. Move the cache check out of the loop and 'return' when a valid cached copy exists.

rpmgs: download_any_tarball: use cached tarball with return, not continue
100bfe8d · Vitaly Lipatov · acecbc64 · 100bfe8d
Commit 100bfe8d authored May 05, 2026 by Vitaly Lipatov
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

rpmgs bin/rpmgs +3 -1

No files found.
--- a/bin/rpmgs
+++ b/bin/rpmgs
@@ -187,10 +187,12 @@ download_any_tarball()

 	BASESOURCE=$(dirname "$BASESOURCE")/$(basename "$BASESOURCE" .$ORIGEXT)

+	# tarball already cached locally - use it instead of redownloading
+	[ -z "$FORCEDOWNLOAD" ] && check_tarball "$TARGET" && { echo "$TARGET already exists, using cached copy" ; return ; }
+
 	local ext
 	# try download by exts list
 	for ext in $FORMATS ; do
-		[ -z "$FORCEDOWNLOAD" ] && check_tarball "$TARGET" && { echo "$TARGET already exists, continue... " ; continue; }
 		download_to "$BASESOURCE.$ext" "$TARGET" || continue
 		return
 	done