• Kubernetes Submit Queue's avatar
    Merge pull request #43231 from csbell/service-race · f8803403
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    [Federation] Fix deletion logic in service controller
    
    This is a regression from 1.5 exposed by cascading deletions. In order to apply updates, the service controller locks access to a cached service and spawns go routines without waiting for them. When updates and deletions arrive in quick succession, previous goroutines remain active and race with the deletion logic. Coupled with this, the service_helper was not re-evaluating the value of the DeletionTimestamp.
    
    Without this patch, federation will sometimes leak resources at destruction time about half the time.
    
    In e2e land, about 4-5 test runs cause service tests to eat up all global fwd-ing rules and in turn, every subsequent ingress test will fail until we manually clean up leaked resources. No possibility to go green in fed e2e until this is merged.
    f8803403
Name
Last commit
Last update
..
cluster Loading commit data...
configmap Loading commit data...
daemonset Loading commit data...
deployment Loading commit data...
ingress Loading commit data...
namespace Loading commit data...
replicaset Loading commit data...
secret Loading commit data...
service Loading commit data...
util Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
doc.go Loading commit data...