• Jan Safranek's avatar
    Fixed races in Cinder volume attach/detach. · 220163f6
    Jan Safranek authored
    Add a mutex to guard SetUpAt() and TearDownAt() calls - they should not
    run in parallel.  There is a race in these calls when there are two pods
    using the same volume, one of them is dying and the other one starting.
    
    TearDownAt() checks that a volume is not needed by any pods and detaches the
    volume. It does so by counting how many times is the volume mounted
    (GetMountRefs() call below).
    
    When SetUpAt() of the starting pod already attached the volume and did not mount
    it yet, TearDownAt() of the dying pod will detach it - GetMountRefs() does not
    count with this volume.
    
    These two threads run in parallel:
    
     dying pod.TearDownAt("myVolume")          starting pod.SetUpAt("myVolume")
       |                                       |
       |                                       AttachDisk("myVolume")
       refs, err := mount.GetMountRefs()       |
       Unmount("myDir")                        |
       if refs == 1 {                          |
       |  |                                    Mount("myVolume", "myDir")
       |  |                                    |
       |  DetachDisk("myVolume")               |
       |                                       start containers - OOPS! The volume is detached!
       |
       finish the pod cleanup
    
    
    Also, add some logs to cinder plugin for easier debugging in the future, add
    a test and update the fake mounter to know about bind mounts.
    220163f6
Name
Last commit
Last update
..
doc.go Loading commit data...
fake.go Loading commit data...
mount.go Loading commit data...
mount_linux.go Loading commit data...
mount_linux_test.go Loading commit data...
mount_unsupported.go Loading commit data...
nsenter_mount.go Loading commit data...
nsenter_mount_unsupported.go Loading commit data...
safe_format_and_mount_test.go Loading commit data...