• k8s-merge-robot's avatar
    Merge pull request #26942 from xiangpengzhao/fix_testcase · 5a7b52b8
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    Fix panic in schema test
    
    If the swagger files for testing are lost, the func `loadSchemaForTest` or `NewSwaggerSchemaFromBytes` will return a non-nil error and a nil schema. In this case, the calling for `ValidateBytes` will result in panic. So, call Fatalf instead of Errorf.
    
    Also fix minor typos.
    
    Test logs:
    
    ```
    --- FAIL: TestLoad (0.01s)
    	schema_test.go:131: Failed to load: open ../../../api/swagger-spec/v1.json: no such file or directory
    --- FAIL: TestValidateOk (0.00s)
    	schema_test.go:138: Failed to load: open ../../../api/swagger-spec/v1.json: no such file or directory
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    	panic: runtime error: invalid memory address or nil pointer dereference
    [signal 0xb code=0x1 addr=0x20 pc=0x4d52df]
    
    goroutine 10 [running]:
    panic(0x15fffa0, 0xc8200100a0)
    	/usr/local/go/src/runtime/panic.go:481 +0x3e6
    testing.tRunner.func1(0xc820085a70)
    	/usr/local/go/src/testing/testing.go:467 +0x192
    panic(0x15fffa0, 0xc8200100a0)
    	/usr/local/go/src/runtime/panic.go:443 +0x4e9
    k8s.io/kubernetes/pkg/api/validation.TestValidateOk(0xc820085a70)
    	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/api/validation/schema_test.go:159 +0x79f
    testing.tRunner(0xc820085a70, 0x22aad68)
    	/usr/local/go/src/testing/testing.go:473 +0x98
    created by testing.RunTests
    	/usr/local/go/src/testing/testing.go:582 +0x892
    FAIL	k8s.io/kubernetes/pkg/api/validation	0.048s
    ```
    5a7b52b8
Name
Last commit
Last update
..
annotations Loading commit data...
endpoints Loading commit data...
errors Loading commit data...
install Loading commit data...
meta Loading commit data...
pod Loading commit data...
resource Loading commit data...
rest Loading commit data...
service Loading commit data...
testapi Loading commit data...
testing Loading commit data...
unversioned Loading commit data...
util Loading commit data...
v1 Loading commit data...
validation Loading commit data...
OWNERS Loading commit data...
context.go Loading commit data...
context_test.go Loading commit data...
conversion.go Loading commit data...
conversion_test.go Loading commit data...
copy_test.go Loading commit data...
deep_copy_test.go Loading commit data...
doc.go Loading commit data...
field_constants.go Loading commit data...
generate.go Loading commit data...
generate_test.go Loading commit data...
helpers.go Loading commit data...
helpers_test.go Loading commit data...
mapper.go Loading commit data...
meta.go Loading commit data...
meta_test.go Loading commit data...
node_example.json Loading commit data...
ref.go Loading commit data...
ref_test.go Loading commit data...
register.go Loading commit data...
replication_controller_example.json Loading commit data...
requestcontext.go Loading commit data...
resource_helpers.go Loading commit data...
resource_helpers_test.go Loading commit data...
serialization_proto_test.go Loading commit data...
serialization_test.go Loading commit data...
types.generated.go Loading commit data...
types.go Loading commit data...
zz_generated.deepcopy.go Loading commit data...