• k8s-merge-robot's avatar
    Merge pull request #22568 from abhgupta/abhgupta-dev · 9a2ad73c
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    Considering all nodes for the scheduler cache to allow lookups
    
    Fixes the actual issue that led me to create https://github.com/kubernetes/kubernetes/issues/22554
    
    Currently the nodes in the cache provided to the predicates excludes the unschedulable nodes using field level filtering for the watch results. This results in the above issue as the `ServiceAffinity` predicate uses the cached node list to look up the node metadata for a peer pod (another pod belonging to the same service). Since this peer pod could be currently hosted on a node that is currently unschedulable, the lookup could potentially fail, resulting in the pod failing to be scheduled.
    
    As part of the fix, we are now including all nodes in the watch results and excluding the unschedulable nodes using `NodeCondition`
    
    @derekwaynecarr PTAL
    9a2ad73c
Name
Last commit
Last update
..
admission Loading commit data...
auth Loading commit data...
client/auth Loading commit data...
scheduler Loading commit data...
webhook Loading commit data...