• Kubernetes Submit Queue's avatar
    Merge pull request #36542 from Random-Liu/clarify-cri-user · f4a7b64b
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    CRI: Clarify User in CRI.
    
    Addressed https://github.com/kubernetes/kubernetes/pull/36423#issuecomment-259343135.
    
    This PR clarifies the user related fields in CRI.
    
    One question is that:
    What is the meaning of the `run_as_user` field in `LinuxSandboxSecurityContext`?
    * **Is it user on the host?** Then it doesn't make sense, user shouldn't care about what users are on the host.
    * **Is it user inside the infra container image?** This is how the field is currently used. However, Infra container is docker specific, I'm not sure whether we should expose this in CRI.
    * **Is it the default user inside the pod?** It tells runtime that if there is a container (infra container, or some other helper containers like streaming container etc.), if their `user` is not specified, use the default "sandbox user". Then how can we guarantee that infra or helper container image have the `user`?
    * **It doesn't make sense?** If we remove it, we are relying on the shim to set right user (maybe always root) for infra or helper containers (if there will be any in the future), I'm not sure whether this is what we expect.
    
    @yujuhong @feiskyer @jonboulle @yifan-gu 
    /cc @kubernetes/sig-node
    f4a7b64b
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build-tools Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
contrib Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
hooks Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
vendor Loading commit data...
www Loading commit data...
.generated_docs Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
BUILD Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIB.md Loading commit data...
CONTRIBUTING.md Loading commit data...
DESIGN.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
Vagrantfile Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...