• Kubernetes Submit Queue's avatar
    Merge pull request #54704 from dims/try-clean-up-stores · d7567cd6
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 53796, 54666, 54516, 54625, 54704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Fix TestCRD Flake
    
    **What this PR does / why we need it**:
    
    The DestroyFunc functions returned by generic.NewRawStorage is never
    called when we do a StartTestServer() in the test suite. For a quick
    hack for now, added TrackStorageCleanup/RegisterStorageCleanup and
    CleanupStorage. Note that unless TrackStorageCleanup is called (which
    is called only from the test suite) the other two methods are
    no-ops essentially. So no change in behavior at runtime. This vastly
    brings down the number of goroutines that are left behind when this
    test is executed and should reduce if not eliminate the flakiness
    of TestCRD
    
    **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    d7567cd6
Name
Last commit
Last update
..
admissionregistration Loading commit data...
apps Loading commit data...
authentication Loading commit data...
authorization Loading commit data...
autoscaling Loading commit data...
batch Loading commit data...
cachesize Loading commit data...
certificates Loading commit data...
core Loading commit data...
extensions Loading commit data...
networking Loading commit data...
policy Loading commit data...
rbac Loading commit data...
registrytest Loading commit data...
scheduling Loading commit data...
settings Loading commit data...
storage Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
doc.go Loading commit data...