• k8s-merge-robot's avatar
    Merge pull request #25443 from nikhiljindal/tryingClientGen · 0165fd2f
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    Adding Services to federation clientset
    
    Commits:
    1. Regenerate the client without any changes to client-gen
    2. Update clientgen to add a parameter to specify generating client only for Services v1 object.
    3. Regenerate federation_internalclientset
    4. Regenerate federation_release_1_3
    
    
    Second commit is the most important one. Other 3 commits are auto generated by running client-gen.
    I have added a command line argument to client-gen that takes in a list of group/version/resource. If a group version is part of this list, then only the resources in this list are included in the client. For other group versions, the existing check of genclient=true in types.go is used.
    
    Other alternatives considered were:
    * Update genclient in types.go to mention the clientset name in which it should be included instead of just saying genclient=true (so Services will say genclient=core,federation while all other v1 resources will say genclient=core). This requires a code change in types.go to change a client set.
    * Create another types.go which will only include Services and use that to generate federation clientset. This will lead to duplicate Service definition.
    
    
    cc @caesarxuchao @lavalamp @jianhuiz @mfanjie @kubernetes/sig-cluster-federation 
    
    <!-- Reviewable:start -->
    ---
    This change is [<img src="http://reviewable.k8s.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](http://reviewable.k8s.io/reviews/kubernetes/kubernetes/25443)
    <!-- Reviewable:end -->
    0165fd2f
Name
Last commit
Last update
..
exceptions.txt Loading commit data...
excluded-flags.txt Loading commit data...
known-flags.txt Loading commit data...