• k8s-merge-robot's avatar
    Merge pull request #29581 from Random-Liu/panic-if-cadvisor-not-started · ed3a29bd
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    Kubelet: Fail kubelet if cadvisor is not started.
    
    Fixes https://github.com/kubernetes/kubernetes/issues/28997.
    
    We started cadvisor in `sync.Do()`, which only run once no matter cadvisor successfully starts or not.
    
    Once it fails, kubelet will be stuck in a bad state. Kubelet could never start sync loop because there is an internal error, but kubelet would never retry starting cadvisor again.
    
    This PR just fails kubelet when cadvisor start fails, and then relies on the babysitter to restart kubelet.
    In the future, we may want to add backoff logic in the babysitter to protect the system.
    
    On the other hand, https://github.com/kubernetes/kubernetes/pull/29492 will fix cadvisor side to prevent cadvisor failing because of these kind of transient error.
    
    Mark P1 to match the original issue.
    
    @dchen1107 @vishh 
    ed3a29bd
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api/swagger-spec Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
contrib Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
hooks Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
release Loading commit data...
test Loading commit data...
third_party Loading commit data...
vendor Loading commit data...
www Loading commit data...
.generated_docs Loading commit data...
.gitignore Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIB.md Loading commit data...
CONTRIBUTING.md Loading commit data...
DESIGN.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
README.md Loading commit data...
Vagrantfile Loading commit data...
code-of-conduct.md Loading commit data...