• k8s-merge-robot's avatar
    Merge pull request #24900 from ericchiang/rbac_types · f45bcc5f
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    pkg/apis/rbac: Add Openshift authorization API types
    
    This PR updates #23396 by adding the Openshift RBAC types to a new API group.
    
    Changes from Openshift:
    
    * Omission of [ResourceGroups](https://github.com/openshift/origin/blob/458998788337e983fa3e5f9a837664ec00a89204/pkg/authorization/api/types.go#L32-L104) as most of these were Openshift specific. Would like to add the concept back in for a later release of the API.
    * Omission of IsPersonalSubjectAccessReview as its implementation relied on Openshift capability.
    * Omission of SubjectAccessReview and ResourceAccessReview types. These are defined in `authorization.k8s.io`
    
    ~~API group is named `rbac.authorization.openshift.com` as we omitted the AccessReview stuff and that seemed to be the lest controversial based on conversations in #23396. Would be happy to change it if there's a dislike for the name.~~ Edit: API groups is named `rbac`, sorry misread the original thread.
    
    As discussed in #18762, creating a new API group is kind difficult right now and the documentation is very out of date. Got a little help from @soltysh but I'm sure I'm missing some things. Also still need to add validation and a RESTStorage registry interface. Hence "WIP".
    
    Any initial comments welcome.
    
    cc @erictune @deads2k @sym3tri @philips
    f45bcc5f
Name
Last commit
Last update
..
args Loading commit data...
client-gen Loading commit data...
conversion-gen Loading commit data...
deepcopy-gen Loading commit data...
generator Loading commit data...
go-to-protobuf Loading commit data...
import-boss Loading commit data...
namer Loading commit data...
parser Loading commit data...
set-gen Loading commit data...
types Loading commit data...
.import-restrictions Loading commit data...
OWNERS Loading commit data...