• Kubernetes Submit Queue's avatar
    Merge pull request #52052 from joelsmith/master · dfdfb893
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Clean up kublet secret and configmap unit test
    
    **What this PR does / why we need it**:
    
    These changes are clean-up items to fix confusing code encountered while investigating #52043. No actual bugs are fixed here (except, maybe, correcting unit tests that had actual/expected swapped).
    
    A summary of the changes, as listed in the commit:
    
    * Expected value comes before actual value in assert.Equal()
    * Use `assert.Equal()` instead of `assert.True()` when possible
    * Add a unit test that verifies no-op pod updates to the `secret_manager` and the `configmap_manager`
    * Add a clarifying comment about why it's good to seemingly delete a secret on updates.
    * Fix (for now, non-buggy) variable shadowing issue
    
    **Special notes for your reviewer**:
    
    N/A
    
    **Release note**:
    ```release-note
    NONE
    ```
    dfdfb893
Name
Last commit
Last update
..
BUILD Loading commit data...
configmap_manager.go Loading commit data...
configmap_manager_test.go Loading commit data...
fake_manager.go Loading commit data...