• k8s-merge-robot's avatar
    Merge pull request #23381 from kinvolk/alban/apache-log · 31de6221
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    examples/guestbook/php-redis: don't reopen stdio fds
    
    /etc/apache2/apache2.conf was configured to log in this way:
    > ErrorLog /proc/self/fd/2
    > CustomLog /proc/self/fd/1 combined
    
    This causes apache to reopen the already-opened fds. It works fine when
    the file descriptors are pipes or ttys but it fails when they are Unix
    sockets because sockets cannot be opened with the open() syscall. The
    issue happens when apache is connected to systemd-journald, like in the
    rkt container run-time.
    
    This patch uses "cat" to directly write to the stdio fds without
    reopening them. apache2.conf now looks like:
    > ErrorLog "|$/bin/cat 1>&2"
    > CustomLog "|/bin/cat" combined
    
    It works both with Docker and rkt (tested with and without
    --interactive).
    
    Symptoms:
    > [ 2673.478868] apache2-foreground[4]: (6)No such device or address:
    > AH00091: apache2: could not open error log file /proc/self/fd/2.
    
    See also: https://github.com/coreos/rkt/issues/2300
    
    -----
    
    /cc @sjpotter @yifan-gu @jonboulle
    31de6221
Name
Last commit
Last update
..
all-in-one Loading commit data...
legacy Loading commit data...
php-redis Loading commit data...
redis-slave Loading commit data...
README.md Loading commit data...
frontend-deployment.yaml Loading commit data...
frontend-service.yaml Loading commit data...
redis-master-deployment.yaml Loading commit data...
redis-master-service.yaml Loading commit data...
redis-slave-deployment.yaml Loading commit data...
redis-slave-service.yaml Loading commit data...