• Kubernetes Submit Queue's avatar
    Merge pull request #38683 from bruceauyeung/k8s-branch-fix-possible-nil-error · 4166c0e4
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    avoid repeated length calculation and some other code improvements
    
    **What this PR does / why we need it**:
    1. in function `ParsePairs`,  calculating `invalidBuf`'s length over and over again brings performance penalty. a `invalidBufNonEmpty` bool value can fix this.
    2. pairArg is not a string template and also there is no other arguments for `fmt.Sprintf`, so i remove `fmt.Sprintf`
    3. in function `DumpReaderToFile`, we must check nil error first before defer statement, otherwise there maybe a potential nil error on `f.Close()`
    4. add nil checks into `GetWideFlag` function
    5. some other minor code improvements for better readability.
    Signed-off-by: 's avatarbruceauyeung <ouyang.qinhua@zte.com.cn>
    4166c0e4
Name
Last commit
Last update
..
cmd Loading commit data...
metricsutil Loading commit data...
resource Loading commit data...
testing Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
apply.go Loading commit data...
autoscale.go Loading commit data...
bash_comp_utils.go Loading commit data...
cluster.go Loading commit data...
cluster_test.go Loading commit data...
clusterrolebinding.go Loading commit data...
configmap.go Loading commit data...
configmap_test.go Loading commit data...
custom_column_printer.go Loading commit data...
custom_column_printer_test.go Loading commit data...
deployment.go Loading commit data...
deployment_test.go Loading commit data...
describe.go Loading commit data...
describe_test.go Loading commit data...
doc.go Loading commit data...
explain.go Loading commit data...
generate.go Loading commit data...
generate_test.go Loading commit data...
history.go Loading commit data...
interfaces.go Loading commit data...
kubectl.go Loading commit data...
kubectl_test.go Loading commit data...
namespace.go Loading commit data...
namespace_test.go Loading commit data...
pdb.go Loading commit data...
proxy_server.go Loading commit data...
proxy_server_test.go Loading commit data...
quota.go Loading commit data...
quota_test.go Loading commit data...
resource_filter.go Loading commit data...
resource_printer.go Loading commit data...
resource_printer_test.go Loading commit data...
rolebinding.go Loading commit data...
rollback.go Loading commit data...
rolling_updater.go Loading commit data...
rolling_updater_test.go Loading commit data...
rollout_status.go Loading commit data...
rollout_status_test.go Loading commit data...
run.go Loading commit data...
run_test.go Loading commit data...
scale.go Loading commit data...
scale_test.go Loading commit data...
secret.go Loading commit data...
secret_for_docker_registry.go Loading commit data...
secret_for_docker_registry_test.go Loading commit data...
secret_for_tls.go Loading commit data...
secret_for_tls_test.go Loading commit data...
secret_test.go Loading commit data...
service.go Loading commit data...
service_basic.go Loading commit data...
service_basic_test.go Loading commit data...
service_test.go Loading commit data...
serviceaccount.go Loading commit data...
serviceaccount_test.go Loading commit data...
sorted_resource_name_list.go Loading commit data...
sorted_resource_name_list_test.go Loading commit data...
sorting_printer.go Loading commit data...
sorting_printer_test.go Loading commit data...
stop.go Loading commit data...
stop_test.go Loading commit data...
versioned_client.go Loading commit data...