• Kubernetes Submit Queue's avatar
    Merge pull request #43422 from liggitt/convert-null-list · 51beb16e
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    Ensure slices are serialized as zero-length, not null
    
    Fixes https://github.com/kubernetes/kubernetes/issues/43203 null serialization of slices to prevent NPE errors in clients that store and expect to receive non-null JSON values in these fields.
    
    Ensures when we are converting to an external slice field that will be serialized even if empty (has `json` tag that does not include `omitempty`), we populate it with `[]`, not `nil`
    
    Other places I considered putting this logic instead:
    
    * When unmarshaling
      * Would have to be done for both protobuf and ugorji
      * Would still have to be done here (or on marshal) to handle cases where we construct objects to return
    * When marshaling
      * Would have to switch to use custom json marshaler (currently we use stdlib)
    * When defaulting
      * Defaulting isn't run on some fields, notably, pod template in rc/deployment spec
      * Would still have to be done here (or on marshal) to handle cases where we construct objects to return
    
    ```release-note
    API fields that previously serialized null arrays as `null` and empty arrays as `[]` no longer distinguish between those values and always output `[]` when serializing to JSON.
    ```
    51beb16e
Name
Last commit
Last update
..
api Loading commit data...
apimachinery/tests Loading commit data...
apis Loading commit data...
auth Loading commit data...
bootstrap/api Loading commit data...
capabilities Loading commit data...
client Loading commit data...
cloudprovider Loading commit data...
controller Loading commit data...
conversion Loading commit data...
credentialprovider Loading commit data...
features Loading commit data...
fieldpath Loading commit data...
fields Loading commit data...
generated Loading commit data...
hyperkube Loading commit data...
kubeapiserver Loading commit data...
kubectl Loading commit data...
kubelet Loading commit data...
kubemark Loading commit data...
labels Loading commit data...
master Loading commit data...
metrics Loading commit data...
printers Loading commit data...
probe Loading commit data...
proxy Loading commit data...
quota Loading commit data...
registry Loading commit data...
routes Loading commit data...
runtime Loading commit data...
security Loading commit data...
securitycontext Loading commit data...
serviceaccount Loading commit data...
ssh Loading commit data...
types Loading commit data...
util Loading commit data...
version Loading commit data...
volume Loading commit data...
watch Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...