• Joseph Burnett's avatar
    There are various reasons that the HPA will decide not the change the · d881d48b
    Joseph Burnett authored
    current scale. Two important ones are when missing metrics might
    change the direction of scaling, and when the recommended scale is
    within tolerance of the current scale.
    
    The way that ReplicaCalculator signals it's desire to not change the
    current scale is by returning the current scale. However the current
    scale is from scale.Status.Replicas and can be larger than
    scale.Spec.Replicas (e.g. during Deployment rollout with configured
    surge). This causes a positive feedback loop because
    scale.Status.Replicas is written back into scale.Spec.Replicas,
    further increasing the current scale.
    
    This PR fixes the feedback loop by plumbing the replica count from
    spec through horizontal.go and replica_calculator.go so the calculator
    can punt with the right value.
    d881d48b
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
docs Loading commit data...
hack Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
translations Loading commit data...
vendor Loading commit data...
.bazelrc Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.kazelcfg.json Loading commit data...
BUILD.bazel Loading commit data...
CHANGELOG-1.14.md Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
SECURITY_CONTACTS Loading commit data...
SUPPORT.md Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...