-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Support kubernetes-anywhere provider **What this PR does / why we need it**: Implements a new `kubernetes-anywhere` provider to allow upgrade testing in the e2e binary. This is the final step to allow https://github.com/kubernetes/test-infra/pull/4495 and https://github.com/kubernetes/kubernetes-anywhere/pull/450. **Which issue this PR fixes**: https://github.com/kubernetes/kubeadm/issues/311 **Special notes for your reviewer**: Some questions I had - Does the `--provider` flag specified [here](https://github.com/jamiehannaford/test-infra/blob/dbbf6261e0b44fc81944ed5c3b7152005cc0f1ff/jobs/config.json#L8587) get sent to the flag defined [here](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/test_context.go#L219)? Or should I add another `--provider` flag inside `--upgrade_args` like this: `--upgrade_args=... --provider=kubernetes-anywhere`? - Is it necessary to add waiting logic after the `make` command, or will it implicitly handle that by itself? Some other points: - I chose `sed` to manipulate the current kubernetes-anywhere `.config` rather than duplicating another [`anywhere.go`](https://github.com/kubernetes/test-infra/blob/master/kubetest/anywhere.go). One suggestion was to use `jq` but since the config on disk is not serialized to JSON yet, I'm not sure how that'd work. - Since I don't have a GCE/GKE account or vCenter, I can't actually verify the e2e binary works. I've managed to build it, but if somebody could quickly run a smoke test, I'd appreciate it. This is my first poke around test-infra and e2e, so there might be some plumbing missing /cc @jessicaochen @luxas @pipejakob @roberthbailey
654c522e
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| e2e | ||
| e2e_federation | ||
| e2e_node | ||
| fixtures | ||
| images | ||
| integration | ||
| kubemark | ||
| list | ||
| soak | ||
| utils | ||
| BUILD | ||
| OWNERS | ||
| test_owners.csv | ||
| test_owners.json |